WidgetCache::getHash() - Code Metrics - Inspection of "Upgrade/filters" - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#351)

by Leny

created 2016-03-01 09:45 UTC

WidgetCache::getHash() B

↳ Parent: WidgetCache

Complexity

Conditions	5
Paths	3

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
c	3
b	1
f	1
dl	0
loc	18
rs	8.8571
cc	5
eloc	13
nc	3
nop	1

<?php

namespace Victoire\Bundle\WidgetBundle\Cache;

use Predis\Client;
use Victoire\Bundle\WidgetBundle\Entity\Widget;

/**
 * This class handle the saving of Widgets.
 * Widgets are stored for a week, but are invalidated as soon as
 * the Widget's or BusinessEntity's updatedAt field is changed.
 */
class WidgetCache
{
    /**
     * @var Client
     */
    private $redis;

    public function __construct(Client $redis)
    {
        $this->redis = $redis;
    }

    /**
     * @param Widget $widget
     *
     * @return string
     */
    public function fetch(Widget $widget)
    {
        return $this->redis->get($this->getHash($widget));
    }

    /**
     * @param Widget $widget
     * @param        $content
     */
    public function save(Widget $widget, $content)
    {
        $hash = $this->getHash($widget);
        if ($hash) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->redis->set($hash, $content);
            $this->redis->expire($hash, 7 * 24 * 60 * 1000); // cache for a week
        }
    }

    /**
     * @param Widget $widget
     *
     * @return string
     */
    protected function getHash(Widget $widget)
    {
        $hash = null;
        if ($widget->getMode() == Widget::MODE_BUSINESS_ENTITY
            && ($entity = $widget->getEntity())
            && method_exists($widget->getEntity(), 'getUpdatedAt')) {
            $hash = sprintf('%s-%s--%s-%s',
                $widget->getId(),
                $widget->getUpdatedAt()->getTimestamp(),
                $entity->getId(),

                $entity->getUpdatedAt()->getTimestamp()

            );
        } elseif ($widget->getMode() == Widget::MODE_STATIC) {
            $hash = sprintf('%s-%s', $widget->getId(), $widget->getUpdatedAt()->getTimestamp());
        }

        return $hash;
    }


}


1			<?php
2
3			namespace Victoire\Bundle\WidgetBundle\Cache;
4
5			use Predis\Client;
6			use Victoire\Bundle\WidgetBundle\Entity\Widget;
7
8			/**
9			* This class handle the saving of Widgets.
10			* Widgets are stored for a week, but are invalidated as soon as
11			* the Widget's or BusinessEntity's updatedAt field is changed.
12			*/
13			class WidgetCache
14			{
15			/**
16			* @var Client
17			*/
18			private $redis;
19
20			public function __construct(Client $redis)
21			{
22			$this->redis = $redis;
23			}
24
25			/**
26			* @param Widget $widget
27			*
28			* @return string
29			*/
30			public function fetch(Widget $widget)
31			{
32			return $this->redis->get($this->getHash($widget));
33			}
34
35			/**
36			* @param Widget $widget
37			* @param $content
38			*/
39			public function save(Widget $widget, $content)
40			{
41			$hash = $this->getHash($widget);
42			if ($hash) {
			0 ignored issues – show Bug Best Practice introduced 2016-02-29 22:25 UTC by Report Bug Copy Issue Report The expression `$hash` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
43			$this->redis->set($hash, $content);
44			$this->redis->expire($hash, 7 * 24 * 60 * 1000); // cache for a week
45			}
46			}
47
48			/**
49			* @param Widget $widget
50			*
51			* @return string
52			*/
53			protected function getHash(Widget $widget)
54			{
55			$hash = null;
56			if ($widget->getMode() == Widget::MODE_BUSINESS_ENTITY
57			&& ($entity = $widget->getEntity())
58			&& method_exists($widget->getEntity(), 'getUpdatedAt')) {
59			$hash = sprintf('%s-%s--%s-%s',
60			$widget->getId(),
61			$widget->getUpdatedAt()->getTimestamp(),
62			$entity->getId(),
			0 ignored issues – show Bug introduced 2016-02-29 22:25 UTC by Report Bug Copy Issue Report The method `getId` cannot be called on `$entity` (of type `integer\|double`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
63			$entity->getUpdatedAt()->getTimestamp()
			0 ignored issues – show Bug introduced 2016-02-29 22:25 UTC by Report Bug Copy Issue Report The method `getUpdatedAt` cannot be called on `$entity` (of type `integer\|double`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
64			);
65			} elseif ($widget->getMode() == Widget::MODE_STATIC) {
66			$hash = sprintf('%s-%s', $widget->getId(), $widget->getUpdatedAt()->getTimestamp());
67			}
68
69			return $hash;
70			}
71
72
73			}
74

Victoire / victoire

Pull Request — master (#351)

WidgetCache::getHash() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like