Victoire\Bundle\CoreBundle\Twig\Extension\RoutingExtension

Complexity

Total Complexity

18

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	18	1
C	getPath()	0	52	11
A	getPrefix()	0	13	6

<?php

namespace Victoire\Bundle\CoreBundle\Twig\Extension;

use Doctrine\ORM\EntityRepository;
use Psr\Log\LoggerInterface;
use Symfony\Bridge\Twig\Extension\RoutingExtension as BaseRoutingExtension;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Victoire\Bundle\I18nBundle\Resolver\LocaleResolver;
use Victoire\Bundle\PageBundle\Helper\PageHelper;
use Victoire\Bundle\ViewReferenceBundle\Exception\ViewReferenceNotFoundException;

/**
 * class RoutingExtension.
 */
class RoutingExtension extends BaseRoutingExtension
{
    private $pageHelper;
    private $generator;

Consider using a different property name as you override a private property of the parent class.

    private $localeResolver;
    private $logger;
    private $errorPageRepository;
    private $locale;

    /**
     * @param PageHelper            $pageHelper
     * @param UrlGeneratorInterface $generator
     * @param LocaleResolver        $localeResolver
     * @param RequestStack          $requestStack
     * @param LoggerInterface       $logger
     * @param EntityRepository      $errorPageRepository
     * @param                       $locale
     */
    public function __construct(
        PageHelper $pageHelper,
        UrlGeneratorInterface $generator,
        LocaleResolver $localeResolver,
        RequestStack $requestStack,
        LoggerInterface $logger,
        EntityRepository $errorPageRepository,
        $locale
    ) {
        $this->pageHelper = $pageHelper;
        $this->generator = $generator;
        $this->localeResolver = $localeResolver;
        $this->request = $requestStack->getCurrentRequest();

The property request does not exist. Did you maybe forget to declare it?

        $this->logger = $logger;
        $this->errorPageRepository = $errorPageRepository;
        parent::__construct($generator);
        $this->locale = $locale;
    }

    public function getPath($name, $parameters = [], $relative = false)
    {
        $requestLocale = $this->request ? $this->request->getLocale() : $this->locale;
        if ($name == 'victoire_core_page_show_by_id') {
            $params = [
                'viewId' => $parameters['viewId'],
                'locale' => $requestLocale,
            ];
            unset($parameters['viewId']);
            if (!empty($parameters['entityId'])) {
                $params['entityId'] = $parameters['entityId'];
                unset($parameters['entityId']);
            }

            try {
                $page = $this->pageHelper->findPageByParameters($params);
                $parameters['url'] = $page->getReference($requestLocale)->getUrl();
            } catch (ViewReferenceNotFoundException $e) {
                $this->logger->error($e->getMessage(), [
                    'params' => $params,
                ]);
                $errorPage = $this->errorPageRepository->findOneByCode(404);
                $parameters['url'] = $this->generator->generate(
                    'victoire_core_page_show',
                    array_merge(
                        [
                            '_locale' => $requestLocale,
                            'url'     => $errorPage ? $errorPage->getSlug() : '',
                        ],
                        $parameters
                    )
                );
            }

            $name = 'victoire_core_page_show';
        }

        $prefix = '';
        //if locale is passed (and different) and i18n strategy is "domain"
        if (!empty($parameters['_locale'])
            && $parameters['_locale'] != $requestLocale
            && $this->localeResolver->localePattern === LocaleResolver::PATTERN_DOMAIN
        ) {
            $prefix = $this->getPrefix($parameters['_locale']);
            //if we set a prefix, we don't want an absolute path
            if ($prefix) {

The expression $prefix of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

                $relative = true;
            }
        }

        return $prefix.$this->generator->generate($name, $parameters, $relative ? UrlGeneratorInterface::ABSOLUTE_PATH : UrlGeneratorInterface::ABSOLUTE_URL);
    }

    /**
     * If victoire_i18n.locale_pattern == domain, then we force the url rewrite with a valid host.
     *
     * @param $locale
     *
     * @return null
     */
    protected function getPrefix($locale)
    {
        foreach ($this->localeResolver->getDomainConfig() as $_domain => $_locale) {
            if ($_locale === $locale) {
                $urlPrefix = sprintf('%s://%s', $this->request ? $this->request->getScheme() : 'http', $_domain);
                if ($this->request && $this->request->getPort()) {
                    $urlPrefix .= ':'.$this->request->getPort();
                }

                return $urlPrefix;
            }
        }
    }
}