Victoire\Bundle\PageBundle\Entity\BasePage

Complexity

Total Complexity

8

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
B	getWebViewChildren()	0	18	7

<?php

namespace Victoire\Bundle\PageBundle\Entity;

use Doctrine\ORM\Mapping as ORM;
use Victoire\Bundle\BusinessPageBundle\Entity\BusinessTemplate;
use Victoire\Bundle\CoreBundle\Entity\View;
use Victoire\Bundle\CoreBundle\Entity\WebViewInterface;

/**
 * Page.
 *
 * @ORM\Entity(repositoryClass="Victoire\Bundle\PageBundle\Repository\BasePageRepository")
 * @ORM\Table("vic_base_page")
 * @ORM\HasLifecycleCallbacks
 */
abstract class BasePage extends View implements WebViewInterface

Abstract class name is not prefixed with "Abstract"

{
    use \Victoire\Bundle\PageBundle\Entity\Traits\WebViewTrait;

    /**
     * Construct.
     **/
    public function __construct()
    {
        parent::__construct();
        $this->publishedAt = new \DateTime();
        $this->status = PageStatus::PUBLISHED;
        $this->homepage = false;

The property $homepage was declared of type string, but false is of type false. Maybe add a type cast?

    }

    /**
     * Get WebView children.
     * Exclude unpublished or not published yet if asked.
     *
     * @param bool $excludeUnpublished
     *
     * @return string
     */
    public function getWebViewChildren($excludeUnpublished = false)
    {
        $webViewChildren = [];
        foreach ($this->children as $child) {
            if (!$child instanceof BusinessTemplate) {
                $notPublished = $child->getStatus() != PageStatus::PUBLISHED;
                $scheduledDateNotReached = $child->getStatus() == PageStatus::SCHEDULED && $child->getPublishedAt() > new \DateTime();

                if ($excludeUnpublished && ($notPublished || $scheduledDateNotReached)) {
                    continue;
                }

                $webViewChildren[] = $child;
            }
        }

        return $webViewChildren;
    }
}