Acme\AppBundle\Controller\JediController

Complexity

Total Complexity

20

Size/Duplication

Total Lines	273
Duplicated Lines	7.33 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	createAction()	0	19	2
A	createCreateForm()	0	11	1
A	newAction()	0	10	1
A	showAction()	0	17	2
A	editAction()	0	19	2
A	createEditForm()	0	11	1
B	updateAction()	0	26	3
A	indexAction()	10	10	1
A	deleteAction()	0	19	3
A	createDeleteForm()	0	10	1
A	indexFrontAction()	10	10	1
A	showFrontAction()	0	14	2

<?php

namespace Acme\AppBundle\Controller;

use Acme\AppBundle\Entity\Jedi;
use Acme\AppBundle\Form\Type\JediType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\HttpFoundation\Request;
use Victoire\Bundle\CoreBundle\Controller\BackendController;

/**
 * Jedi controller.
 * Generated with generate:crud command.
 *
 * @Route("/jedi")
 */
class JediController extends BackendController
{
    /**
     * Lists all Jedi entities.
     *
     * @Route("/", name="acme_app_jedi_index")
     * @Method("GET")
     * @Template()
     */

Missing @return tag in function comment

    public function indexAction()

This method seems to be duplicated in your project.

    {
        $em = $this->getDoctrine()->getManager();

        $entities = $em->getRepository('AcmeAppBundle:Jedi')->findAll();

        return [
            'entities' => $entities,
        ];
    }

    /**

Doc comment for parameter "$request" missing

     * Creates a new Jedi entity.
     *
     * @Route("/", name="acme_app_jedi_create")
     * @Method("POST")
     * @Template("AcmeAppBundle:Jedi:new.html.twig")
     */

Missing @return tag in function comment

    public function createAction(Request $request)
    {
        $entity = new Jedi();
        $form = $this->createCreateForm($entity);
        $form->handleRequest($request);

        if ($form->isValid()) {
            $em = $this->getDoctrine()->getManager();
            $em->persist($entity);
            $em->flush();

            return $this->redirect($this->generateUrl('acme_app_jedi_index'));
        }

        return [
            'entity' => $entity,
            'form'   => $form->createView(),
        ];
    }

    /**
     * Creates a form to create a Jedi entity.
     *
     * @param Jedi $entity The entity
     *
     * @return \Symfony\Component\Form\Form The form
     */
    private function createCreateForm(Jedi $entity)
    {
        $form = $this->createForm(JediType::class, $entity, [
            'action' => $this->generateUrl('acme_app_jedi_create'),
            'method' => 'POST',
        ]);

        $form->add('submit', 'submit', ['label' => 'acme.app.jedi.form.button.create']);

        return $form;
    }

    /**
     * Displays a form to create a new Jedi entity.
     *
     * @Route("/new", name="acme_app_jedi_new")
     * @Method("GET")
     * @Template()
     */

Missing @return tag in function comment

    public function newAction()

Declare public methods first,then protected ones and finally private ones

    {
        $entity = new Jedi();
        $form = $this->createCreateForm($entity);

        return [
            'entity' => $entity,
            'form'   => $form->createView(),
        ];
    }

    /**

Doc comment for parameter "$id" missing

     * Finds and displays a Jedi entity.
     *
     * @Route("/{id}", name="acme_app_jedi_show")
     * @Method("GET")
     * @Template()
     */

Missing @return tag in function comment

    public function showAction($id)
    {
        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository('AcmeAppBundle:Jedi')->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Unable to find Jedi entity.');
        }

        $deleteForm = $this->createDeleteForm($id);

        return [
            'entity'      => $entity,
            'delete_form' => $deleteForm->createView(),
        ];
    }

    /**

Doc comment for parameter "$id" missing

     * Displays a form to edit an existing Jedi entity.
     *
     * @Route("/{id}/edit", name="acme_app_jedi_edit")
     * @Method("GET")
     * @Template()
     */

Missing @return tag in function comment

    public function editAction($id)
    {
        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository('AcmeAppBundle:Jedi')->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Unable to find Jedi entity.');
        }

        $editForm = $this->createEditForm($entity);
        $deleteForm = $this->createDeleteForm($id);

        return [
            'entity'      => $entity,
            'edit_form'   => $editForm->createView(),
            'delete_form' => $deleteForm->createView(),
        ];
    }

    /**
     * Creates a form to edit a Jedi entity.
     *
     * @param Jedi $entity The entity
     *
     * @return \Symfony\Component\Form\Form The form
     */
    private function createEditForm(Jedi $entity)
    {
        $form = $this->createForm(JediType::class, $entity, [
            'action' => $this->generateUrl('acme_app_jedi_update', ['id' => $entity->getId()]),
            'method' => 'PUT',
        ]);

        $form->add('submit', 'submit', ['label' => 'acme.app.jedi.form.button.update']);

        return $form;
    }

    /**

Doc comment for parameter "$request" missing

Doc comment for parameter "$id" missing

     * Edits an existing Jedi entity.
     *
     * @Route("/{id}", name="acme_app_jedi_update")
     * @Method("PUT")
     * @Template("AcmeAppBundle:Jedi:edit.html.twig")
     */

Missing @return tag in function comment

    public function updateAction(Request $request, $id)

Declare public methods first,then protected ones and finally private ones

    {
        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository('AcmeAppBundle:Jedi')->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Unable to find Jedi entity.');
        }

        $deleteForm = $this->createDeleteForm($id);
        $editForm = $this->createEditForm($entity);
        $editForm->handleRequest($request);

        if ($editForm->isValid()) {
            $em->flush();

            return $this->redirect($this->generateUrl('acme_app_jedi_index'));
        }

        return [
            'entity'      => $entity,
            'edit_form'   => $editForm->createView(),
            'delete_form' => $deleteForm->createView(),
        ];
    }

    /**

Doc comment for parameter "$request" missing

Doc comment for parameter "$id" missing

     * Deletes a Jedi entity.
     *
     * @Route("/{id}", name="acme_app_jedi_delete")
     * @Method("DELETE")
     */

Missing @return tag in function comment

    public function deleteAction(Request $request, $id)
    {
        $form = $this->createDeleteForm($id);
        $form->handleRequest($request);

        if ($form->isValid()) {
            $em = $this->getDoctrine()->getManager();
            $entity = $em->getRepository('AcmeAppBundle:Jedi')->find($id);

            if (!$entity) {
                throw $this->createNotFoundException('Unable to find Jedi entity.');
            }

            $em->remove($entity);
            $em->flush();
        }

        return $this->redirect($this->generateUrl('acme_app_jedi_index'));
    }

    /**
     * Creates a form to delete a Jedi entity by id.
     *
     * @param mixed $id The entity id
     *
     * @return \Symfony\Component\Form\Form The form
     */
    private function createDeleteForm($id)
    {
        return $this->createFormBuilder(null, [

It seems like you code against a specific sub-type and not the parent class Symfony\Component\Form\FormConfigBuilder as the method add() does only exist in the following sub-classes of Symfony\Component\Form\FormConfigBuilder: Symfony\Component\Form\FormBuilder. Maybe you want to instanceof check for one of these explicitly?

                'translation_domain' => 'victoire',
            ])

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

            ->setAction($this->generateUrl('acme_app_jedi_delete', ['id' => $id]))
            ->setMethod('DELETE')
            ->add('submit', 'submit', ['label' => 'acme.app.jedi.form.button.delete'])
            ->getForm();
    }

    /**
     * Lists all Jedi entities for front display.
     *
     * @Route("/front/index", name="acme_app_jedi_front_index")
     * @Method("GET")
     * @Template()
     */

Missing @return tag in function comment

    public function indexFrontAction()

This method seems to be duplicated in your project.

Declare public methods first,then protected ones and finally private ones

    {
        $em = $this->getDoctrine()->getManager();

        $entities = $em->getRepository('AcmeAppBundle:Jedi')->findAll();

        return [
            'entities' => $entities,
        ];
    }

    /**

Doc comment for parameter "$id" missing

     * Finds and displays a Jedi entity for front display.
     *
     * @Route("/front/show/{id}", name="acme_app_jedi_front_show")
     * @Method("GET")
     * @Template()
     */

Missing @return tag in function comment

    public function showFrontAction($id)
    {
        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository('AcmeAppBundle:Jedi')->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Unable to find Jedi entity.');
        }

        return [
            'entity' => $entity,
        ];
    }
}