WidgetMapManager - Code Metrics - Inspection of "[BC Break] widget personnalization" - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#375)

by Paul

created 2016-04-04 11:29 UTC

WidgetMapManager A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	274
Duplicated Lines	2.19 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	9
Bugs	3	Features	1

Metric	Value
wmc	34
c	9
b	3
f	1
lcom	1
cbo	7
dl	6
loc	274
rs	9.2

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	insert()	0	28	3
B	delete()	0	32	4
A	overwrite()	0	14	1
B	moveChildren()	0	18	7
A	cloneWidgetMap()	0	14	1
C	moveWidgetMap()	0	24	7
A	getChildrenByView()	0	21	3
C	move()	6	35	7

How to fix Duplicated Code

<?php

namespace Victoire\Bundle\WidgetMapBundle\Manager;

use Doctrine\Orm\EntityManager;
use Victoire\Bundle\CoreBundle\Entity\View;
use Victoire\Bundle\WidgetBundle\Entity\Widget;
use Victoire\Bundle\WidgetMapBundle\Builder\WidgetMapBuilder;
use Victoire\Bundle\WidgetMapBundle\Entity\WidgetMap;
use Victoire\Bundle\WidgetMapBundle\Helper\WidgetMapHelper;

class WidgetMapManager
{
    private $em;
    private $builder;

    public function __construct(EntityManager $em, WidgetMapBuilder $builder)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->em = $em;
        $this->builder = $builder;
    }

    /**
     * Insert a WidgetMap in a view at given position.
     *
     * @param string $slotId
     */
    public function insert(Widget $widget, View $view, $slotId, $position, $widgetReference)
    {
        $quantum = $this->em->getRepository('VictoireWidgetMapBundle:WidgetMap')->findOneBy([
           'view' => $view,
           'slot' => $slotId,
           'position' => $position,
           'parent' => $widgetReference,
        ]);
        if ($quantum) {
            $widget->setWidgetMap($quantum);
            $view->addWidgetMap($quantum);
        } else {

            $parent = null;
            if ($widgetReference) {
                $parent = $this->em->getRepository('VictoireWidgetMapBundle:WidgetMap')->find($widgetReference);
            }
            //create the new widget map
            $widgetMapEntry = new WidgetMap();
            $widgetMapEntry->setAction(WidgetMap::ACTION_CREATE);
            $widgetMapEntry->setSlot($slotId);
            $widgetMapEntry->setPosition($position);
            $widgetMapEntry->setParent($parent);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $widget->setWidgetMap($widgetMapEntry);

            $view->addWidgetMap($widgetMapEntry);
        }
    }

    /**
     * moves a widget in a view.
     *
     * @param View  $view
     * @param array $sortedWidget
     *
     * @return void
     */
    public function move(View $view, $sortedWidget)
    {
        /** @var WidgetMap $parentWidgetMap */
        $parentWidgetMap = $this->em->getRepository('VictoireWidgetMapBundle:WidgetMap')->find((int) $sortedWidget['parentWidgetMap']);
        $position = $sortedWidget['position'];
        $slot = $sortedWidget['slot'];
        /** @var WidgetMap $widgetMap */
        $widgetMap = $this->em->getRepository('VictoireWidgetMapBundle:WidgetMap')->find((int) $sortedWidget['widgetMap']);

        $originalParent = $widgetMap->getParent();
        $originalPosition = $widgetMap->getPosition();

        $children = $widgetMap->getChildren($view);
        $beforeChild = !empty($children[WidgetMap::POSITION_BEFORE]) ? $children[WidgetMap::POSITION_BEFORE] : null;
        $afterChild = !empty($children[WidgetMap::POSITION_AFTER]) ? $children[WidgetMap::POSITION_AFTER] : null;

        $parentWidgetMapChildren = $this->getChildrenByView($parentWidgetMap);

        $widgetMap = $this->moveWidgetMap($view, $widgetMap, $parentWidgetMap, $position, $slot);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        // If the moved widgetMap has someone at both his before and after, arbitrary move UP the before side
        // and find the first place after the before widgetMap hierarchy to place the after widgetMap.
        $this->moveChildren($view, $beforeChild, $afterChild, $originalParent, $originalPosition);

        foreach ($parentWidgetMapChildren['views'] as $_view) {
            if ($_view->getId() !== $view->getId()) {
                if (isset($parentWidgetMapChildren['before'][$_view->getId()])) {

                    $parentWidgetMapChildren['before'][$_view->getId()]->setParent($widgetMap);
                }
                if (isset($parentWidgetMapChildren['after'][$_view->getId()])) {

                    $parentWidgetMapChildren['after'][$_view->getId()]->setParent($widgetMap);
                }
            }
        }
    }

    /**
     * Delete the widget from the view.
     *
     * @param View   $view
     * @param Widget $widget
     *
     * @throws \Exception Widget map does not exists
     */
    public function delete(View $view, Widget $widget)
    {
        $this->builder->build($view);

        $widgetMap = WidgetMapHelper::getWidgetMapByWidgetAndView($widget, $view);
        $slot = $widgetMap->getSlot();

        $originalParent = $widgetMap->getParent();
        $originalPosition = $widgetMap->getPosition();

        $children = $widgetMap->getChildren($view);
        $beforeChild = !empty($children[WidgetMap::POSITION_BEFORE]) ? $children[WidgetMap::POSITION_BEFORE] : null;
        $afterChild = !empty($children[WidgetMap::POSITION_AFTER]) ? $children[WidgetMap::POSITION_AFTER] : null;

        //we remove the widget from the current view
        if ($widgetMap->getView() === $view) {
            //remove the widget map from the slot
            $view->removeWidgetMap($widgetMap);
        } else {
            //the widget is owned by another view (a parent)
            //so we add a new widget map that indicates we delete this widget
            $replaceWidgetMap = new WidgetMap();
            $replaceWidgetMap->setAction(WidgetMap::ACTION_DELETE);
            $replaceWidgetMap->setWidget($widget);

            $replaceWidgetMap->setSlot($slot);
            $replaceWidgetMap->setReplaced($widgetMap);

            $view->addWidgetMap($replaceWidgetMap);
        }

        $this->moveChildren($view, $beforeChild, $afterChild, $originalParent, $originalPosition);
    }

    /**
     * the widget is owned by another view (a parent)
     * so we add a new widget map that indicates we delete this widget.
     *
     * @param View      $view
     * @param WidgetMap $originalWidgetMap
     * @param Widget    $widgetCopy
     *
     * @throws \Exception
     */
    public function overwrite(View $view, WidgetMap $originalWidgetMap, Widget $widgetCopy)
    {
        $widgetMap = new WidgetMap();
        $widgetMap->setAction(WidgetMap::ACTION_OVERWRITE);
        $widgetMap->setReplaced($originalWidgetMap);
        $widgetMap->setWidget($widgetCopy);

        $widgetMap->setView($view);
        $widgetMap->setSlot($originalWidgetMap->getSlot());
        $widgetMap->setPosition($originalWidgetMap->getPosition());
        $widgetMap->setAsynchronous($widgetCopy->isAsynchronous());
        $widgetMap->setParent($originalWidgetMap->getParent());

        $view->addWidgetMap($widgetMap);
    }

    /**
     * If the moved widgetMap has someone at both his before and after, arbitrary move UP the before side
     * and find the first place after the before widgetMap hierarchy to place the after widgetMap.
     *
     * @param View $view
     * @param $beforeChild
     * @param $afterChild
     * @param $originalParent
     * @param $originalPosition
     */
    public function moveChildren(View $view, $beforeChild, $afterChild, $originalParent, $originalPosition)
    {
        if ($beforeChild && $afterChild) {
            $this->moveWidgetMap($view, $beforeChild, $originalParent, $originalPosition);

            $child = $beforeChild;
            while ($child->getChild(WidgetMap::POSITION_AFTER)) {
                $child = $child->getChild(WidgetMap::POSITION_AFTER);
            }
            if ($afterChild->getId() !== $child->getId()) {
                $this->moveWidgetMap($view, $afterChild, $child);
            }
        } elseif ($beforeChild) {
            $this->moveWidgetMap($view, $beforeChild, $originalParent, $originalPosition);
        } elseif ($afterChild) {
            $this->moveWidgetMap($view, $afterChild, $originalParent, $originalPosition);
        }
    }

    /**
     * Create a copy of a WidgetMap in "overwrite" mode and insert it in the given view.
     *
     * @param WidgetMap $widgetMap
     * @param View      $view
     *
     * @throws \Exception
     *
     * @return WidgetMap
     */
    protected function cloneWidgetMap(WidgetMap $widgetMap, View $view)
    {
        $originalWidgetMap = $widgetMap;
        $widgetMap = clone $widgetMap;
        $widgetMap->setId(null);
        $widgetMap->setAction(WidgetMap::ACTION_OVERWRITE);
        $widgetMap->setReplaced($originalWidgetMap);
        $originalWidgetMap->addSubstitute($widgetMap);
        $widgetMap->setView($view);
        $view->addWidgetMap($widgetMap);
        $this->em->persist($widgetMap);

        return $widgetMap;
    }

    /**
     * Move given WidgetMap as a child of given parent at given position and slot.
     *
     * @param View      $view
     * @param WidgetMap $widgetMap
     * @param bool      $parent
     * @param bool      $position
     * @param bool      $slot
     *
     * @return WidgetMap
     */
    protected function moveWidgetMap(View $view, WidgetMap $widgetMap, $parent = false, $position = false, $slot = false)
    {
        if ($widgetMap->getView() !== $view) {
            $widgetMap = $this->cloneWidgetMap($widgetMap, $view);
        }

        if ($parent !== false) {
            if ($oldParent = $widgetMap->getParent()) {
                $oldParent->removeChild($widgetMap);
            }
            $widgetMap->setParent($parent);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            if ($parent) {
                $parent->addChild($widgetMap);

            }
        }
        if ($position !== false) {
            $widgetMap->setPosition($position);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        if ($slot !== false) {
            $widgetMap->setSlot($slot);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $widgetMap;
    }

    /**
     * Find return all the given WidgetMap children for each view where it's related.
     *
     * @param WidgetMap $widgetMap
     *
     * @return mixed
     */
    protected function getChildrenByView(WidgetMap $widgetMap)
    {
        $beforeChilds = $widgetMap->getChilds(WidgetMap::POSITION_BEFORE);
        $afterChilds = $widgetMap->getChilds(WidgetMap::POSITION_AFTER);

        $childrenByView['views'] = [];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $childrenByView['before'] = [];
        $childrenByView['after'] = [];
        foreach ($beforeChilds as $beforeChild) {
            $view = $beforeChild->getView();
            $childrenByView['views'][] = $view;
            $childrenByView['before'][$view->getId()] = $beforeChild;
        }
        foreach ($afterChilds as $afterChild) {
            $view = $afterChild->getView();
            $childrenByView['views'][] = $view;
            $childrenByView['after'][$view->getId()] = $afterChild;
        }

        return $childrenByView;
    }
}


1		<?php
2
3		namespace Victoire\Bundle\WidgetMapBundle\Manager;
4
5		use Doctrine\Orm\EntityManager;
6		use Victoire\Bundle\CoreBundle\Entity\View;
7		use Victoire\Bundle\WidgetBundle\Entity\Widget;
8		use Victoire\Bundle\WidgetMapBundle\Builder\WidgetMapBuilder;
9		use Victoire\Bundle\WidgetMapBundle\Entity\WidgetMap;
10		use Victoire\Bundle\WidgetMapBundle\Helper\WidgetMapHelper;
11
12		class WidgetMapManager
13		{
14		private $em;
15		private $builder;
16
17		public function __construct(EntityManager $em, WidgetMapBuilder $builder)
		0 ignored issues – show Bug introduced 2016-02-01 08:33 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$em`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
18		{
19		$this->em = $em;
20		$this->builder = $builder;
21		}
22
23		/**
24		* Insert a WidgetMap in a view at given position.
25		*
26		* @param string $slotId
27		*/
28		public function insert(Widget $widget, View $view, $slotId, $position, $widgetReference)
29		{
30		$quantum = $this->em->getRepository('VictoireWidgetMapBundle:WidgetMap')->findOneBy([
31		'view' => $view,
32		'slot' => $slotId,
33		'position' => $position,
34		'parent' => $widgetReference,
35		]);
36		if ($quantum) {
37		$widget->setWidgetMap($quantum);
38		$view->addWidgetMap($quantum);
39		} else {
40
41		$parent = null;
42		if ($widgetReference) {
43		$parent = $this->em->getRepository('VictoireWidgetMapBundle:WidgetMap')->find($widgetReference);
44		}
45		//create the new widget map
46		$widgetMapEntry = new WidgetMap();
47		$widgetMapEntry->setAction(WidgetMap::ACTION_CREATE);
48		$widgetMapEntry->setSlot($slotId);
49		$widgetMapEntry->setPosition($position);
50		$widgetMapEntry->setParent($parent);
		0 ignored issues – show Bug introduced 2016-02-08 10:21 UTC by Report Bug Copy Issue Report It seems like `$parent` defined by `$this->em->getRepository...>find($widgetReference)` on line `43` can also be of type `object`; however, `Victoire\Bundle\WidgetMa...\WidgetMap::setParent()` does only seem to accept `null\|object<Victoire\Bun...undle\Entity\WidgetMap>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
51		$widget->setWidgetMap($widgetMapEntry);
52
53		$view->addWidgetMap($widgetMapEntry);
54		}
55		}
56
57		/**
58		* moves a widget in a view.
59		*
60		* @param View $view
61		* @param array $sortedWidget
62		*
63		* @return void
64		*/
65		public function move(View $view, $sortedWidget)
66		{
67		/** @var WidgetMap $parentWidgetMap */
68		$parentWidgetMap = $this->em->getRepository('VictoireWidgetMapBundle:WidgetMap')->find((int) $sortedWidget['parentWidgetMap']);
69		$position = $sortedWidget['position'];
70		$slot = $sortedWidget['slot'];
71		/** @var WidgetMap $widgetMap */
72		$widgetMap = $this->em->getRepository('VictoireWidgetMapBundle:WidgetMap')->find((int) $sortedWidget['widgetMap']);
73
74		$originalParent = $widgetMap->getParent();
75		$originalPosition = $widgetMap->getPosition();
76
77		$children = $widgetMap->getChildren($view);
78		$beforeChild = !empty($children[WidgetMap::POSITION_BEFORE]) ? $children[WidgetMap::POSITION_BEFORE] : null;
79		$afterChild = !empty($children[WidgetMap::POSITION_AFTER]) ? $children[WidgetMap::POSITION_AFTER] : null;
80
81		$parentWidgetMapChildren = $this->getChildrenByView($parentWidgetMap);
82
83		$widgetMap = $this->moveWidgetMap($view, $widgetMap, $parentWidgetMap, $position, $slot);
		0 ignored issues – show Documentation introduced 2016-02-02 14:15 UTC by Report Bug Copy Issue Report `$parentWidgetMap` is of type `object<Victoire\Bundle\W...undle\Entity\WidgetMap>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
84
85		// If the moved widgetMap has someone at both his before and after, arbitrary move UP the before side
86		// and find the first place after the before widgetMap hierarchy to place the after widgetMap.
87		$this->moveChildren($view, $beforeChild, $afterChild, $originalParent, $originalPosition);
88
89		foreach ($parentWidgetMapChildren['views'] as $_view) {
90		if ($_view->getId() !== $view->getId()) {
91	View Code Duplication	if (isset($parentWidgetMapChildren['before'][$_view->getId()])) {
		0 ignored issues – show Duplication introduced 2016-02-02 14:15 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92		$parentWidgetMapChildren['before'][$_view->getId()]->setParent($widgetMap);
93		}
94	View Code Duplication	if (isset($parentWidgetMapChildren['after'][$_view->getId()])) {
		0 ignored issues – show Duplication introduced 2016-02-02 14:15 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
95		$parentWidgetMapChildren['after'][$_view->getId()]->setParent($widgetMap);
96		}
97		}
98		}
99		}
100
101		/**
102		* Delete the widget from the view.
103		*
104		* @param View $view
105		* @param Widget $widget
106		*
107		* @throws \Exception Widget map does not exists
108		*/
109		public function delete(View $view, Widget $widget)
110		{
111		$this->builder->build($view);
112
113		$widgetMap = WidgetMapHelper::getWidgetMapByWidgetAndView($widget, $view);
114		$slot = $widgetMap->getSlot();
115
116		$originalParent = $widgetMap->getParent();
117		$originalPosition = $widgetMap->getPosition();
118
119		$children = $widgetMap->getChildren($view);
120		$beforeChild = !empty($children[WidgetMap::POSITION_BEFORE]) ? $children[WidgetMap::POSITION_BEFORE] : null;
121		$afterChild = !empty($children[WidgetMap::POSITION_AFTER]) ? $children[WidgetMap::POSITION_AFTER] : null;
122
123		//we remove the widget from the current view
124		if ($widgetMap->getView() === $view) {
125		//remove the widget map from the slot
126		$view->removeWidgetMap($widgetMap);
127		} else {
128		//the widget is owned by another view (a parent)
129		//so we add a new widget map that indicates we delete this widget
130		$replaceWidgetMap = new WidgetMap();
131		$replaceWidgetMap->setAction(WidgetMap::ACTION_DELETE);
132		$replaceWidgetMap->setWidget($widget);
		0 ignored issues – show Deprecated Code introduced 2016-04-01 22:40 UTC by Report Bug Copy Issue Report The method `Victoire\Bundle\WidgetMa...\WidgetMap::setWidget()` has been deprecated. This method has been deprecated. Loading history...
133		$replaceWidgetMap->setSlot($slot);
134		$replaceWidgetMap->setReplaced($widgetMap);
135
136		$view->addWidgetMap($replaceWidgetMap);
137		}
138
139		$this->moveChildren($view, $beforeChild, $afterChild, $originalParent, $originalPosition);
140		}
141
142		/**
143		* the widget is owned by another view (a parent)
144		* so we add a new widget map that indicates we delete this widget.
145		*
146		* @param View $view
147		* @param WidgetMap $originalWidgetMap
148		* @param Widget $widgetCopy
149		*
150		* @throws \Exception
151		*/
152		public function overwrite(View $view, WidgetMap $originalWidgetMap, Widget $widgetCopy)
153		{
154		$widgetMap = new WidgetMap();
155		$widgetMap->setAction(WidgetMap::ACTION_OVERWRITE);
156		$widgetMap->setReplaced($originalWidgetMap);
157		$widgetMap->setWidget($widgetCopy);
		0 ignored issues – show Deprecated Code introduced 2016-04-01 22:40 UTC by Report Bug Copy Issue Report The method `Victoire\Bundle\WidgetMa...\WidgetMap::setWidget()` has been deprecated. This method has been deprecated. Loading history...
158		$widgetMap->setView($view);
159		$widgetMap->setSlot($originalWidgetMap->getSlot());
160		$widgetMap->setPosition($originalWidgetMap->getPosition());
161		$widgetMap->setAsynchronous($widgetCopy->isAsynchronous());
162		$widgetMap->setParent($originalWidgetMap->getParent());
163
164		$view->addWidgetMap($widgetMap);
165		}
166
167		/**
168		* If the moved widgetMap has someone at both his before and after, arbitrary move UP the before side
169		* and find the first place after the before widgetMap hierarchy to place the after widgetMap.
170		*
171		* @param View $view
172		* @param $beforeChild
173		* @param $afterChild
174		* @param $originalParent
175		* @param $originalPosition
176		*/
177		public function moveChildren(View $view, $beforeChild, $afterChild, $originalParent, $originalPosition)
178		{
179		if ($beforeChild && $afterChild) {
180		$this->moveWidgetMap($view, $beforeChild, $originalParent, $originalPosition);
181
182		$child = $beforeChild;
183		while ($child->getChild(WidgetMap::POSITION_AFTER)) {
184		$child = $child->getChild(WidgetMap::POSITION_AFTER);
185		}
186		if ($afterChild->getId() !== $child->getId()) {
187		$this->moveWidgetMap($view, $afterChild, $child);
188		}
189		} elseif ($beforeChild) {
190		$this->moveWidgetMap($view, $beforeChild, $originalParent, $originalPosition);
191		} elseif ($afterChild) {
192		$this->moveWidgetMap($view, $afterChild, $originalParent, $originalPosition);
193		}
194		}
195
196		/**
197		* Create a copy of a WidgetMap in "overwrite" mode and insert it in the given view.
198		*
199		* @param WidgetMap $widgetMap
200		* @param View $view
201		*
202		* @throws \Exception
203		*
204		* @return WidgetMap
205		*/
206		protected function cloneWidgetMap(WidgetMap $widgetMap, View $view)
207		{
208		$originalWidgetMap = $widgetMap;
209		$widgetMap = clone $widgetMap;
210		$widgetMap->setId(null);
211		$widgetMap->setAction(WidgetMap::ACTION_OVERWRITE);
212		$widgetMap->setReplaced($originalWidgetMap);
213		$originalWidgetMap->addSubstitute($widgetMap);
214		$widgetMap->setView($view);
215		$view->addWidgetMap($widgetMap);
216		$this->em->persist($widgetMap);
217
218		return $widgetMap;
219		}
220
221		/**
222		* Move given WidgetMap as a child of given parent at given position and slot.
223		*
224		* @param View $view
225		* @param WidgetMap $widgetMap
226		* @param bool $parent
227		* @param bool $position
228		* @param bool $slot
229		*
230		* @return WidgetMap
231		*/
232		protected function moveWidgetMap(View $view, WidgetMap $widgetMap, $parent = false, $position = false, $slot = false)
233		{
234		if ($widgetMap->getView() !== $view) {
235		$widgetMap = $this->cloneWidgetMap($widgetMap, $view);
236		}
237
238		if ($parent !== false) {
239		if ($oldParent = $widgetMap->getParent()) {
240		$oldParent->removeChild($widgetMap);
241		}
242		$widgetMap->setParent($parent);
		0 ignored issues – show Documentation introduced 2016-02-01 08:33 UTC by Report Bug Copy Issue Report `$parent` is of type `boolean`, but the function expects a `null\|object<Victoire\Bun...undle\Entity\WidgetMap>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
243		if ($parent) {
244		$parent->addChild($widgetMap);
		0 ignored issues – show Bug introduced 2016-02-01 08:33 UTC by Report Bug Copy Issue Report The method `addChild` cannot be called on `$parent` (of type `boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
245		}
246		}
247		if ($position !== false) {
248		$widgetMap->setPosition($position);
		0 ignored issues – show Documentation introduced 2016-02-01 08:33 UTC by Report Bug Copy Issue Report `$position` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
249		}
250		if ($slot !== false) {
251		$widgetMap->setSlot($slot);
		0 ignored issues – show Documentation introduced 2016-02-01 08:33 UTC by Report Bug Copy Issue Report `$slot` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
252		}
253
254		return $widgetMap;
255		}
256
257		/**
258		* Find return all the given WidgetMap children for each view where it's related.
259		*
260		* @param WidgetMap $widgetMap
261		*
262		* @return mixed
263		*/
264		protected function getChildrenByView(WidgetMap $widgetMap)
265		{
266		$beforeChilds = $widgetMap->getChilds(WidgetMap::POSITION_BEFORE);
267		$afterChilds = $widgetMap->getChilds(WidgetMap::POSITION_AFTER);
268
269		$childrenByView['views'] = [];
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 08:33 UTC by Report Bug Copy Issue Report `$childrenByView` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$childrenByView = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
270		$childrenByView['before'] = [];
271		$childrenByView['after'] = [];
272		foreach ($beforeChilds as $beforeChild) {
273		$view = $beforeChild->getView();
274		$childrenByView['views'][] = $view;
275		$childrenByView['before'][$view->getId()] = $beforeChild;
276		}
277		foreach ($afterChilds as $afterChild) {
278		$view = $afterChild->getView();
279		$childrenByView['views'][] = $view;
280		$childrenByView['after'][$view->getId()] = $afterChild;
281		}
282
283		return $childrenByView;
284		}
285		}
286

Victoire / victoire

Pull Request — master (#375)

WidgetMapManager A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like