BusinessEntityHelper::getEntityByPageAndBusinessIdentifier() - Code Metrics - Inspection of "Move business entity proxy resolution in WidgetRes..." - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0eab77...b2f729 )

by Paul

created 2017-03-21 08:46 UTC

BusinessEntityHelper::getEntityByPageAndBusinessIdentifier() B

↳ Parent: Project

Complexity

Conditions	4
Paths	4

Size

Total Lines	25
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	12
nc	4
nop	3

<?php

namespace Victoire\Bundle\BusinessEntityBundle\Helper;

use Doctrine\ORM\EntityRepository;
use Victoire\Bundle\BusinessEntityBundle\Entity\BusinessEntity;
use Victoire\Bundle\BusinessEntityBundle\Entity\BusinessEntityRepository;
use Victoire\Bundle\BusinessEntityBundle\Entity\BusinessProperty;
use Victoire\Bundle\BusinessEntityBundle\Reader\BusinessEntityCacheReader;
use Victoire\Bundle\CoreBundle\Cache\Builder\CacheBuilder;
use Victoire\Bundle\ORMBusinessEntityBundle\Entity\ORMBusinessEntityRepository;

/**
 * The BusinessEntityHelper.
 *
 * ref: victoire_core.helper.business_entity_helper
 */
class BusinessEntityHelper
{
    /**
     * @var BusinessEntityRepository
     */
    private $businessEntityRepository;
    /**
     * @var ORMBusinessEntityRepository
     */
    private $ormBusinessEntityRepository;
    /**
     * @var BusinessEntityCacheReader
     */
    private $cacheReader;

    /**
     * Constructor.
     *
     * @param EntityRepository|BusinessEntityRepository $businessEntityRepository
     * @param EntityRepository                          $ormBusinessEntityRepository
     * @param BusinessEntityCacheReader                 $cacheReader
     *
     * @internal param BusinessEntityCacheReader $reader
     * @internal param CacheBuilder $builder
     */
    public function __construct(EntityRepository $businessEntityRepository, EntityRepository $ormBusinessEntityRepository, BusinessEntityCacheReader $cacheReader)
    {
        $this->ormBusinessEntityRepository = $ormBusinessEntityRepository;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->businessEntityRepository = $businessEntityRepository;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->cacheReader = $cacheReader;
    }

    /**
     * Get a business entity.q.
     *
     * @param mixed $entity
     *
     * @return BusinessEntity
     */
    public function findByEntityInstance($entity)
    {
        $businessEntity = null;
        $class = new \ReflectionClass($entity);
        while (!$businessEntity && $class && $class->name !== null) {
            $businessEntity = $this->ormBusinessEntityRepository->findOneBy(['class' => $class->name]);
            $class = $class->getParentClass();
        }

        return $businessEntity;
    }

    /**
     * Get a business entity by classname.
     *
     * @param string $classname
     *
     * @return BusinessEntity
     */
    public function findByEntityClassname($classname)
    {
        return $this->ormBusinessEntityRepository->findOneBy(['class' => $classname]);
    }

    public function getAvailableForWidget($widgetName)
    {
        $classes = $this->businessEntityRepository->getByAvailableWidgets($widgetName);

        $receiverProperties = $this->cacheReader->getReceiverProperties($widgetName);
        foreach ($classes as $businessEntity) {
            $businessProperties = $businessEntity->getBusinessProperties();
            foreach ($receiverProperties as $receiverType => $receiverProperty) {
                $businessEntity->setDisable(true);
                if (count($businessProperties) > 0) {
                    /** @var BusinessProperty $businessProperty */
                    foreach ($businessProperties as $businessProperty) {
                        if (in_array($receiverType, $businessProperty->getTypes())) {
                            $businessEntity->setDisable(false);
                        }
                    }
                }
            }
        }

        return $classes;
    }
}


1			<?php
2
3			namespace Victoire\Bundle\BusinessEntityBundle\Helper;
4
5			use Doctrine\ORM\EntityRepository;
6			use Victoire\Bundle\BusinessEntityBundle\Entity\BusinessEntity;
7			use Victoire\Bundle\BusinessEntityBundle\Entity\BusinessEntityRepository;
8			use Victoire\Bundle\BusinessEntityBundle\Entity\BusinessProperty;
9			use Victoire\Bundle\BusinessEntityBundle\Reader\BusinessEntityCacheReader;
10			use Victoire\Bundle\CoreBundle\Cache\Builder\CacheBuilder;
11			use Victoire\Bundle\ORMBusinessEntityBundle\Entity\ORMBusinessEntityRepository;
12
13			/**
14			* The BusinessEntityHelper.
15			*
16			* ref: victoire_core.helper.business_entity_helper
17			*/
18			class BusinessEntityHelper
19			{
20			/**
21			* @var BusinessEntityRepository
22			*/
23			private $businessEntityRepository;
24			/**
25			* @var ORMBusinessEntityRepository
26			*/
27			private $ormBusinessEntityRepository;
28			/**
29			* @var BusinessEntityCacheReader
30			*/
31			private $cacheReader;
32
33			/**
34			* Constructor.
35			*
36			* @param EntityRepository\|BusinessEntityRepository $businessEntityRepository
37			* @param EntityRepository $ormBusinessEntityRepository
38			* @param BusinessEntityCacheReader $cacheReader
39			*
40			* @internal param BusinessEntityCacheReader $reader
41			* @internal param CacheBuilder $builder
42			*/
43			public function __construct(EntityRepository $businessEntityRepository, EntityRepository $ormBusinessEntityRepository, BusinessEntityCacheReader $cacheReader)
44			{
45			$this->ormBusinessEntityRepository = $ormBusinessEntityRepository;
			0 ignored issues – show Documentation Bug introduced 2017-03-08 18:26 UTC by Report Bug Copy Issue Report `$ormBusinessEntityRepository` is of type `object<Doctrine\ORM\EntityRepository>`, but the property `$ormBusinessEntityRepository` was declared to be of type `object<Victoire\Bundle\O...sinessEntityRepository>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
46			$this->businessEntityRepository = $businessEntityRepository;
			0 ignored issues – show Documentation Bug introduced 2017-03-08 18:26 UTC by Report Bug Copy Issue Report `$businessEntityRepository` is of type `object<Doctrine\ORM\EntityRepository>`, but the property `$businessEntityRepository` was declared to be of type `object<Victoire\Bundle\B...sinessEntityRepository>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
47			$this->cacheReader = $cacheReader;
48			}
49
50			/**
51			* Get a business entity.q.
52			*
53			* @param mixed $entity
54			*
55			* @return BusinessEntity
56			*/
57			public function findByEntityInstance($entity)
58			{
59			$businessEntity = null;
60			$class = new \ReflectionClass($entity);
61			while (!$businessEntity && $class && $class->name !== null) {
62			$businessEntity = $this->ormBusinessEntityRepository->findOneBy(['class' => $class->name]);
63			$class = $class->getParentClass();
64			}
65
66			return $businessEntity;
67			}
68
69			/**
70			* Get a business entity by classname.
71			*
72			* @param string $classname
73			*
74			* @return BusinessEntity
75			*/
76			public function findByEntityClassname($classname)
77			{
78			return $this->ormBusinessEntityRepository->findOneBy(['class' => $classname]);
79			}
80
81			public function getAvailableForWidget($widgetName)
82			{
83			$classes = $this->businessEntityRepository->getByAvailableWidgets($widgetName);
84
85			$receiverProperties = $this->cacheReader->getReceiverProperties($widgetName);
86			foreach ($classes as $businessEntity) {
87			$businessProperties = $businessEntity->getBusinessProperties();
88			foreach ($receiverProperties as $receiverType => $receiverProperty) {
89			$businessEntity->setDisable(true);
90			if (count($businessProperties) > 0) {
91			/** @var BusinessProperty $businessProperty */
92			foreach ($businessProperties as $businessProperty) {
93			if (in_array($receiverType, $businessProperty->getTypes())) {
94			$businessEntity->setDisable(false);
95			}
96			}
97			}
98			}
99			}
100
101			return $classes;
102			}
103			}
104

Victoire / victoire

Push — master ( 0eab77...b2f729 )

BusinessEntityHelper::getEntityByPageAndBusinessIdentifier() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like