Victoire\Bundle\CoreBundle\Form\AdditionnalPropertiesType

Complexity

Total Complexity

9

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
C	buildForm()	0	41	8
A	configureOptions()	0	8	1

<?php

namespace Victoire\Bundle\CoreBundle\Form;

use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Victoire\Bundle\APIBusinessEntityBundle\Entity\APIBusinessEntity;

/**
 * Create an entity proxy for the widget.*.
 */
class AdditionnalPropertiesType extends AbstractType
{
    /**
     * define form fields.
     *
     * @param FormBuilderInterface $builder
     * @param array                $options
     */
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $matches = [];
        /** @var APIBusinessEntity $businessEntity */
        $businessEntity = $options['businessEntity'];
        $getMethod = $businessEntity->getGetMethod();
        preg_match_all('/{{([a-zA-Z]+)}}/', $getMethod, $matches);
        $identifiers = array_map(function ($property) {
            return $property->getName();
        },
            $businessEntity->getBusinessIdentifiers()->toArray()
        );
        foreach ($matches[1] as $match) {
            if (!in_array($match, $identifiers)) {
                if ($property = $businessEntity->getBusinessPropertyByName($match)) {

Are you sure the assignment to $property is correct as $businessEntity->getBusinessPropertyByName($match) (which targets Victoire\Bundle\BusinessEntityBundle\Entity\BusinessEntity::getBusinessPropertyByName()) seems to always return null.

                    if (!$property->getChoices() && !$property->getListMethod()) {
                        $builder->add(
                            $match,
                            TextType::class,
                            [
                                'label'    => false,
                                'required' => false,
                            ]
                        );
                    } elseif ($property->getListMethod()) {

This elseif statement is empty, and could be removed.

                        //TODO
                    } elseif ($choices = $property->getChoices()) {
                        $builder->add(
                            $match,
                            ChoiceType::class,
                            [
                                'choices'  => $choices,
                                'label'    => false,
                                'required' => false,
                            ]
                        );
                    }
                }
            }
        }
    }

    /**
     * bind to Menu entity.
     *
     * @param OptionsResolver $resolver
     */
    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver->setDefaults(
            [
                'businessEntity' => null,
            ]
        );
    }
}