ViewReferenceXmlCacheManager::generateXml() - Code Metrics - Inspection of "Manage views references tree" - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#290)

by Leny

created 2015-12-01 09:35 UTC

ViewReferenceXmlCacheManager::generateXml() B

↳ Parent: ViewReferenceXmlCacheManager

Complexity

Conditions	5
Paths	10

Size

Total Lines	30
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	7
Bugs	1	Features	2

Metric	Value
c	7
b	1
f	2
dl	0
loc	30
rs	8.439
cc	5
eloc	17
nc	10
nop	3

<?php

namespace Victoire\Bundle\ViewReferenceBundle\Cache\Xml;

use Victoire\Bundle\CoreBundle\Entity\WebViewInterface;
use Victoire\Bundle\ViewReferenceBundle\Builder\Chain\ViewReferenceTransformerChain;
use Victoire\Bundle\ViewReferenceBundle\ViewReference\ViewReference;

class ViewReferenceXmlCacheManager
{
    protected $driver;

    /**
     * @param ViewReferenceXmlCacheDriver $driver
     */
    public function __construct(ViewReferenceXmlCacheDriver $driver, ViewReferenceTransformerChain $viewReferenceTransformerChain)
    {
        $this->driver = $driver;
        $this->viewReferenceTransformerChain = $viewReferenceTransformerChain;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Write given views references in a xml file.
     *
     * @param array $nodes
     * @param null  $rootNode
     *
     * @return \SimpleXMLElement
     */
    public function generateXml(array $nodes, $rootNode = null, $url = '')
    {
        if (is_null($rootNode)) {
            $rootNode = new \SimpleXMLElement(ViewReferenceXmlCacheDriver::$baseRootNode);
        }
        foreach ($nodes as $node) {
            $itemNode = $rootNode->addChild('viewReference');

            /** @var WebViewInterface $view */
            $view = $node['view'];
            $viewReference = $view->getViewReference();
            $arrayTransformer = $this->viewReferenceTransformerChain->getViewReferenceTransformer(
                $viewReference->getViewNamespace(), 'array'
            );
            foreach ($arrayTransformer->reverseTransform($viewReference) as $key => $value) {
                $itemNode->addAttribute($key, $value);
            }

            $_url = ltrim($url.'/'.$viewReference->getSlug(), '/');
            $itemNode->attributes()->url = $_url;


            //Build url thanks to hierarchy
            if (!empty($node['children'])) {
                $childrenNode = $itemNode->addChild('children');
                $this->generateXml($node['children'], $childrenNode, $_url);
            }
        }

        return $rootNode;
    }

    #have a look to git history to find "add" and "remove" methods
}


1			<?php
2
3			namespace Victoire\Bundle\ViewReferenceBundle\Cache\Xml;
4
5			use Victoire\Bundle\CoreBundle\Entity\WebViewInterface;
6			use Victoire\Bundle\ViewReferenceBundle\Builder\Chain\ViewReferenceTransformerChain;
7			use Victoire\Bundle\ViewReferenceBundle\ViewReference\ViewReference;
8
9			class ViewReferenceXmlCacheManager
10			{
11			protected $driver;
12
13			/**
14			* @param ViewReferenceXmlCacheDriver $driver
15			*/
16			public function __construct(ViewReferenceXmlCacheDriver $driver, ViewReferenceTransformerChain $viewReferenceTransformerChain)
17			{
18			$this->driver = $driver;
19			$this->viewReferenceTransformerChain = $viewReferenceTransformerChain;
			0 ignored issues – show Bug introduced 2015-12-01 09:43 UTC by Report Bug Copy Issue Report The property `viewReferenceTransformerChain` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			}
21
22			/**
23			* Write given views references in a xml file.
24			*
25			* @param array $nodes
26			* @param null $rootNode
27			*
28			* @return \SimpleXMLElement
29			*/
30			public function generateXml(array $nodes, $rootNode = null, $url = '')
31			{
32			if (is_null($rootNode)) {
33			$rootNode = new \SimpleXMLElement(ViewReferenceXmlCacheDriver::$baseRootNode);
34			}
35			foreach ($nodes as $node) {
36			$itemNode = $rootNode->addChild('viewReference');
37
38			/** @var WebViewInterface $view */
39			$view = $node['view'];
40			$viewReference = $view->getViewReference();
41			$arrayTransformer = $this->viewReferenceTransformerChain->getViewReferenceTransformer(
42			$viewReference->getViewNamespace(), 'array'
43			);
44			foreach ($arrayTransformer->reverseTransform($viewReference) as $key => $value) {
45			$itemNode->addAttribute($key, $value);
46			}
47
48			$_url = ltrim($url.'/'.$viewReference->getSlug(), '/');
49			$itemNode->attributes()->url = $_url;
			0 ignored issues – show Bug introduced 2015-12-01 09:43 UTC by Report Bug Copy Issue Report The property `url` does not seem to exist in `SimpleXMLElement`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
50
51			//Build url thanks to hierarchy
52			if (!empty($node['children'])) {
53			$childrenNode = $itemNode->addChild('children');
54			$this->generateXml($node['children'], $childrenNode, $_url);
55			}
56			}
57
58			return $rootNode;
59			}
60
61			#have a look to git history to find "add" and "remove" methods
62			}
63

Victoire / victoire

Pull Request — master (#290)

ViewReferenceXmlCacheManager::generateXml() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like