Victoire\Bundle\ViewReferenceBundle\Cache\ViewCacheWarmer

Complexity

Total Complexity

3

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	warmUp()	0	10	2

<?php

namespace Victoire\Bundle\ViewReferenceBundle\Cache;

use Doctrine\ORM\EntityManager;
use Victoire\Bundle\CoreBundle\Helper\ViewHelper;
use Victoire\Bundle\ViewReferenceBundle\Cache\Xml\ViewReferenceXmlCacheDriver;
use Victoire\Bundle\ViewReferenceBundle\Cache\Xml\ViewReferenceXmlCacheManager;

/**
 * Called (for example on kernel request) to create the viewsReference cache file
 * ref. victoire_view_reference.cache_warmer.
 */
class ViewCacheWarmer
{
    private $viewHelper;
    private $viewCacheDriver;
    private $viewCacheManager;

    /**
     * @param ViewHelper                   $viewHelper       @victoire_page.page_helper
     * @param ViewReferenceXmlCacheDriver  $viewCacheDriver  @victoire_view_reference.cache.driver
     * @param ViewReferenceXmlCacheManager $viewCacheManager @victoire_view_reference.cache.manager
     */
    public function __construct(
        ViewHelper $viewHelper,
        ViewReferenceXmlCacheDriver $viewCacheDriver,
        ViewReferenceXmlCacheManager $viewCacheManager,
        EntityManager $entityManager

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    ) {
        $this->viewHelper = $viewHelper;
        $this->viewCacheDriver = $viewCacheDriver;
        $this->viewCacheManager = $viewCacheManager;
        $this->entityManager = $entityManager;

The property entityManager does not exist. Did you maybe forget to declare it?

    }

    /**
     * Warm the view cache file (if needed or force mode).
     *
     * @param string $cacheDir Where does the viewsReferences file should take place
     */
    public function warmUp($cacheDir)

The parameter $cacheDir is not used and could be removed.

    {
        if (!$this->viewCacheDriver->fileExists()) {
            $this->viewCacheDriver->writeFile(
                $this->viewCacheManager->generateXml(
                    $this->viewHelper->buildViewsReferences()
                )
            );
        }
    }
}