StyleXSTrait - Code Metrics - Inspection of "move viewReference from array to object in Analyti..." - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#302)

by Leny

created 2015-12-10 14:56 UTC

StyleXSTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	357
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Metric	Value
wmc	26
lcom	0
cbo	0
dl	0
loc	357
rs	10

26 Methods

Rating	Name	Size	Complexity
A	getContainerMarginXS()	4	1
A	getContainerPaddingXS()	4	1
A	getContainerHeightXS()	4	1
A	getContainerWidthXS()	4	1
A	getTextAlignXS()	4	1
A	getContainerBackgroundXS()	4	1
A	getContainerBackgroundTypeXS()	4	1
A	getContainerBackgroundRepeatXS()	4	1
A	getContainerBackgroundPositionXS()	4	1
A	getContainerBackgroundSizeXS()	4	1
A	getContainerBackgroundImageXS()	4	1
A	getContainerBackgroundOverlayXS()	4	1
A	setContainerMarginXS()	6	1
A	setContainerPaddingXS()	6	1
A	setContainerHeightXS()	6	1
A	setContainerWidthXS()	6	1
A	setTextAlignXS()	6	1
A	setContainerBackgroundXS()	6	1
A	setContainerBackgroundTypeXS()	6	1
A	setContainerBackgroundRepeatXS()	6	1
A	setContainerBackgroundPositionXS()	6	1
A	setContainerBackgroundSizeXS()	6	1
A	getContainerBackgroundColorXS()	4	1
A	setContainerBackgroundColorXS()	6	1
A	setContainerBackgroundImageXS()	6	1
A	setContainerBackgroundOverlayXS()	6	1

<?php

namespace Victoire\Bundle\WidgetBundle\Entity\Traits\StyleTraits;

use Victoire\Bundle\MediaBundle\Entity\Media;

trait StyleXSTrait
{
    /**
     * @var string
     *
     * @ORM\Column(name="container_margin_xs", type="string", length=255, nullable=true)
     */
    protected $containerMarginXS;

    /**
     * @var string
     *
     * @ORM\Column(name="container_padding_xs", type="string", length=255, nullable=true)
     */
    protected $containerPaddingXS;

    /**
     * @var string
     *
     * @ORM\Column(name="container_width_xs", type="string", length=255, nullable=true)
     */
    protected $containerWidthXS;

    /**
     * @var string
     *
     * @ORM\Column(name="container_height_xs", type="string", length=255, nullable=true)
     */
    protected $containerHeightXS;

    /**
     * @var string
     *
     * @ORM\Column(name="text_align_xs", type="string", length=15, nullable=true)
     */
    protected $textAlignXS;

    /**
     * @var string
     *
     * @deprecated
     * @ORM\Column(name="container_background_xs", type="string", length=255, nullable=true)
     */
    protected $containerBackgroundXS;

    /**
     * @var string
     *
     * @ORM\Column(name="container_background_type_xs", type="string", length=255, nullable=true)
     */
    protected $containerBackgroundTypeXS;

    /**
     * @var string
     *
     * @ORM\Column(name="container_background_repeat_xs", type="string", length=255, nullable=true)
     */
    protected $containerBackgroundRepeatXS;

    /**
     * @var string
     *
     * @ORM\Column(name="container_background_position_xs", type="string", length=255, nullable=true)
     */
    protected $containerBackgroundPositionXS;

    /**
     * @var string
     *
     * @ORM\Column(name="container_background_size_xs", type="string", length=255, nullable=true)
     */
    protected $containerBackgroundSizeXS;

    /**
     * @var string
     *
     * @ORM\Column(name="container_background_color_xs", type="string", length=255, nullable=true)
     */
    protected $containerBackgroundColorXS;

    /**
     * @var string
     *
     * @ORM\ManyToOne(targetEntity="\Victoire\Bundle\MediaBundle\Entity\Media")
     * @ORM\JoinColumn(name="container_background_image_xs_id", referencedColumnName="id", onDelete="SET NULL", nullable=true)
     */
    protected $containerBackgroundImageXS;

    /**
     * @var string
     *
     * @ORM\Column(name="container_background_overlay_xs", type="string", length=255, nullable=true)
     */
    protected $containerBackgroundOverlayXS;

    /**
     * @return string
     */
    public function getContainerMarginXS()
    {
        return $this->containerMarginXS;
    }

    /**
     * @param string $containerMarginXS
     *
     * @return $this
     */
    public function setContainerMarginXS($containerMarginXS)
    {
        $this->containerMarginXS = $containerMarginXS;

        return $this;
    }

    /**
     * @return string
     */
    public function getContainerPaddingXS()
    {
        return $this->containerPaddingXS;
    }

    /**
     * @param string $containerPaddingXS
     *
     * @return $this
     */
    public function setContainerPaddingXS($containerPaddingXS)
    {
        $this->containerPaddingXS = $containerPaddingXS;

        return $this;
    }

    /**
     * @return string
     */
    public function getContainerHeightXS()
    {
        return $this->containerHeightXS;
    }

    /**
     * @param string $containerHeightXS
     *
     * @return $this
     */
    public function setContainerHeightXS($containerHeightXS)
    {
        $this->containerHeightXS = $containerHeightXS;

        return $this;
    }

    /**
     * @return string
     */
    public function getContainerWidthXS()
    {
        return $this->containerWidthXS;
    }

    /**
     * @param string $containerWidthXS
     *
     * @return $this
     */
    public function setContainerWidthXS($containerWidthXS)
    {
        $this->containerWidthXS = $containerWidthXS;

        return $this;
    }

    /**
     * @return string
     */
    public function getTextAlignXS()
    {
        return $this->textAlignXS;
    }

    /**
     * @param string $textAlignXS
     *
     * @return $this
     */
    public function setTextAlignXS($textAlignXS)
    {
        $this->textAlignXS = $textAlignXS;

        return $this;
    }

    /**
     * @return string
     */
    public function getContainerBackgroundXS()
    {
        return $this->containerBackgroundXS;

    }

    /**
     * @param string $containerBackgroundXS
     *
     * @return $this
     */
    public function setContainerBackgroundXS($containerBackgroundXS)
    {
        $this->containerBackgroundXS = $containerBackgroundXS;


        return $this;
    }

    /**
     * @return string
     */
    public function getContainerBackgroundTypeXS()
    {
        return $this->containerBackgroundTypeXS;
    }

    /**
     * @param string $containerBackgroundTypeXS
     *
     * @return $this
     */
    public function setContainerBackgroundTypeXS($containerBackgroundTypeXS)
    {
        $this->containerBackgroundTypeXS = $containerBackgroundTypeXS;

        return $this;
    }

    /**
     * @return string
     */
    public function getContainerBackgroundRepeatXS()
    {
        return $this->containerBackgroundRepeatXS;
    }

    /**
     * @param string $containerBackgroundRepeatXS
     *
     * @return $this
     */
    public function setContainerBackgroundRepeatXS($containerBackgroundRepeatXS)
    {
        $this->containerBackgroundRepeatXS = $containerBackgroundRepeatXS;

        return $this;
    }

    /**
     * @return string
     */
    public function getContainerBackgroundPositionXS()
    {
        return $this->containerBackgroundPositionXS;
    }

    /**
     * @param string $containerBackgroundPositionXS
     *
     * @return $this
     */
    public function setContainerBackgroundPositionXS($containerBackgroundPositionXS)
    {
        $this->containerBackgroundPositionXS = $containerBackgroundPositionXS;

        return $this;
    }

    /**
     * @return string
     */
    public function getContainerBackgroundSizeXS()
    {
        return $this->containerBackgroundSizeXS;
    }

    /**
     * @param string $containerBackgroundSizeXS
     *
     * @return $this
     */
    public function setContainerBackgroundSizeXS($containerBackgroundSizeXS)
    {
        $this->containerBackgroundSizeXS = $containerBackgroundSizeXS;

        return $this;
    }

    /**
     * @return string
     */
    public function getContainerBackgroundColorXS()
    {
        return $this->containerBackgroundColorXS;
    }

    /**
     * @param string $containerBackgroundColorXS
     *
     * @return $this
     */
    public function setContainerBackgroundColorXS($containerBackgroundColorXS)
    {
        $this->containerBackgroundColorXS = $containerBackgroundColorXS;

        return $this;
    }

    /**
     * @return string
     */
    public function getContainerBackgroundImageXS()
    {
        return $this->containerBackgroundImageXS;
    }

    /**
     * Set image.
     *
     * @param Media $image
     *
     * @return $this
     */
    public function setContainerBackgroundImageXS(Media $image = null)
    {
        $this->containerBackgroundImageXS = $image;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        return $this;
    }

    /**
     * @return string
     */
    public function getContainerBackgroundOverlayXS()
    {
        return $this->containerBackgroundOverlayXS;
    }

    /**
     * @param string $containerBackgroundOverlayXS
     *
     * @return $this
     */
    public function setContainerBackgroundOverlayXS($containerBackgroundOverlayXS)
    {
        $this->containerBackgroundOverlayXS = $containerBackgroundOverlayXS;

        return $this;
    }
}


1			<?php
2
3			namespace Victoire\Bundle\WidgetBundle\Entity\Traits\StyleTraits;
4
5			use Victoire\Bundle\MediaBundle\Entity\Media;
6
7			trait StyleXSTrait
8			{
9			/**
10			* @var string
11			*
12			* @ORM\Column(name="container_margin_xs", type="string", length=255, nullable=true)
13			*/
14			protected $containerMarginXS;
15
16			/**
17			* @var string
18			*
19			* @ORM\Column(name="container_padding_xs", type="string", length=255, nullable=true)
20			*/
21			protected $containerPaddingXS;
22
23			/**
24			* @var string
25			*
26			* @ORM\Column(name="container_width_xs", type="string", length=255, nullable=true)
27			*/
28			protected $containerWidthXS;
29
30			/**
31			* @var string
32			*
33			* @ORM\Column(name="container_height_xs", type="string", length=255, nullable=true)
34			*/
35			protected $containerHeightXS;
36
37			/**
38			* @var string
39			*
40			* @ORM\Column(name="text_align_xs", type="string", length=15, nullable=true)
41			*/
42			protected $textAlignXS;
43
44			/**
45			* @var string
46			*
47			* @deprecated
48			* @ORM\Column(name="container_background_xs", type="string", length=255, nullable=true)
49			*/
50			protected $containerBackgroundXS;
51
52			/**
53			* @var string
54			*
55			* @ORM\Column(name="container_background_type_xs", type="string", length=255, nullable=true)
56			*/
57			protected $containerBackgroundTypeXS;
58
59			/**
60			* @var string
61			*
62			* @ORM\Column(name="container_background_repeat_xs", type="string", length=255, nullable=true)
63			*/
64			protected $containerBackgroundRepeatXS;
65
66			/**
67			* @var string
68			*
69			* @ORM\Column(name="container_background_position_xs", type="string", length=255, nullable=true)
70			*/
71			protected $containerBackgroundPositionXS;
72
73			/**
74			* @var string
75			*
76			* @ORM\Column(name="container_background_size_xs", type="string", length=255, nullable=true)
77			*/
78			protected $containerBackgroundSizeXS;
79
80			/**
81			* @var string
82			*
83			* @ORM\Column(name="container_background_color_xs", type="string", length=255, nullable=true)
84			*/
85			protected $containerBackgroundColorXS;
86
87			/**
88			* @var string
89			*
90			* @ORM\ManyToOne(targetEntity="\Victoire\Bundle\MediaBundle\Entity\Media")
91			* @ORM\JoinColumn(name="container_background_image_xs_id", referencedColumnName="id", onDelete="SET NULL", nullable=true)
92			*/
93			protected $containerBackgroundImageXS;
94
95			/**
96			* @var string
97			*
98			* @ORM\Column(name="container_background_overlay_xs", type="string", length=255, nullable=true)
99			*/
100			protected $containerBackgroundOverlayXS;
101
102			/**
103			* @return string
104			*/
105			public function getContainerMarginXS()
106			{
107			return $this->containerMarginXS;
108			}
109
110			/**
111			* @param string $containerMarginXS
112			*
113			* @return $this
114			*/
115			public function setContainerMarginXS($containerMarginXS)
116			{
117			$this->containerMarginXS = $containerMarginXS;
118
119			return $this;
120			}
121
122			/**
123			* @return string
124			*/
125			public function getContainerPaddingXS()
126			{
127			return $this->containerPaddingXS;
128			}
129
130			/**
131			* @param string $containerPaddingXS
132			*
133			* @return $this
134			*/
135			public function setContainerPaddingXS($containerPaddingXS)
136			{
137			$this->containerPaddingXS = $containerPaddingXS;
138
139			return $this;
140			}
141
142			/**
143			* @return string
144			*/
145			public function getContainerHeightXS()
146			{
147			return $this->containerHeightXS;
148			}
149
150			/**
151			* @param string $containerHeightXS
152			*
153			* @return $this
154			*/
155			public function setContainerHeightXS($containerHeightXS)
156			{
157			$this->containerHeightXS = $containerHeightXS;
158
159			return $this;
160			}
161
162			/**
163			* @return string
164			*/
165			public function getContainerWidthXS()
166			{
167			return $this->containerWidthXS;
168			}
169
170			/**
171			* @param string $containerWidthXS
172			*
173			* @return $this
174			*/
175			public function setContainerWidthXS($containerWidthXS)
176			{
177			$this->containerWidthXS = $containerWidthXS;
178
179			return $this;
180			}
181
182			/**
183			* @return string
184			*/
185			public function getTextAlignXS()
186			{
187			return $this->textAlignXS;
188			}
189
190			/**
191			* @param string $textAlignXS
192			*
193			* @return $this
194			*/
195			public function setTextAlignXS($textAlignXS)
196			{
197			$this->textAlignXS = $textAlignXS;
198
199			return $this;
200			}
201
202			/**
203			* @return string
204			*/
205			public function getContainerBackgroundXS()
206			{
207			return $this->containerBackgroundXS;
			0 ignored issues – show Deprecated Code introduced 2015-11-24 15:51 UTC by Report Bug Copy Issue Report The property `Victoire\Bundle\WidgetBu...:$containerBackgroundXS` has been deprecated. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
208			}
209
210			/**
211			* @param string $containerBackgroundXS
212			*
213			* @return $this
214			*/
215			public function setContainerBackgroundXS($containerBackgroundXS)
216			{
217			$this->containerBackgroundXS = $containerBackgroundXS;
			0 ignored issues – show Deprecated Code introduced 2015-11-24 15:51 UTC by Report Bug Copy Issue Report The property `Victoire\Bundle\WidgetBu...:$containerBackgroundXS` has been deprecated. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
218
219			return $this;
220			}
221
222			/**
223			* @return string
224			*/
225			public function getContainerBackgroundTypeXS()
226			{
227			return $this->containerBackgroundTypeXS;
228			}
229
230			/**
231			* @param string $containerBackgroundTypeXS
232			*
233			* @return $this
234			*/
235			public function setContainerBackgroundTypeXS($containerBackgroundTypeXS)
236			{
237			$this->containerBackgroundTypeXS = $containerBackgroundTypeXS;
238
239			return $this;
240			}
241
242			/**
243			* @return string
244			*/
245			public function getContainerBackgroundRepeatXS()
246			{
247			return $this->containerBackgroundRepeatXS;
248			}
249
250			/**
251			* @param string $containerBackgroundRepeatXS
252			*
253			* @return $this
254			*/
255			public function setContainerBackgroundRepeatXS($containerBackgroundRepeatXS)
256			{
257			$this->containerBackgroundRepeatXS = $containerBackgroundRepeatXS;
258
259			return $this;
260			}
261
262			/**
263			* @return string
264			*/
265			public function getContainerBackgroundPositionXS()
266			{
267			return $this->containerBackgroundPositionXS;
268			}
269
270			/**
271			* @param string $containerBackgroundPositionXS
272			*
273			* @return $this
274			*/
275			public function setContainerBackgroundPositionXS($containerBackgroundPositionXS)
276			{
277			$this->containerBackgroundPositionXS = $containerBackgroundPositionXS;
278
279			return $this;
280			}
281
282			/**
283			* @return string
284			*/
285			public function getContainerBackgroundSizeXS()
286			{
287			return $this->containerBackgroundSizeXS;
288			}
289
290			/**
291			* @param string $containerBackgroundSizeXS
292			*
293			* @return $this
294			*/
295			public function setContainerBackgroundSizeXS($containerBackgroundSizeXS)
296			{
297			$this->containerBackgroundSizeXS = $containerBackgroundSizeXS;
298
299			return $this;
300			}
301
302			/**
303			* @return string
304			*/
305			public function getContainerBackgroundColorXS()
306			{
307			return $this->containerBackgroundColorXS;
308			}
309
310			/**
311			* @param string $containerBackgroundColorXS
312			*
313			* @return $this
314			*/
315			public function setContainerBackgroundColorXS($containerBackgroundColorXS)
316			{
317			$this->containerBackgroundColorXS = $containerBackgroundColorXS;
318
319			return $this;
320			}
321
322			/**
323			* @return string
324			*/
325			public function getContainerBackgroundImageXS()
326			{
327			return $this->containerBackgroundImageXS;
328			}
329
330			/**
331			* Set image.
332			*
333			* @param Media $image
334			*
335			* @return $this
336			*/
337			public function setContainerBackgroundImageXS(Media $image = null)
338			{
339			$this->containerBackgroundImageXS = $image;
			0 ignored issues – show Documentation Bug introduced 2015-11-24 15:51 UTC by Report Bug Copy Issue Report It seems like `$image` can also be of type `object<Victoire\Bundle\MediaBundle\Entity\Media>`. However, the property `$containerBackgroundImageXS` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
340
341			return $this;
342			}
343
344			/**
345			* @return string
346			*/
347			public function getContainerBackgroundOverlayXS()
348			{
349			return $this->containerBackgroundOverlayXS;
350			}
351
352			/**
353			* @param string $containerBackgroundOverlayXS
354			*
355			* @return $this
356			*/
357			public function setContainerBackgroundOverlayXS($containerBackgroundOverlayXS)
358			{
359			$this->containerBackgroundOverlayXS = $containerBackgroundOverlayXS;
360
361			return $this;
362			}
363			}
364

Victoire / victoire

Pull Request — master (#302)

StyleXSTrait A

Complexity

Size/Duplication

Coupling/Cohesion

26 Methods

Duplication Side-by-Side

Filter issues like