BasePage::getWebViewChildren() - Code Metrics - Inspection of "Feature/update master 2.3" - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#926)

by Paul

created 2017-05-22 10:20 UTC

BasePage::getWebViewChildren() B

↳ Parent: BasePage

Complexity

Conditions	7
Paths	6

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	18
rs	8.2222
c	1
b	0
f	0
cc	7
eloc	10
nc	6
nop	1

<?php

namespace Victoire\Bundle\PageBundle\Entity;

use Doctrine\ORM\Mapping as ORM;
use Victoire\Bundle\BusinessPageBundle\Entity\BusinessTemplate;
use Victoire\Bundle\CoreBundle\Entity\View;
use Victoire\Bundle\CoreBundle\Entity\WebViewInterface;

/**
 * Page.
 *
 * @ORM\Entity(repositoryClass="Victoire\Bundle\PageBundle\Repository\BasePageRepository")
 * @ORM\Table("vic_base_page")
 * @ORM\HasLifecycleCallbacks
 */
abstract class BasePage extends View implements WebViewInterface

{
    use \Victoire\Bundle\PageBundle\Entity\Traits\WebViewTrait;

    /**
     * Construct.
     **/
    public function __construct()
    {
        parent::__construct();
        $this->publishedAt = new \DateTime();
        $this->status = PageStatus::PUBLISHED;
        $this->homepage = false;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * Get WebView children.
     * Exclude unpublished or not published yet if asked.
     *
     * @param bool $excludeUnpublished
     *
     * @return string
     */
    public function getWebViewChildren($excludeUnpublished = false)
    {
        $webViewChildren = [];
        foreach ($this->children as $child) {
            if (!$child instanceof BusinessTemplate) {
                $notPublished = $child->getStatus() != PageStatus::PUBLISHED;
                $scheduledDateNotReached = $child->getStatus() == PageStatus::SCHEDULED && $child->getPublishedAt() > new \DateTime();

                if ($excludeUnpublished && ($notPublished || $scheduledDateNotReached)) {
                    continue;
                }

                $webViewChildren[] = $child;
            }
        }

        return $webViewChildren;
    }
}


1			<?php
2
3			namespace Victoire\Bundle\PageBundle\Entity;
4
5			use Doctrine\ORM\Mapping as ORM;
6			use Victoire\Bundle\BusinessPageBundle\Entity\BusinessTemplate;
7			use Victoire\Bundle\CoreBundle\Entity\View;
8			use Victoire\Bundle\CoreBundle\Entity\WebViewInterface;
9
10			/**
11			* Page.
12			*
13			* @ORM\Entity(repositoryClass="Victoire\Bundle\PageBundle\Repository\BasePageRepository")
14			* @ORM\Table("vic_base_page")
15			* @ORM\HasLifecycleCallbacks
16			*/
17			abstract class BasePage extends View implements WebViewInterface
			0 ignored issues – show introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Abstract class name is not prefixed with "Abstract" Loading history...
18			{
19			use \Victoire\Bundle\PageBundle\Entity\Traits\WebViewTrait;
20
21			/**
22			* Construct.
23			**/
24			public function __construct()
25			{
26			parent::__construct();
27			$this->publishedAt = new \DateTime();
28			$this->status = PageStatus::PUBLISHED;
29			$this->homepage = false;
			0 ignored issues – show Documentation Bug introduced 2015-11-24 15:51 UTC by Report Bug Copy Issue Report The property `$homepage` was declared of type `string`, but `false` is of type `false`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
30			}
31
32			/**
33			* Get WebView children.
34			* Exclude unpublished or not published yet if asked.
35			*
36			* @param bool $excludeUnpublished
37			*
38			* @return string
39			*/
40			public function getWebViewChildren($excludeUnpublished = false)
41			{
42			$webViewChildren = [];
43			foreach ($this->children as $child) {
44			if (!$child instanceof BusinessTemplate) {
45			$notPublished = $child->getStatus() != PageStatus::PUBLISHED;
46			$scheduledDateNotReached = $child->getStatus() == PageStatus::SCHEDULED && $child->getPublishedAt() > new \DateTime();
47
48			if ($excludeUnpublished && ($notPublished \|\| $scheduledDateNotReached)) {
49			continue;
50			}
51
52			$webViewChildren[] = $child;
53			}
54			}
55
56			return $webViewChildren;
57			}
58			}
59

Victoire / victoire

Pull Request — master (#926)

BasePage::getWebViewChildren() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like