Completed
Pull Request — master (#374)
by Leny
06:07
created
Bundle/ViewReferenceBundle/Builder/ViewReferenceBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
     /**
25 25
      * compute the viewReference relative to a View + entity.
26 26
      *
27
-     * @param WebViewInterface $view
27
+     * @param View $view
28 28
      *
29 29
      * @return ViewReference
30 30
      */
Please login to merge, or discard this patch.
Bundle/ViewReferenceBundle/Transformer/XmlToViewReferenceTransformer.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,6 @@
 block discarded – undo
19 19
      * SimpleXMLElement to ViewReference
20 20
      * {@inheritdoc}
21 21
      *
22
-     * @param \SimpleXMLElement $xml
23 22
      *
24 23
      * @return ViewReference
25 24
      */
Please login to merge, or discard this patch.
Bundle/BusinessPageBundle/Builder/BusinessPageReferenceBuilder.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,8 +32,7 @@
 block discarded – undo
32 32
         $businessPageReference->setTemplateId($businessPage->getTemplate()->getId());
33 33
         $businessPageReference->setSlug(
34 34
             $businessPage->getStaticUrl() != '' ?
35
-                $businessPage->getStaticUrl() :
36
-                $businessPage->getSlug()
35
+                $businessPage->getStaticUrl() : $businessPage->getSlug()
37 36
         );
38 37
         $businessPageReference->setEntityId($businessPage->getBusinessEntity()->getId());
39 38
         $businessPageReference->setEntityNamespace($em->getClassMetadata(get_class($businessPage->getBusinessEntity()))->name);
Please login to merge, or discard this patch.
Bundle/CoreBundle/Form/ViewType.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
      */
40 40
     public function buildForm(FormBuilderInterface $builder, array $options)
41 41
     {
42
-        $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {
42
+        $builder->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) {
43 43
             $view = $event->getData();
44 44
             $form = $event->getForm();
45 45
 
@@ -49,11 +49,11 @@  discard block
 block discarded – undo
49 49
             // Si aucune donnée n'est passée au formulaire, la donnée est "null".
50 50
             // Ce doit être considéré comme une nouvelle "View"
51 51
             if ($this->isNew) {
52
-                $getAllTemplateWithoutMe = function (EntityRepository $tr) {
52
+                $getAllTemplateWithoutMe = function(EntityRepository $tr) {
53 53
                     return $tr->getAll()->getInstance();
54 54
                 };
55 55
             } else {
56
-                $getAllTemplateWithoutMe = function (EntityRepository $tr) use ($view) {
56
+                $getAllTemplateWithoutMe = function(EntityRepository $tr) use ($view) {
57 57
                     return $tr->getAll()
58 58
                         ->getInstance()
59 59
                         ->andWhere('template.id != :templateId')
@@ -85,11 +85,11 @@  discard block
 block discarded – undo
85 85
                 // Si aucune donnée n'est passée au formulaire, la donnée est "null".
86 86
                 // Ce doit être considéré comme une nouvelle "View"
87 87
                 if (!$view || null === $view->getId()) {
88
-                    $getAllPageWithoutMe = function (EntityRepository $repo) {
88
+                    $getAllPageWithoutMe = function(EntityRepository $repo) {
89 89
                         return $repo->getAll()->getInstance();
90 90
                     };
91 91
                 } else {
92
-                    $getAllPageWithoutMe = function (EntityRepository $repo) use ($view) {
92
+                    $getAllPageWithoutMe = function(EntityRepository $repo) use ($view) {
93 93
                         return $repo->getAll()
94 94
                             ->getInstance()
95 95
                             ->andWhere('page.id != :pageId')
Please login to merge, or discard this patch.
Bundle/CoreBundle/Route/RouteLoader.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
         return $collection;
30 30
     }
31 31
 
32
-    protected function addVictoireRouting(RouteCollection &$collection)
32
+    protected function addVictoireRouting(RouteCollection & $collection)
33 33
     {
34 34
         $resources = [
35 35
             '@VictoireAnalyticsBundle/Controller/',
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
         }
50 50
     }
51 51
 
52
-    protected function addWidgetsRouting(RouteCollection &$collection)
52
+    protected function addWidgetsRouting(RouteCollection & $collection)
53 53
     {
54 54
         foreach ($this->widgets as $widgetParams) {
55 55
             $controllerResource = '@VictoireWidget'.$widgetParams['name'].'Bundle/Controller/';
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
         }
61 61
     }
62 62
 
63
-    protected function addShowBusinessPageByIdAction(RouteCollection &$collection)
63
+    protected function addShowBusinessPageByIdAction(RouteCollection & $collection)
64 64
     {
65 65
         $pattern = '/victoire-dcms-public/show-business-page-by-id/{entityId}/{type}';
66 66
         $defaults = [
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
         $collection->add($routeName, $route);
75 75
     }
76 76
 
77
-    protected function addShowPageByIdRoute(RouteCollection &$collection)
77
+    protected function addShowPageByIdRoute(RouteCollection & $collection)
78 78
     {
79 79
         $pattern = '/victoire-dcms-public/show-page-by-id/{viewId}/{entityId}';
80 80
         $defaults = [
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
         $collection->add($routeName, $route);
93 93
     }
94 94
 
95
-    protected function addShowPageRoute(RouteCollection &$collection)
95
+    protected function addShowPageRoute(RouteCollection & $collection)
96 96
     {
97 97
         // prepare a new route
98 98
         $pattern = '/{url}';
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
         $collection->add('victoire_core_page_show', $route);
109 109
     }
110 110
 
111
-    protected function addShowHomePageRoute(RouteCollection &$collection)
111
+    protected function addShowHomePageRoute(RouteCollection & $collection)
112 112
     {
113 113
         // prepare a new route
114 114
         $pattern = '/';
Please login to merge, or discard this patch.
Bundle/PageBundle/Twig/Extension/PageExtension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
     /**
49 49
      * register twig functions.
50 50
      *
51
-     * @return array The list of extensions
51
+     * @return \Twig_SimpleFunction[] The list of extensions
52 52
      */
53 53
     public function getFunctions()
54 54
     {
Please login to merge, or discard this patch.
Bundle/CoreBundle/Twig/Extension/RoutingExtention.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
      *
65 65
      * @param $locale
66 66
      *
67
-     * @return null
67
+     * @return string|null
68 68
      */
69 69
     protected function getPrefix($locale)
70 70
     {
Please login to merge, or discard this patch.
Bundle/SitemapBundle/Controller/SitemapController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 
50 50
         $ids = [$tree->getViewId()];
51 51
 
52
-        $getChildrenIds = function (ViewReference $tree) use (&$getChildrenIds, $ids) {
52
+        $getChildrenIds = function(ViewReference $tree) use (&$getChildrenIds, $ids) {
53 53
             foreach ($tree->getChildren() as $child) {
54 54
                 $ids[] = $child->getViewId();
55 55
                 $ids = array_merge($ids, $getChildrenIds($child));
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
         $pageHelper = $this->get('victoire_page.page_helper');
69 69
         $entityManager = $this->getDoctrine()->getManager();
70 70
 
71
-        $getBusinessPages = function (ViewReference $tree) use (&$getBusinessPages, $pageHelper, $entityManager) {
71
+        $getBusinessPages = function(ViewReference $tree) use (&$getBusinessPages, $pageHelper, $entityManager) {
72 72
             $businessPages = [];
73 73
             foreach ($tree->getChildren() as $child) {
74 74
                 if ($child instanceof BusinessPageReference
Please login to merge, or discard this patch.
Bundle/WidgetMapBundle/Command/WidgetMapMigrationCommand.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
                 ->getQuery()
64 64
                 ->getResult();
65 65
             $templates = [];
66
-            $recursiveGetTemplates = function ($template) use (&$recursiveGetTemplates, &$templates) {
66
+            $recursiveGetTemplates = function($template) use (&$recursiveGetTemplates, &$templates) {
67 67
                     array_push($templates, $template);
68 68
                     foreach ($template->getInheritors() as $template) {
69 69
                         if ($template instanceof Template) {
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
                 foreach ($oldWidgetMaps as $slot => $oldWidgetMap) {
98 98
                     $widgetMaps = [];
99 99
                     var_dump($oldWidgetMap);
100
-                    usort($oldWidgetMap, function ($a, $b) {
100
+                    usort($oldWidgetMap, function($a, $b) {
101 101
                         if ($b['position'] - $a['position'] == 0) {
102 102
                             return 1;
103 103
                         }
Please login to merge, or discard this patch.