ViewHelper::cloneView() - Code Metrics - Inspection of "Manage views references tree" - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#290)

by Leny

created 2015-12-01 21:50 UTC

ViewHelper::cloneView() C

↳ Parent: Project

Complexity

Conditions	12
Paths	4

Size

Total Lines	67
Code Lines	49

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	67
rs	5.8429
cc	12
eloc	49
nc	4
nop	2

How to fix Long Method Complexity

<?php

namespace Victoire\Bundle\CoreBundle\Helper;

use Doctrine\Orm\EntityManager;
use Victoire\Bundle\CoreBundle\Entity\View;
use Victoire\Bundle\CoreBundle\Entity\WebViewInterface;
use Victoire\Bundle\ViewReferenceBundle\Helper\ViewReferenceHelper;
use Victoire\Bundle\ViewReferenceBundle\Provider\ViewReferenceProvider;

/**
 * Page helper
 * ref: victoire_core.view_helper.
 */
class ViewHelper
{
    /**
     * @var EntityManager
     */
    private $entityManager;
    /**
     * @var ViewReferenceProvider
     */
    private $viewReferenceProvider;
    /**
     * @var ViewReferenceHelper
     */
    private $viewReferenceHelper;

    /**
     * Constructor.
     *
     * @internal param $ViewManagerChain $$viewManagerChain
     *
     * @param EntityManager         $entityManager
     * @param ViewReferenceHelper   $viewReferenceHelper
     * @param ViewReferenceProvider $viewReferenceProvider
     */
    public function __construct(
        EntityManager $entityManager,
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
        ViewReferenceProvider $viewReferenceProvider,
        ViewReferenceHelper $viewReferenceHelper
    ) {
        $this->entityManager = $entityManager;
        $this->viewReferenceProvider = $viewReferenceProvider;
        $this->viewReferenceHelper = $viewReferenceHelper;
    }

    /**
     * @return WebViewInterface[]
     */
    public function buildViewsReferences()
    {
        $viewsHierarchy = $this->entityManager->getRepository('VictoireCoreBundle:View')->getRootNodes();
        $views = $this->viewReferenceProvider->getReferencableViews($viewsHierarchy, $this->entityManager);

        $this->viewReferenceHelper->buildViewReferenceRecursively($views, $this->entityManager);

        return $views;
    }
}


1			<?php
2
3			namespace Victoire\Bundle\CoreBundle\Helper;
4
5			use Doctrine\Orm\EntityManager;
6			use Victoire\Bundle\CoreBundle\Entity\View;
7			use Victoire\Bundle\CoreBundle\Entity\WebViewInterface;
8			use Victoire\Bundle\ViewReferenceBundle\Helper\ViewReferenceHelper;
9			use Victoire\Bundle\ViewReferenceBundle\Provider\ViewReferenceProvider;
10
11			/**
12			* Page helper
13			* ref: victoire_core.view_helper.
14			*/
15			class ViewHelper
16			{
17			/**
18			* @var EntityManager
19			*/
20			private $entityManager;
21			/**
22			* @var ViewReferenceProvider
23			*/
24			private $viewReferenceProvider;
25			/**
26			* @var ViewReferenceHelper
27			*/
28			private $viewReferenceHelper;
29
30			/**
31			* Constructor.
32			*
33			* @internal param $ViewManagerChain $$viewManagerChain
34			*
35			* @param EntityManager $entityManager
36			* @param ViewReferenceHelper $viewReferenceHelper
37			* @param ViewReferenceProvider $viewReferenceProvider
38			*/
39			public function __construct(
40			EntityManager $entityManager,
			0 ignored issues – show Bug introduced 2015-11-24 15:51 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
41			ViewReferenceProvider $viewReferenceProvider,
42			ViewReferenceHelper $viewReferenceHelper
43			) {
44			$this->entityManager = $entityManager;
45			$this->viewReferenceProvider = $viewReferenceProvider;
46			$this->viewReferenceHelper = $viewReferenceHelper;
47			}
48
49			/**
50			* @return WebViewInterface[]
51			*/
52			public function buildViewsReferences()
53			{
54			$viewsHierarchy = $this->entityManager->getRepository('VictoireCoreBundle:View')->getRootNodes();
55			$views = $this->viewReferenceProvider->getReferencableViews($viewsHierarchy, $this->entityManager);
56
57			$this->viewReferenceHelper->buildViewReferenceRecursively($views, $this->entityManager);
58
59			return $views;
60			}
61			}
62

Victoire / victoire

Pull Request — master (#290)

ViewHelper::cloneView() C

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like