Victoire\Bundle\WidgetBundle\Resolver\BaseWidgetContentResolver

Complexity

Total Complexity

14

Size/Duplication

Total Lines	163
Duplicated Lines	11.66 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	2
Bugs	1	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getWidgetStaticContent()	0	16	3
A	getWidgetBusinessEntityContent()	9	9	1
A	getWidgetEntityContent()	10	10	1
A	getWidgetQueryContent()	0	17	2
A	getWidgetQueryBuilder()	0	11	1
A	populateParametersWithWidgetFields()	0	18	3
A	setQueryHelper()	0	4	1
A	setEntityManager()	0	4	1
A	setApiBusinessEntityResolver()	0	4	1

<?php

namespace Victoire\Bundle\WidgetBundle\Resolver;

use Doctrine\ORM\EntityManager;
use Symfony\Component\PropertyAccess\PropertyAccess;
use Symfony\Component\PropertyAccess\PropertyAccessor;
use Victoire\Bundle\APIBusinessEntityBundle\Entity\APIBusinessEntity;
use Victoire\Bundle\APIBusinessEntityBundle\Resolver\APIBusinessEntityResolver;
use Victoire\Bundle\QueryBundle\Helper\QueryHelper;
use Victoire\Bundle\WidgetBundle\Model\Widget;

class BaseWidgetContentResolver

Missing class doc comment

{
    /**
     * @var QueryHelper
     */
    protected $queryHelper;

    /**
     * @var EntityManager
     */
    protected $entityManager;

    /**
     * @var APIBusinessEntityResolver
     */
    protected $apiResolver;

    /**
     * Get the static content of the widget.
     *
     * @param Widget $widget
     *
     * @return string
     */
    public function getWidgetStaticContent(Widget $widget)
    {
        $reflect = new \ReflectionClass($widget);
        $widgetProperties = $reflect->getProperties();
        $parameters = ['widget' => $widget];
        $accessor = PropertyAccess::createPropertyAccessor();

        foreach ($widgetProperties as $property) {
            if (!$property->isStatic()) {
                $value = $accessor->getValue($widget, $property->getName());
                $parameters[$property->getName()] = $value;
            }
        }

        return $parameters;
    }

    /**
     * Get the business entity content.
     *
     * @param Widget $widget
     *
     * @return string
     */
    public function getWidgetBusinessEntityContent(Widget $widget)

This method seems to be duplicated in your project.

    {
        $entity = $widget->getEntity();
        $parameters = $this->getWidgetStaticContent($widget);

        $this->populateParametersWithWidgetFields($widget, $entity, $parameters);

        return $parameters;
    }

    /**
     * Get the content of the widget by the entity linked to it.
     *
     * @param Widget $widget
     *
     * @return string
     */
    public function getWidgetEntityContent(Widget $widget)

This method seems to be duplicated in your project.

    {
        $entity = $widget->getEntity();

        $parameters = $this->getWidgetStaticContent($widget);

        $this->populateParametersWithWidgetFields($widget, $entity, $parameters);

        return $parameters;
    }

    /**
     * Get the content of the widget for the query mode.
     *
     * @param Widget $widget
     *
     * @return string
     */
    public function getWidgetQueryContent(Widget $widget)
    {
        $parameters = $this->getWidgetStaticContent($widget);

        if (APIBusinessEntity::TYPE === $widget->getBusinessEntity()->getType()) {
            $entity = $this->apiResolver->getBusinessEntities($widget->getBusinessEntity());
        } else {
            $entity = $this->getWidgetQueryBuilder($widget)
                            ->setMaxResults(1)
                            ->getQuery()
                            ->getOneOrNullResult();
        }

        $this->populateParametersWithWidgetFields($widget, $entity, $parameters);

        return $parameters;
    }

    /**
     * Get the widget query result.
     *
     * @param Widget $widget The widget
     *
     * @return \Doctrine\ORM\QueryBuilder The list of entities
     */
    public function getWidgetQueryBuilder(Widget $widget)
    {
        //get the base query
        $itemsQueryBuilder = $this->queryHelper->getQueryBuilder($widget, $this->entityManager);

$widget is of type object<Victoire\Bundle\WidgetBundle\Model\Widget>, but the function expects a object<Victoire\Bundle\QueryBundle\Entity\VictoireQueryInterface>.

        // Filter only visibleOnFront
        $itemsQueryBuilder->andWhere('main_item.visibleOnFront = true');

        //add the query of the widget
        return $this->queryHelper->buildWithSubQuery($widget, $itemsQueryBuilder, $this->entityManager);

$widget is of type object<Victoire\Bundle\WidgetBundle\Model\Widget>, but the function expects a object<Victoire\Bundle\QueryBundle\Entity\VictoireQueryInterface>.

    }

    protected function populateParametersWithWidgetFields(Widget $widget, $entity, &$parameters)
    {
        $fields = $widget->getFields();
        //parse the field
        foreach ($fields as $widgetField => $field) {
            //get the value of the field
            if ($entity !== null) {
                $accessor = new PropertyAccessor();
                $attributeValue = $accessor->getValue($entity, $field);
            } else {
                $attributeValue = $widget->getBusinessEntityName().' -> '.$field;
            }

            $parameters[$widgetField] = $attributeValue;
        }

        $widget->setEntity($entity);
    }

    /**
     * @param QueryHelper $queryHelper
     */
    public function setQueryHelper(QueryHelper $queryHelper)

Declare public methods first,then protected ones and finally private ones

    {
        $this->queryHelper = $queryHelper;
    }

    /**
     * @param EntityManager $entityManager
     */
    public function setEntityManager(EntityManager $entityManager)

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->entityManager = $entityManager;
    }

    /**
     * @param APIBusinessEntityResolver $resolver
     */
    public function setApiBusinessEntityResolver(APIBusinessEntityResolver $resolver)
    {
        $this->apiResolver = $resolver;
    }
}