Victoire\Bundle\I18nBundle\Translation\Translator

Complexity

Total Complexity

17

Size/Duplication

Total Lines	115
Duplicated Lines	8.7 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getLocale()	0	6	1
A	getVictoireLocale()	0	6	1
A	getCurrentLocale()	0	8	2
B	trans()	5	16	5
C	transChoice()	5	26	7

<?php

namespace Victoire\Bundle\I18nBundle\Translation;

use Symfony\Bundle\FrameworkBundle\Translation\Translator as BaseTranslator;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\Translation\MessageSelector;

class Translator extends BaseTranslator
{
    protected $container;
    protected $options = [
        'cache_dir'      => 'test',
        'debug'          => true,
        'resource_files' => [],
    ];
    protected $loaderIds;

    /**
     * @var MessageSelector
     */
    private $selector;

Consider using a different property name as you override a private property of the parent class.

    /**
     * {@inheritdoc}
     *
     * @api
     */
    public function __construct(ContainerInterface $container, MessageSelector $selector, $loaderIds = [], array $options = [])
    {
        parent::__construct($container, $selector, $loaderIds, $options);
        $this->selector = $selector;
        $this->container = $container;
    }

    /**
     * {@inheritdoc}
     *
     * @api
     */
    public function trans($id, array $parameters = [], $domain = null, $locale = null)
    {
        if (null === $locale) {
            $locale = $this->getLocale();
        }
        if (null === $domain) {

This code seems to be duplicated across your project.

            $domain = 'messages';
        } elseif ('victoire' === $domain) {
            $locale = $this->getVictoireLocale();
        }
        if (!isset($this->catalogues[$locale])) {
            $this->loadCatalogue($locale);
        }

        return strtr($this->catalogues[$locale]->get((string) $id, $domain), $parameters);
    }

    /**
     * {@inheritdoc}
     *
     * @api
     */
    public function transChoice($id, $number, array $parameters = [], $domain = null, $locale = null)
    {
        if (null === $locale) {
            $locale = $this->getLocale();
        }
        if (null === $domain) {

This code seems to be duplicated across your project.

            $domain = 'messages';
        } elseif ('victoire' === $domain) {
            $locale = $this->getVictoireLocale();
        }
        if (!isset($this->catalogues[$locale])) {
            $this->loadCatalogue($locale);
        }
        $id = (string) $id;
        $catalogue = $this->catalogues[$locale];
        while (!$catalogue->defines($id, $domain)) {
            if ($cat = $catalogue->getFallbackCatalogue()) {
                $catalogue = $cat;
                $locale = $catalogue->getLocale();
            } else {
                break;
            }
        }

        return strtr($this->selector->choose($catalogue->get($id, $domain), (int) $number, $locale), $parameters);
    }

    /**
     * get the local in the session.
     */
    public function getLocale()
    {
        $this->locale = $this->getCurrentLocale();

        return $this->locale;
    }

    /**
     * get the locale of the administration template.
     *
     * @return string
     */
    public function getVictoireLocale()
    {
        $this->locale = $this->container->get('session')->get('victoire_locale');

        return $this->locale;
    }

    /**
     * @return mixed|string
     */
    public function getCurrentLocale()
    {
        if ($this->container->get('request_stack')->getCurrentRequest()) {
            return $this->container->get('request')->getLocale();
        }

        return $this->container->getParameter('kernel.default_locale');
    }
}