RoutingExtension::getPath() - Code Metrics - Inspection of "Bump extend from 3.0.0 to 3.0.2 in /Bundle/UIBundl..." - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 2.3 (#1140)

unknown

created 2021-01-12 09:57 UTC

RoutingExtension::getPath() C

↳ Parent: RoutingExtension

Complexity

Conditions	11
Paths	42

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
nc	42
nop	3
dl	0
loc	52
rs	6.9006
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Victoire\Bundle\CoreBundle\Twig\Extension;

use Doctrine\ORM\EntityRepository;
use Psr\Log\LoggerInterface;
use Symfony\Bridge\Twig\Extension\RoutingExtension as BaseRoutingExtension;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Victoire\Bundle\I18nBundle\Resolver\LocaleResolver;
use Victoire\Bundle\PageBundle\Helper\PageHelper;
use Victoire\Bundle\ViewReferenceBundle\Exception\ViewReferenceNotFoundException;

/**
 * class RoutingExtension.
 */
class RoutingExtension extends BaseRoutingExtension
{
    private $pageHelper;
    private $generator;

    private $localeResolver;
    private $logger;
    private $errorPageRepository;
    private $locale;

    /**
     * @param PageHelper            $pageHelper
     * @param UrlGeneratorInterface $generator
     * @param LocaleResolver        $localeResolver
     * @param RequestStack          $requestStack
     * @param LoggerInterface       $logger
     * @param EntityRepository      $errorPageRepository
     * @param                       $locale
     */
    public function __construct(
        PageHelper $pageHelper,
        UrlGeneratorInterface $generator,
        LocaleResolver $localeResolver,
        RequestStack $requestStack,
        LoggerInterface $logger,
        EntityRepository $errorPageRepository,
        $locale
    ) {
        $this->pageHelper = $pageHelper;
        $this->generator = $generator;
        $this->localeResolver = $localeResolver;
        $this->request = $requestStack->getCurrentRequest();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->logger = $logger;
        $this->errorPageRepository = $errorPageRepository;
        parent::__construct($generator);
        $this->locale = $locale;
    }

    public function getPath($name, $parameters = [], $relative = false)
    {
        $requestLocale = $this->request ? $this->request->getLocale() : $this->locale;
        if ($name == 'victoire_core_page_show_by_id') {
            $params = [
                'viewId' => $parameters['viewId'],
                'locale' => $requestLocale,
            ];
            unset($parameters['viewId']);
            if (!empty($parameters['entityId'])) {
                $params['entityId'] = $parameters['entityId'];
                unset($parameters['entityId']);
            }

            try {
                $page = $this->pageHelper->findPageByParameters($params);
                $parameters['url'] = $page->getReference($requestLocale)->getUrl();
            } catch (ViewReferenceNotFoundException $e) {
                $this->logger->error($e->getMessage(), [
                    'params' => $params,
                ]);
                $errorPage = $this->errorPageRepository->findOneByCode(404);
                $parameters['url'] = $this->generator->generate(
                    'victoire_core_page_show',
                    array_merge(
                        [
                            '_locale' => $requestLocale,
                            'url'     => $errorPage ? $errorPage->getSlug() : '',
                        ],
                        $parameters
                    )
                );
            }

            $name = 'victoire_core_page_show';
        }

        $prefix = '';
        //if locale is passed (and different) and i18n strategy is "domain"
        if (!empty($parameters['_locale'])
            && $parameters['_locale'] != $requestLocale
            && $this->localeResolver->localePattern === LocaleResolver::PATTERN_DOMAIN
        ) {
            $prefix = $this->getPrefix($parameters['_locale']);
            //if we set a prefix, we don't want an absolute path
            if ($prefix) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $relative = true;
            }
        }

        return $prefix.$this->generator->generate($name, $parameters, $relative ? UrlGeneratorInterface::ABSOLUTE_PATH : UrlGeneratorInterface::ABSOLUTE_URL);
    }

    /**
     * If victoire_i18n.locale_pattern == domain, then we force the url rewrite with a valid host.
     *
     * @param $locale
     *
     * @return null
     */
    protected function getPrefix($locale)
    {
        foreach ($this->localeResolver->getDomainConfig() as $_domain => $_locale) {
            if ($_locale === $locale) {
                $urlPrefix = sprintf('%s://%s', $this->request ? $this->request->getScheme() : 'http', $_domain);
                if ($this->request && $this->request->getPort()) {
                    $urlPrefix .= ':'.$this->request->getPort();
                }

                return $urlPrefix;
            }
        }
    }
}


1			<?php
2
3			namespace Victoire\Bundle\CoreBundle\Twig\Extension;
4
5			use Doctrine\ORM\EntityRepository;
6			use Psr\Log\LoggerInterface;
7			use Symfony\Bridge\Twig\Extension\RoutingExtension as BaseRoutingExtension;
8			use Symfony\Component\HttpFoundation\RequestStack;
9			use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
10			use Victoire\Bundle\I18nBundle\Resolver\LocaleResolver;
11			use Victoire\Bundle\PageBundle\Helper\PageHelper;
12			use Victoire\Bundle\ViewReferenceBundle\Exception\ViewReferenceNotFoundException;
13
14			/**
15			* class RoutingExtension.
16			*/
17			class RoutingExtension extends BaseRoutingExtension
18			{
19			private $pageHelper;
20			private $generator;
			0 ignored issues – show Comprehensibility introduced 2015-11-24 15:51 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
21			private $localeResolver;
22			private $logger;
23			private $errorPageRepository;
24			private $locale;
25
26			/**
27			* @param PageHelper $pageHelper
28			* @param UrlGeneratorInterface $generator
29			* @param LocaleResolver $localeResolver
30			* @param RequestStack $requestStack
31			* @param LoggerInterface $logger
32			* @param EntityRepository $errorPageRepository
33			* @param $locale
34			*/
35			public function __construct(
36			PageHelper $pageHelper,
37			UrlGeneratorInterface $generator,
38			LocaleResolver $localeResolver,
39			RequestStack $requestStack,
40			LoggerInterface $logger,
41			EntityRepository $errorPageRepository,
42			$locale
43			) {
44			$this->pageHelper = $pageHelper;
45			$this->generator = $generator;
46			$this->localeResolver = $localeResolver;
47			$this->request = $requestStack->getCurrentRequest();
			0 ignored issues – show Bug introduced 2016-01-27 17:07 UTC by Report Bug Copy Issue Report The property `request` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
48			$this->logger = $logger;
49			$this->errorPageRepository = $errorPageRepository;
50			parent::__construct($generator);
51			$this->locale = $locale;
52			}
53
54			public function getPath($name, $parameters = [], $relative = false)
55			{
56			$requestLocale = $this->request ? $this->request->getLocale() : $this->locale;
57			if ($name == 'victoire_core_page_show_by_id') {
58			$params = [
59			'viewId' => $parameters['viewId'],
60			'locale' => $requestLocale,
61			];
62			unset($parameters['viewId']);
63			if (!empty($parameters['entityId'])) {
64			$params['entityId'] = $parameters['entityId'];
65			unset($parameters['entityId']);
66			}
67
68			try {
69			$page = $this->pageHelper->findPageByParameters($params);
70			$parameters['url'] = $page->getReference($requestLocale)->getUrl();
71			} catch (ViewReferenceNotFoundException $e) {
72			$this->logger->error($e->getMessage(), [
73			'params' => $params,
74			]);
75			$errorPage = $this->errorPageRepository->findOneByCode(404);
76			$parameters['url'] = $this->generator->generate(
77			'victoire_core_page_show',
78			array_merge(
79			[
80			'_locale' => $requestLocale,
81			'url' => $errorPage ? $errorPage->getSlug() : '',
82			],
83			$parameters
84			)
85			);
86			}
87
88			$name = 'victoire_core_page_show';
89			}
90
91			$prefix = '';
92			//if locale is passed (and different) and i18n strategy is "domain"
93			if (!empty($parameters['_locale'])
94			&& $parameters['_locale'] != $requestLocale
95			&& $this->localeResolver->localePattern === LocaleResolver::PATTERN_DOMAIN
96			) {
97			$prefix = $this->getPrefix($parameters['_locale']);
98			//if we set a prefix, we don't want an absolute path
99			if ($prefix) {
			0 ignored issues – show Bug Best Practice introduced 2016-01-27 17:07 UTC by Report Bug Copy Issue Report The expression `$prefix` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
100			$relative = true;
101			}
102			}
103
104			return $prefix.$this->generator->generate($name, $parameters, $relative ? UrlGeneratorInterface::ABSOLUTE_PATH : UrlGeneratorInterface::ABSOLUTE_URL);
105			}
106
107			/**
108			* If victoire_i18n.locale_pattern == domain, then we force the url rewrite with a valid host.
109			*
110			* @param $locale
111			*
112			* @return null
113			*/
114			protected function getPrefix($locale)
115			{
116			foreach ($this->localeResolver->getDomainConfig() as $_domain => $_locale) {
117			if ($_locale === $locale) {
118			$urlPrefix = sprintf('%s://%s', $this->request ? $this->request->getScheme() : 'http', $_domain);
119			if ($this->request && $this->request->getPort()) {
120			$urlPrefix .= ':'.$this->request->getPort();
121			}
122
123			return $urlPrefix;
124			}
125			}
126			}
127			}
128

Victoire / victoire

Pull Request — 2.3 (#1140)

RoutingExtension::getPath() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like