Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 21 | class TemplateController extends Controller |
||
| 22 | { |
||
| 23 | /** |
||
| 24 | * list of all templates. |
||
| 25 | * |
||
| 26 | * @Route("/index", name="victoire_template_index") |
||
| 27 | * @Configuration\Template() |
||
| 28 | * |
||
| 29 | * @return JsonResponse |
||
| 30 | */ |
||
| 31 | public function indexAction() |
||
| 32 | { |
||
| 33 | $templates = $this->get('doctrine.orm.entity_manager')->getRepository('VictoireTemplateBundle:Template')->findByTemplate(null, ['position' => 'ASC']); |
||
| 34 | |||
| 35 | return new JsonResponse( |
||
| 36 | [ |
||
| 37 | 'success' => true, |
||
| 38 | 'html' => $this->container->get('templating')->render( |
||
| 39 | 'VictoireTemplateBundle:Template:index.html.twig', |
||
| 40 | ['templates' => $templates] |
||
| 41 | ), |
||
| 42 | ] |
||
| 43 | ); |
||
| 44 | } |
||
| 45 | |||
| 46 | /** |
||
| 47 | * list of all templates. |
||
| 48 | * |
||
| 49 | * @param Template $template The template |
||
| 50 | * |
||
| 51 | * @Route("/show/{slug}", name="victoire_template_show") |
||
| 52 | * @ParamConverter("template", class="VictoireTemplateBundle:Template", options={"mapping": {"slug": "slug"}}) |
||
| 53 | * |
||
| 54 | * @return Response |
||
| 55 | */ |
||
| 56 | public function showAction(Template $template) |
||
| 94 | |||
| 95 | /** |
||
| 96 | * create a new Template. |
||
| 97 | * |
||
| 98 | * @return JsonResponse |
||
| 99 | * @Route("/new", name="victoire_template_new") |
||
| 100 | * @Configuration\Template() |
||
| 101 | */ |
||
| 102 | public function newAction() |
||
| 129 | |||
| 130 | /** |
||
| 131 | * define settings of the template. |
||
| 132 | * |
||
| 133 | * @param Template $template |
||
| 134 | * |
||
| 135 | * @return JsonResponse |
||
| 136 | * @Route("/{slug}/parametres", name="victoire_template_settings") |
||
| 137 | * @ParamConverter("template", class="VictoireTemplateBundle:Template", options={"mapping": {"slug": "slug"}}) |
||
| 138 | */ |
||
| 139 | public function settingsAction(Request $request, $template) |
||
| 167 | |||
| 168 | /** |
||
| 169 | * edit a Template. |
||
| 170 | * |
||
| 171 | * @param Template $template The Template to edit |
||
| 172 | * |
||
| 173 | * @return \Symfony\Component\HttpFoundation\RedirectResponse |
||
| 174 | * @Route("/edit/{slug}", name="victoire_template_edit") |
||
| 175 | * @Configuration\Template() |
||
| 176 | * @ParamConverter("template", class="VictoireTemplateBundle:Template") |
||
| 177 | */ |
||
| 178 | public function editAction(Template $template) |
||
| 193 | } |
||
| 194 |
This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.
This is most likely a typographical error or the method has been renamed.