Conditions | 30 |
Paths | 301 |
Total Lines | 132 |
Code Lines | 89 |
Lines | 67 |
Ratio | 50.76 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
34 | public function adaptChildren(MenuBuilder $menu, array &$children, MenuItem $parent = null, Request $request = null) |
||
35 | { |
||
36 | $mediaRoutes = [ |
||
37 | 'Show media' => 'VictoireMediaBundle_media_show', |
||
38 | 'Edit metadata' => 'VictoireMediaBundle_metadata_edit', |
||
39 | 'Edit slide' => 'VictoireMediaBundle_slide_edit', |
||
40 | 'Edit video' => 'VictoireMediaBundle_video_edit', |
||
41 | ]; |
||
42 | |||
43 | $createRoutes = [ |
||
44 | 'Create' => 'VictoireMediaBundle_media_create', |
||
45 | 'Bulk upload' => 'VictoireMediaBundle_media_bulk_upload', |
||
46 | ]; |
||
47 | |||
48 | $allRoutes = array_merge($createRoutes, $mediaRoutes); |
||
49 | |||
50 | if (is_null($parent)) { |
||
51 | /* @var \Victoire\Bundle\MediaBundle\Entity\Folder[] $galleries */ |
||
52 | $galleries = $this->em->getRepository('VictoireMediaBundle:Folder')->getAllFolders(); |
||
53 | $currentId = $request->get('folderId'); |
||
54 | |||
55 | View Code Duplication | if (isset($currentId)) { |
|
56 | /* @var \Victoire\Bundle\MediaBundle\Entity\Folder $currentFolder */ |
||
57 | $currentFolder = $this->em->getRepository('VictoireMediaBundle:Folder')->findOneById($currentId); |
||
58 | } elseif (in_array($request->attributes->get('_route'), $mediaRoutes)) { |
||
59 | /* @var \Victoire\Bundle\MediaBundle\Entity\Media $media */ |
||
60 | $media = $this->em->getRepository('VictoireMediaBundle:Media')->getMedia($request->get('mediaId')); |
||
61 | $currentFolder = $media->getFolder(); |
||
62 | } elseif (in_array($request->attributes->get('_route'), $createRoutes)) { |
||
63 | $currentId = $request->get('folderId'); |
||
64 | if (isset($currentId)) { |
||
65 | $currentFolder = $this->em->getRepository('VictoireMediaBundle:Folder')->findOneById($currentId); |
||
66 | } |
||
67 | } |
||
68 | |||
69 | if (isset($currentFolder)) { |
||
70 | $parents = $currentFolder->getParents(); |
||
71 | } else { |
||
72 | $parents = []; |
||
73 | } |
||
74 | |||
75 | View Code Duplication | foreach ($galleries as $folder) { |
|
76 | $menuitem = new TopMenuItem($menu); |
||
77 | $menuitem->setRoute('VictoireMediaBundle_folder_show'); |
||
78 | $menuitem->setRouteparams(['folderId' => $folder->getId()]); |
||
79 | $menuitem->setInternalname($folder->getName()); |
||
80 | $menuitem->setParent($parent); |
||
81 | $menuitem->setRole($folder->getRel()); |
||
82 | if (isset($currentFolder) && (stripos($request->attributes->get('_route'), $menuitem->getRoute()) !== false || in_array($request->attributes->get('_route'), $allRoutes))) { |
||
83 | if ($currentFolder->getId() == $folder->getId()) { |
||
84 | $menuitem->setActive(true); |
||
85 | } else { |
||
86 | foreach ($parents as $_parent) { |
||
87 | if ($_parent->getId() == $folder->getId()) { |
||
88 | $menuitem->setActive(true); |
||
89 | break; |
||
90 | } |
||
91 | } |
||
92 | } |
||
93 | } |
||
94 | $children[] = $menuitem; |
||
95 | } |
||
96 | } elseif ('VictoireMediaBundle_folder_show' == $parent->getRoute()) { |
||
97 | $parentRouteParams = $parent->getRouteparams(); |
||
98 | /* @var \Victoire\Bundle\MediaBundle\Entity\Folder $parentFolder */ |
||
99 | $parentFolder = $this->em->getRepository('VictoireMediaBundle:Folder')->findOneById($parentRouteParams['folderId']); |
||
100 | /* @var \Victoire\Bundle\MediaBundle\Entity\Folder[] $galleries */ |
||
101 | $galleries = $parentFolder->getChildren(); |
||
102 | $currentId = $request->get('folderId'); |
||
103 | |||
104 | View Code Duplication | if (isset($currentId)) { |
|
105 | /* @var \Victoire\Bundle\MediaBundle\Entity\Folder $currentFolder */ |
||
106 | $currentFolder = $this->em->getRepository('VictoireMediaBundle:Folder')->findOneById($currentId); |
||
107 | } elseif (in_array($request->attributes->get('_route'), $mediaRoutes)) { |
||
108 | $media = $this->em->getRepository('VictoireMediaBundle:Media')->getMedia($request->get('mediaId')); |
||
109 | $currentFolder = $media->getFolder(); |
||
110 | } elseif (in_array($request->attributes->get('_route'), $createRoutes)) { |
||
111 | $currentId = $request->get('folderId'); |
||
112 | if (isset($currentId)) { |
||
113 | $currentFolder = $this->em->getRepository('VictoireMediaBundle:Folder')->findOneById($currentId); |
||
114 | } |
||
115 | } |
||
116 | |||
117 | /* @var \Victoire\Bundle\MediaBundle\Entity\Folder[] $parentGalleries */ |
||
118 | $parentGalleries = null; |
||
119 | if (isset($currentFolder)) { |
||
120 | $parentGalleries = $currentFolder->getParents(); |
||
121 | } else { |
||
122 | $parentGalleries = []; |
||
123 | } |
||
124 | |||
125 | View Code Duplication | foreach ($galleries as $folder) { |
|
126 | $menuitem = new MenuItem($menu); |
||
127 | $menuitem->setRoute('VictoireMediaBundle_folder_show'); |
||
128 | $menuitem->setRouteparams(['folderId' => $folder->getId()]); |
||
129 | $menuitem->setInternalname($folder->getName()); |
||
130 | $menuitem->setParent($parent); |
||
131 | $menuitem->setRole($folder->getRel()); |
||
132 | if (isset($currentFolder) && (stripos($request->attributes->get('_route'), $menuitem->getRoute()) === 0 || in_array($request->attributes->get('_route'), $allRoutes))) { |
||
133 | if ($currentFolder->getId() == $folder->getId()) { |
||
134 | $menuitem->setActive(true); |
||
135 | } else { |
||
136 | foreach ($parentGalleries as $parentFolder) { |
||
137 | if ($parentFolder->getId() == $folder->getId()) { |
||
138 | $menuitem->setActive(true); |
||
139 | break; |
||
140 | } |
||
141 | } |
||
142 | } |
||
143 | } |
||
144 | $children[] = $menuitem; |
||
145 | } |
||
146 | |||
147 | foreach ($allRoutes as $name => $route) { |
||
148 | $menuitem = new MenuItem($menu); |
||
149 | $menuitem->setRoute($route); |
||
150 | $menuitem->setInternalname($name); |
||
151 | $menuitem->setParent($parent); |
||
152 | $menuitem->setAppearInNavigation(false); |
||
153 | if (stripos($request->attributes->get('_route'), $menuitem->getRoute()) === 0) { |
||
154 | if (stripos($menuitem->getRoute(), 'VictoireMediaBundle_media_show') === 0) { |
||
155 | /* @var Media $media */ |
||
156 | $media = $this->em->getRepository('VictoireMediaBundle:Media')->getMedia($request->get('mediaId')); |
||
157 | $menuitem->setInternalname('Show '.$media->getClassType().' '.$media->getName()); |
||
158 | } |
||
159 | $menuitem->setActive(true); |
||
160 | } |
||
161 | |||
162 | $children[] = $menuitem; |
||
163 | } |
||
164 | } |
||
165 | } |
||
166 | } |
||
167 |
The
EntityManager
might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following:If that code throws an exception and the
EntityManager
is closed. Any other code which depends on the same instance of theEntityManager
during this request will fail.On the other hand, if you instead inject the
ManagerRegistry
, thegetManager()
method guarantees that you will always get a usable manager instance.