BrowseEventController::trackAction() - Code Metrics - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

BrowseEventController::trackAction() A
last analyzed 2017-05-22 12:29 UTC

↳ Parent: BrowseEventController

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	11
nc	2
nop	3

<?php

namespace Victoire\Bundle\AnalyticsBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Victoire\Bundle\AnalyticsBundle\Entity\BrowseEvent;
use Victoire\Bundle\UserBundle\Entity\User;

/**
 * @Route("/browseEvent")
 */
class BrowseEventController extends Controller
{
    /**

     * @Route("/track/{viewReferenceId}/{referer}", name="victoire_analytics_track")
     */

    public function trackAction(Request $request, $viewReferenceId, $referer = null)
    {
        $browseEvent = new BrowseEvent();
        $browseEvent->setViewReferenceId($viewReferenceId);
        $browseEvent->setIp($request->getClientIp());
        $browseEvent->setReferer($referer);
        if ($this->get('security.authorization_checker')->isGranted('IS_AUTHENTICATED_REMEMBERED')) {
            $browseEvent->setAuthor($this->getUser());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        $entityManager = $this->get('doctrine.orm.entity_manager');
        $entityManager->persist($browseEvent);
        $entityManager->flush();

        return new Response();
    }

    /**

     * @Route("/heartbeat/{id}", name="victoire_analytics_heartbeat")
     */

    public function heartbeatAction($id)
    {
        $entityManager = $this->get('doctrine.orm.entity_manager');
        /** @var User $user */
        $user = $entityManager->getRepository($this->getParameter('victoire_core.user_class'))->find($id);
        $user->setHeartbeat(new \DateTime());
        $entityManager->flush();
        $this->get('logger')->info('victoire.analytics.user_heartbeat');

        return new Response(null, 202);
    }
}


1			<?php
2
3			namespace Victoire\Bundle\AnalyticsBundle\Controller;
4
5			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
6			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7			use Symfony\Component\HttpFoundation\Request;
8			use Symfony\Component\HttpFoundation\Response;
9			use Victoire\Bundle\AnalyticsBundle\Entity\BrowseEvent;
10			use Victoire\Bundle\UserBundle\Entity\User;
11
12			/**
13			* @Route("/browseEvent")
14			*/
15			class BrowseEventController extends Controller
16			{
17			/**
			0 ignored issues – show introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Doc comment for parameter "$request" missing Loading history... introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Doc comment for parameter "$viewReferenceId" missing Loading history... introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Doc comment for parameter "$referer" missing Loading history...
18			* @Route("/track/{viewReferenceId}/{referer}", name="victoire_analytics_track")
19			*/
			0 ignored issues – show introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
20			public function trackAction(Request $request, $viewReferenceId, $referer = null)
21			{
22			$browseEvent = new BrowseEvent();
23			$browseEvent->setViewReferenceId($viewReferenceId);
24			$browseEvent->setIp($request->getClientIp());
25			$browseEvent->setReferer($referer);
26			if ($this->get('security.authorization_checker')->isGranted('IS_AUTHENTICATED_REMEMBERED')) {
27			$browseEvent->setAuthor($this->getUser());
			0 ignored issues – show Documentation introduced 2015-11-24 15:51 UTC by Report Bug Copy Issue Report `$this->getUser()` is of type `null\|object`, but the function expects a `object<Victoire\Bundle\UserBundle\Model\User>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28			}
29			$entityManager = $this->get('doctrine.orm.entity_manager');
30			$entityManager->persist($browseEvent);
31			$entityManager->flush();
32
33			return new Response();
34			}
35
36			/**
			0 ignored issues – show introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Doc comment for parameter "$id" missing Loading history...
37			* @Route("/heartbeat/{id}", name="victoire_analytics_heartbeat")
38			*/
			0 ignored issues – show introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
39			public function heartbeatAction($id)
40			{
41			$entityManager = $this->get('doctrine.orm.entity_manager');
42			/** @var User $user */
43			$user = $entityManager->getRepository($this->getParameter('victoire_core.user_class'))->find($id);
44			$user->setHeartbeat(new \DateTime());
45			$entityManager->flush();
46			$this->get('logger')->info('victoire.analytics.user_heartbeat');
47
48			return new Response(null, 202);
49			}
50			}
51

Victoire / victoire

BrowseEventController::trackAction() A last analyzed 2017-05-22 12:29 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

BrowseEventController::trackAction() A
last analyzed 2017-05-22 12:29 UTC