Victoire\Bundle\ViewReferenceBundle\Builder\ViewReferenceBuilder

Complexity

Total Complexity

2

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	buildViewReference()	0	7	1

<?php

namespace Victoire\Bundle\ViewReferenceBundle\Builder;

use Doctrine\ORM\EntityManager;
use Victoire\Bundle\CoreBundle\Entity\View;
use Victoire\Bundle\CoreBundle\Entity\WebViewInterface;
use Victoire\Bundle\ViewReferenceBundle\Builder\Chain\ViewReferenceBuilderChain;
use Victoire\Bundle\ViewReferenceBundle\ViewReference\ViewReference;

/**
 * View Reference builder
 * ref: victoire_view_reference.builder.
 */
class ViewReferenceBuilder
{
    protected $viewReferenceBuilderChain;

    public function __construct(ViewReferenceBuilderChain $viewReferenceBuilderChain)

Missing function doc comment

    {
        $this->viewReferenceBuilderChain = $viewReferenceBuilderChain;
    }

    /**

Doc comment for parameter "$em" missing

     * compute the viewReference relative to a View + entity.
     *
     * @param WebViewInterface $view
     *
     * @return ViewReference
     */
    public function buildViewReference(View $view, EntityManager $em = null)
    {
        $viewReferenceBuilder = $this->viewReferenceBuilderChain->getViewReferenceBuilder($view);
        $viewReference = $viewReferenceBuilder->buildReference($view, $em);

It seems like $em defined by parameter $em on line 31 can be null; however, Victoire\Bundle\ViewReferenceBundle\Builder\BaseReferenceBuilder::buildReference() does not accept null, maybe add an additional type check?

        return $viewReference;
    }
}