Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class RequestDataSource |
||
|
|||
9 | { |
||
10 | /** |
||
11 | * @var RequestStack |
||
12 | */ |
||
13 | private $requestStack; |
||
14 | private $availableLocales; |
||
15 | |||
16 | /** |
||
17 | * RequestCriteria constructor. |
||
18 | * |
||
19 | * @param RequestStack $requestStack |
||
20 | * @param $availableLocales |
||
21 | */ |
||
22 | public function __construct(RequestStack $requestStack, $availableLocales) |
||
23 | { |
||
24 | $this->requestStack = $requestStack; |
||
25 | $this->availableLocales = $availableLocales; |
||
26 | } |
||
27 | |||
28 | public function getLocale() |
||
32 | |||
33 | public function getScheme() |
||
37 | |||
38 | View Code Duplication | public function getLocaleFormParams() |
|
51 | |||
52 | public function getSchemeFormParams() |
||
64 | } |
||
65 |