Vetor\Laravel\Collect\Collector\Models\Traits\Collector

Complexity

Total Complexity

5

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Test Coverage

Coverage

80%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	collect()	0	3	1
A	collections()	0	3	1
A	isCollectThis()	0	3	1
A	cancelCollect()	0	3	1
A	collectionsWhereCollectable()	0	3	1

<?php

namespace Vetor\Laravel\Collect\Collector\Models\Traits;

use Vetor\Contracts\Collect\Collection\Models\Collection as CollectionContract;
use Vetor\Contracts\Collect\Collectable\Models\Collectable as CollectableContract;
use Vetor\Contracts\Collect\Collectable\Services\CollectableService as CollectableServiceContract;

trait Collector
{
    /**
     * @return mixed
     */
    public function collections()
    {
        return $this->hasMany(app(CollectionContract::class), 'user_id', $this->getKeyName());

It seems like getKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like hasMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param \Vetor\Contracts\Collect\Collectable\Models\Collectable $collectable
     */
    public function collect(CollectableContract $collectable)
    {
        return app(CollectableServiceContract::class)->addCollectionTo($collectable, $this);
    }

    /**
     * @param \Vetor\Contracts\Collect\Collectable\Models\Collectable $collectable
     */
    public function isCollectThis(CollectableContract $collectable)
    {
        return app(CollectableServiceContract::class)->isCollection($collectable, $this);

The method isCollection() does not exist on Vetor\Contracts\Collect\Collectable\Services\CollectableService. Since it exists in all sub-types, consider adding an abstract or default implementation to Vetor\Contracts\Collect\Collectable\Services\CollectableService.

    }

    /**
     * @param \Vetor\Contracts\Collect\Collectable\Models\Collectable $collectable
     */
    public function cancelCollect(CollectableContract $collectable)
    {
        return app(CollectableServiceContract::class)->removeCollectionFrom($collectable, $this);
    }

    /**
     * @param $collectableClass
     * @return mixed
     */
    public function collectionsWhereCollectable($collectableClass)
    {
        return $this->collections()->where('collectable_type', (new $collectableClass)->getMorphClass())->get();
    }
}