BiomQualifier::qualifyBiom() - Code Metrics - Inspection of "RandomGenerator usage in BiomQualifier::getRandomB..." - Vehsamrak/terraformator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e3f202...b2ed8f )

by Petr

created 2017-02-04 00:10 UTC

BiomQualifier::qualifyBiom() B

↳ Parent: BiomQualifier

Complexity

Conditions	6
Paths	7

Size

Total Lines	24
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	24
ccs	12
cts	12
cp	1
rs	8.5125
cc	6
eloc	12
nc	7
nop	1
crap	6

<?php

namespace Vehsamrak\Terraformator\LocationGenerator;

use Vehsamrak\Terraformator\Entity\Location;
use Vehsamrak\Terraformator\Entity\Map;
use Vehsamrak\Terraformator\Enum\Biom;
use Vehsamrak\Terraformator\Service\RandomGenerator;

/**
 * @author Vehsamrak
 */
class BiomQualifier
{

    /** @var RandomGenerator $randomGenerator */
    private $randomGenerator;

    public function __construct(RandomGenerator $randomGenerator)
    {
        $this->randomGenerator = $randomGenerator;
    }

    public function qualifyBiom(Map $map): Biom
    {
        $firstLocationInMap = $map->first();

        if (!$firstLocationInMap) {
            return $this->getRandomBiom();
        }

        $firstBiom = $firstLocationInMap->getBiom();
        $locationsAreSame = true;

        /** @var Location $location */
        foreach ($map->toArray() as $location) {
            if (!$location->getBiom()->equals($firstBiom)) {
                $locationsAreSame = false;
            }
        }

        if ($map->count() == 8 && $locationsAreSame) {
            return $firstBiom;
        }

        return $this->getRandomBiom();
    }

    private function getRandomBiom(): Biom
    {
        $allBioms = Biom::values();
        $randomBiomKey = $this->randomGenerator->getRandomKeyFromArray($allBioms);
        $randomBiom = $allBioms[$randomBiomKey];

        return $randomBiom;
    }
}


1		<?php
2
3		namespace Vehsamrak\Terraformator\LocationGenerator;
4
5		use Vehsamrak\Terraformator\Entity\Location;
6		use Vehsamrak\Terraformator\Entity\Map;
7		use Vehsamrak\Terraformator\Enum\Biom;
8		use Vehsamrak\Terraformator\Service\RandomGenerator;
9
10		/**
11		* @author Vehsamrak
12		*/
13		class BiomQualifier
14		{
15
16		/** @var RandomGenerator $randomGenerator */
17		private $randomGenerator;
18
19	6	public function __construct(RandomGenerator $randomGenerator)
20		{
21	6	$this->randomGenerator = $randomGenerator;
22	6	}
23
24	6	public function qualifyBiom(Map $map): Biom
25		{
26	6	$firstLocationInMap = $map->first();
27
28	6	if (!$firstLocationInMap) {
29	4	return $this->getRandomBiom();
30		}
31
32	4	$firstBiom = $firstLocationInMap->getBiom();
33	4	$locationsAreSame = true;
34
35		/** @var Location $location */
36	4	foreach ($map->toArray() as $location) {
37	4	if (!$location->getBiom()->equals($firstBiom)) {
38	4	$locationsAreSame = false;
39		}
40		}
41
42	4	if ($map->count() == 8 && $locationsAreSame) {
43	2	return $firstBiom;
44		}
45
46	2	return $this->getRandomBiom();
47		}
48
49	4	private function getRandomBiom(): Biom
50		{
51	4	$allBioms = Biom::values();
52	4	$randomBiomKey = $this->randomGenerator->getRandomKeyFromArray($allBioms);
53	4	$randomBiom = $allBioms[$randomBiomKey];
54
55	4	return $randomBiom;
56		}
57		}
58

Vehsamrak / terraformator

Push — master ( e3f202...b2ed8f )

BiomQualifier::qualifyBiom() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like