VeggieMeat / opcache

opcache.admin.inc

<?php
/**
 * @file
 * Administration-related forms and such.
 */
use OPCache\OPCache;

/**
 * Form callback for OPcache's administration form.
 */
function opcache_admin_form($form, &$form_state) {

The parameter $form_state is not used and could be removed.

  drupal_set_title(t('OPcache'));
  $backends = variable_get('opcache_backends', NULL);
  $form['opcache_backends'] = array(
    '#type' => 'textarea',
    '#title' => t('PHP proxy back-ends'),
    '#default_value' => empty($backends) ? '' : implode("\n", $backends),
    '#description' => t('If you run PHP behind one or more proxy back-ends, enter the full URLs to the PHP servers here, one per line. Include the protocol, and if clean URLs are not enabled, append “index.php?q=” to the end. For example, “http://127.0.0.1:8080/” or “https://192.168.0.12/drupal/index.php?q=”. If you are not running PHP behind a proxy back-end, leave this field blank.'),
    '#weight' => 0,
  );
  $form['submit'] = array(
    '#type' => 'submit',
    '#value' => t('Save configuration'),
    '#weight' => 990,
  );
  return $form;
}

/**
 * Submit handler for our configuration form.
 */
function opcache_admin_form_submit($form, $form_state) {

The parameter $form is not used and could be removed.

  $trimmed = trim($form_state['values']['opcache_backends']);
  if (!empty($trimmed)) {
    $backends = preg_split("/\r\n|\n|\r/", $form_state['values']['opcache_backends']);
  }
  else {
    $backends = NULL;
  }
  variable_set('opcache_backends', $backends);
  drupal_set_message(t('The configuration options have been saved.'));
}

/**
 * Page callback for OPCache status.
 */
function opcache_admin_status() {
  $opcache = new OPCache();
  $status = $opcache->status();
  $render = array(
    'opcache-status' => array(
      '#theme' => 'table',
      '#rows' => $status,
    ),
  );
  return drupal_render($render);
}

/**
 * Page callback for OPCache configuration.
 */

function opcache_admin_config() {
  $opcache = new OPCache();
  $config = $opcache->config();
  $render = array(
    'opcache-config' => array(
      '#theme' => 'table',
      '#rows' => $config,
    ),
  );
  return drupal_render($render);
}