BlackJackController::playBlackJack() - Code Metrics - Inspection of "Updated docs kmom10." - Veddan12/mvc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( a57e19...f52e71 )

by Vedrana

created 2025-10-04 13:52 UTC

BlackJackController::playBlackJack() A

↳ Parent: BlackJackController

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	12
nc	2
nop	1
dl	0
loc	16
ccs	0
cts	12
cp	0
crap	6
rs	9.8666
c	1
b	0
f	0

<?php

namespace App\Controller;

use App\Card\BlackJack;
use App\Service\GameBlackJackService;
use App\Service\GameBlackJackValidateService;
use Symfony\Component\HttpFoundation\Session\SessionInterface;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Yaml\Exception\RuntimeException;

/**
 * BlackJack Controller.
 */
final class BlackJackController extends AbstractController
{
    /**
     * Init the BlackJack game after bet is submitted.
     *
     * @param SessionInterface $session The current session.
     * @param Request $request The HTTP request object.
     *
     * @return Response Redirects to the play route or back to bet on error.
     */
    #[Route('/proj/bet', name: 'enter_bet_post', methods: ['POST'])]
    public function blackJackInit(SessionInterface $session, Request $request, GameBlackJackService $gameService, GameBlackJackValidateService $gameValidate): Response
    {
        // Extract and validate input from POST using service
        $input = $gameValidate->validateInput($request->request->all());
        if (is_string($input)) {
            $this->addFlash('danger', $input);
            return $this->redirectToRoute('enter_bet');
        }

        $playerName = $input['playerName'];
        $betAmount = (int) $input['betAmount'];
        $numHands = (int) $input['numHands'];

        // Preserve existing balance or init to 1000
        $existingGame = $session->get('blackJack');

        if (!$existingGame instanceof \App\Card\BlackJack) {
            $existingGame = null;
        }

        // Validate bet against current balance and number of hands
        $error = $gameValidate->validateBet($existingGame, $betAmount, $numHands);
        if ($error) {
            $this->addFlash('danger', 'Your bet exceeds the available balance.');
            return $this->redirectToRoute('enter_bet');
        }

        $blackJack = $gameService->initOrCreate($existingGame, $playerName, $betAmount, $numHands);

        // Store game in session
        $session->set('playerName', $playerName);
        $session->set('blackJack', $blackJack);

        return $this->redirectToRoute('proj_play');
    }

    /**
     * Handle the display of the blackJack play page.
     *
     * @param SessionInterface $session Session to store blackJack state.
     *
     * @return Response Renders the blackJack play Twig template.
     */
    #[Route("/proj/play", name: "proj_play", methods: ["GET"])]
    public function playBlackJack(SessionInterface $session): Response
    {
        $blackJack = $this->getBlackJackOrRedirect($session);
        if (!$blackJack) {
            return $this->redirectToRoute('enter_bet');
        }

        return $this->render('proj/play.html.twig', [
            'blackJack' => $blackJack,
            'gameOver' => false,
            'results' => $blackJack->getResults(),
            'playerHands' => $blackJack->getPlayerHands(),
            'currentHand' => $blackJack->getCurrentHand(),
            'bankHand' => $blackJack->getBankHand(),
            'balance' => $blackJack->getBalance(),
        ]);
    }

    /**
     * Handle the blackJack play.
     *
     * @param SessionInterface $session Session to store blackJack state.
     *
     * @return Response Renders the blackJack play Twig template.
     * @throws RuntimeException if the stored session blackJack object is invalid.
     */
    #[Route("/proj/play", name: "proj_play_post", methods: ["POST"])]
    public function handlePlayer(SessionInterface $session, Request $request, GameBlackJackService $gameService): Response
    {
        $blackJack = $session->get('blackJack');

        if (!$blackJack instanceof BlackJack) {
            throw new RuntimeException("Invalid blackJack instance in session");
        }

        // Get the action by the player (draw or stay)
        $action = $request->get("action");

        if (!is_string($action)) {
            $action = '';
        }

        // Process player action
        $blackJack = $gameService->processAction($blackJack, $action);

        $session->set('blackJack', $blackJack);

        return $this->render('proj/play.html.twig', [
            'blackJack' => $blackJack,
            'gameOver' => $blackJack->isGameOver(),
            'results' => $blackJack->getResults(),
            'playerHands' => $blackJack->getPlayerHands(),
            'currentHand' => $blackJack->getCurrentHand(),
            'bankHand' => $blackJack->getBankHand(),
            'balance' => $blackJack->getBalance(),
        ]);
    }

    /**
     * Handle request to start a new game round with a new bet.
     *
     * @param SessionInterface $session Current session.
     * @param Request $request POST request containing the bet.
     * @param GameBlackJackService $gameService Logic handler for game creation.
     *
     * @return Response Redirect to play or round view depending on bet validity.
     */
    #[Route("/proj/newround", name: "proj_new_round", methods: ['POST'])]
    public function newRound(SessionInterface $session, Request $request, GameBlackJackService $gameService, GameBlackJackValidateService $gameValidate): Response
    {
        $blackJack = $this->getBlackJackOrRedirect($session);
        if (!$blackJack) {
            return $this->redirectToRoute('enter_bet');
        }

        $betAmount = (int) $request->request->get('betAmount');
        $numHands = (int) $request->request->get('numHands', 1);

        // Validate bet
        $error = $gameValidate->validateBet($blackJack, $betAmount, $numHands);
        if ($error) {
            $this->addFlash('danger', $error);
            return $this->redirectToRoute('proj_round');
        }

        $newGame = $gameService->newRound($blackJack, $betAmount, $numHands);
        $session->set('blackJack', $newGame);

        return $this->redirectToRoute('proj_play');
    }

    /**
     * Display the round start page where the player enters a new bet.
     *
     * @param SessionInterface $session Current session.
     *
     * @return Response Renders the round view or redirects if no balance.
     */
    #[Route("/proj/round", name: "proj_round", methods: ['GET'])]
    public function round(SessionInterface $session): Response
    {
        $blackJack = $this->getBlackJackOrRedirect($session);
        if (!$blackJack) {
            return $this->redirectToRoute('enter_bet');
        }

        if ($blackJack->getBalance() <= 0) {
            return $this->redirectToRoute('proj_game_over');
        }

        return $this->render('proj/round.html.twig', [
            'blackJack' => $blackJack,
        ]);
    }

    /**
     * Helper to get a valid BlackJack game from session or return null.
     *
     * @param SessionInterface $session Current session.
     * @return BlackJack|null The game instance if valid, otherwise null.
     */
    private function getBlackJackOrRedirect(SessionInterface $session): ?BlackJack
    {
        $blackJack = $session->get('blackJack');
        if (!$blackJack instanceof BlackJack) {
            return null;
        }
        return $blackJack;
    }
}


1			<?php
2
3			namespace App\Controller;
4
5			use App\Card\BlackJack;
6			use App\Service\GameBlackJackService;
7			use App\Service\GameBlackJackValidateService;
8			use Symfony\Component\HttpFoundation\Session\SessionInterface;
9			use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
10			use Symfony\Component\HttpFoundation\Request;
11			use Symfony\Component\HttpFoundation\Response;
12			use Symfony\Component\Routing\Annotation\Route;
13			use Symfony\Component\Yaml\Exception\RuntimeException;
14
15			/**
16			* BlackJack Controller.
17			*/
18			final class BlackJackController extends AbstractController
19			{
20			/**
21			* Init the BlackJack game after bet is submitted.
22			*
23			* @param SessionInterface $session The current session.
24			* @param Request $request The HTTP request object.
25			*
26			* @return Response Redirects to the play route or back to bet on error.
27			*/
28			#[Route('/proj/bet', name: 'enter_bet_post', methods: ['POST'])]
29			public function blackJackInit(SessionInterface $session, Request $request, GameBlackJackService $gameService, GameBlackJackValidateService $gameValidate): Response
30			{
31			// Extract and validate input from POST using service
32			$input = $gameValidate->validateInput($request->request->all());
33			if (is_string($input)) {
34			$this->addFlash('danger', $input);
35			return $this->redirectToRoute('enter_bet');
36			}
37
38			$playerName = $input['playerName'];
39			$betAmount = (int) $input['betAmount'];
40			$numHands = (int) $input['numHands'];
41
42			// Preserve existing balance or init to 1000
43			$existingGame = $session->get('blackJack');
44
45			if (!$existingGame instanceof \App\Card\BlackJack) {
46			$existingGame = null;
47			}
48
49			// Validate bet against current balance and number of hands
50			$error = $gameValidate->validateBet($existingGame, $betAmount, $numHands);
51			if ($error) {
52			$this->addFlash('danger', 'Your bet exceeds the available balance.');
53			return $this->redirectToRoute('enter_bet');
54			}
55
56			$blackJack = $gameService->initOrCreate($existingGame, $playerName, $betAmount, $numHands);
57
58			// Store game in session
59			$session->set('playerName', $playerName);
60			$session->set('blackJack', $blackJack);
61
62			return $this->redirectToRoute('proj_play');
63			}
64
65			/**
66			* Handle the display of the blackJack play page.
67			*
68			* @param SessionInterface $session Session to store blackJack state.
69			*
70			* @return Response Renders the blackJack play Twig template.
71			*/
72			#[Route("/proj/play", name: "proj_play", methods: ["GET"])]
73			public function playBlackJack(SessionInterface $session): Response
74			{
75			$blackJack = $this->getBlackJackOrRedirect($session);
76			if (!$blackJack) {
77			return $this->redirectToRoute('enter_bet');
78			}
79
80			return $this->render('proj/play.html.twig', [
81			'blackJack' => $blackJack,
82			'gameOver' => false,
83			'results' => $blackJack->getResults(),
84			'playerHands' => $blackJack->getPlayerHands(),
85			'currentHand' => $blackJack->getCurrentHand(),
86			'bankHand' => $blackJack->getBankHand(),
87			'balance' => $blackJack->getBalance(),
88			]);
89			}
90
91			/**
92			* Handle the blackJack play.
93			*
94			* @param SessionInterface $session Session to store blackJack state.
95			*
96			* @return Response Renders the blackJack play Twig template.
97			* @throws RuntimeException if the stored session blackJack object is invalid.
98			*/
99			#[Route("/proj/play", name: "proj_play_post", methods: ["POST"])]
100			public function handlePlayer(SessionInterface $session, Request $request, GameBlackJackService $gameService): Response
101			{
102			$blackJack = $session->get('blackJack');
103
104			if (!$blackJack instanceof BlackJack) {
105			throw new RuntimeException("Invalid blackJack instance in session");
106			}
107
108			// Get the action by the player (draw or stay)
109			$action = $request->get("action");
110
111			if (!is_string($action)) {
112			$action = '';
113			}
114
115			// Process player action
116			$blackJack = $gameService->processAction($blackJack, $action);
117
118			$session->set('blackJack', $blackJack);
119
120			return $this->render('proj/play.html.twig', [
121			'blackJack' => $blackJack,
122			'gameOver' => $blackJack->isGameOver(),
123			'results' => $blackJack->getResults(),
124			'playerHands' => $blackJack->getPlayerHands(),
125			'currentHand' => $blackJack->getCurrentHand(),
126			'bankHand' => $blackJack->getBankHand(),
127			'balance' => $blackJack->getBalance(),
128			]);
129			}
130
131			/**
132			* Handle request to start a new game round with a new bet.
133			*
134			* @param SessionInterface $session Current session.
135			* @param Request $request POST request containing the bet.
136			* @param GameBlackJackService $gameService Logic handler for game creation.
137			*
138			* @return Response Redirect to play or round view depending on bet validity.
139			*/
140			#[Route("/proj/newround", name: "proj_new_round", methods: ['POST'])]
141			public function newRound(SessionInterface $session, Request $request, GameBlackJackService $gameService, GameBlackJackValidateService $gameValidate): Response
142			{
143			$blackJack = $this->getBlackJackOrRedirect($session);
144			if (!$blackJack) {
145			return $this->redirectToRoute('enter_bet');
146			}
147
148			$betAmount = (int) $request->request->get('betAmount');
149			$numHands = (int) $request->request->get('numHands', 1);
150
151			// Validate bet
152			$error = $gameValidate->validateBet($blackJack, $betAmount, $numHands);
153			if ($error) {
154			$this->addFlash('danger', $error);
155			return $this->redirectToRoute('proj_round');
156			}
157
158			$newGame = $gameService->newRound($blackJack, $betAmount, $numHands);
159			$session->set('blackJack', $newGame);
160
161			return $this->redirectToRoute('proj_play');
162			}
163
164			/**
165			* Display the round start page where the player enters a new bet.
166			*
167			* @param SessionInterface $session Current session.
168			*
169			* @return Response Renders the round view or redirects if no balance.
170			*/
171			#[Route("/proj/round", name: "proj_round", methods: ['GET'])]
172			public function round(SessionInterface $session): Response
173			{
174			$blackJack = $this->getBlackJackOrRedirect($session);
175			if (!$blackJack) {
176			return $this->redirectToRoute('enter_bet');
177			}
178
179			if ($blackJack->getBalance() <= 0) {
180			return $this->redirectToRoute('proj_game_over');
181			}
182
183			return $this->render('proj/round.html.twig', [
184			'blackJack' => $blackJack,
185			]);
186			}
187
188			/**
189			* Helper to get a valid BlackJack game from session or return null.
190			*
191			* @param SessionInterface $session Current session.
192			* @return BlackJack\|null The game instance if valid, otherwise null.
193			*/
194			private function getBlackJackOrRedirect(SessionInterface $session): ?BlackJack
195			{
196			$blackJack = $session->get('blackJack');
197			if (!$blackJack instanceof BlackJack) {
198			return null;
199			}
200			return $blackJack;
201			}
202			}
203

Veddan12 / mvc

Push — main ( a57e19...f52e71 )

BlackJackController::playBlackJack() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like