Vectorface\Tests\Auth\AuthTest

Complexity

Total Complexity

12

Size/Duplication

Total Lines	137
Duplicated Lines	10.95 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	8	1
A	testNothingDoesNothing()	7	7	1
A	testSuccess()	7	7	1
A	testLogin()	0	6	1
A	testForce()	0	10	1
A	testArrayAccess()	0	9	1
A	testFunctionPassthrough()	0	17	2
A	testAddPlugin()	0	7	1
A	testEdgeCases()	0	31	3

<?php

namespace Vectorface\Tests\Auth;

use Vectorface\Auth\Auth;
use Vectorface\Auth\AuthException;
use Vectorface\Auth\Plugin\SuccessPlugin;
use Vectorface\Auth\Plugin\NullPlugin;
use Monolog\Logger;
use Monolog\Handler\NullHandler;
use SplFixedArray;
use Exception;
use PHPUnit\Framework\TestCase;
use Vectorface\Tests\Auth\Helpers\HardcodedUserPlugin;
use Vectorface\Tests\Auth\Helpers\TestPlugin;

class AuthTest extends TestCase
{
    /**
     * @var Auth
     */
    private $auth;

    protected function setUp()
    {
        $logger = new Logger('auth');
        $logger->pushHandler(new NullHandler());

        $this->auth = new Auth();
        $this->auth->setLogger($logger);
    }

    /**
     * @throws AuthException
     */
    public function testNothingDoesNothing()

This method seems to be duplicated in your project.

    {
        $this->assertTrue($this->auth->addPlugin(new NullPlugin()));
        $this->assertFalse($this->auth->login('a', 'b'));
        $this->assertFalse($this->auth->verify());
        $this->assertFalse($this->auth->logout());
    }

    /**
     * @throws AuthException
     */
    public function testSuccess()

This method seems to be duplicated in your project.

    {
        $this->assertTrue($this->auth->addPlugin(new SuccessPlugin()));
        $this->assertTrue($this->auth->login('a', 'b'));
        $this->assertTrue($this->auth->verify());
        $this->assertTrue($this->auth->logout());
    }

    /**
     * @throws AuthException
     */
    public function testLogin()
    {
        $this->assertTrue($this->auth->addPlugin(new HardcodedUserPlugin()));
        $this->assertFalse($this->auth->login('u', 'p'));
        $this->assertTrue($this->auth->login('foo', 'bar'));
    }

    /**
     * @throws AuthException
     */
    public function testForce()
    {
        $testFail = new TestPlugin();
        $testForce = new TestPlugin();
        $testFail->setResult(Auth::RESULT_FAILURE);
        $testForce->setResult(Auth::RESULT_FORCE);
        $this->assertTrue($this->auth->addPlugin($testForce)); // Force before fail.
        $this->assertTrue($this->auth->addPlugin($testFail));
        $this->assertTrue($this->auth->verify());
    }

    public function testArrayAccess()
    {
        $this->assertArrayNotHasKey('foo', $this->auth); // offsetExists
        $this->assertNull($this->auth['foo']); // offsetGet
        $this->auth['foo'] = 'bar'; // offsetSet
        $this->assertEquals('bar', $this->auth['foo']); // offsetGet
        unset($this->auth['foo']); // offsetUnset
        $this->assertNull($this->auth['foo']); // offsetGet
    }

    /**
     * @noinspection PhpUndefinedMethodInspection
     * @noinspection PhpRedundantCatchClauseInspection
     */
    public function testFunctionPassthrough()
    {
        $test = new TestPlugin();
        $this->auth->addPlugin($test);

        $this->assertEquals($this->auth, $test->getAuthObject());
        $this->assertTrue($this->auth->returnTrue());

The method returnTrue does not exist on object<Vectorface\Auth\Auth>? Since you implemented __call, maybe consider adding a @method annotation.

        try {
            $this->assertNull($this->auth->throwAuthException());

The method throwAuthException does not exist on object<Vectorface\Auth\Auth>? Since you implemented __call, maybe consider adding a @method annotation.

            $this->fail('Expected to pass up the AuthException');
        } catch (AuthException $e) {
            // Expected
        }
        $this->assertNull($this->auth->throwException()); // Gets caught and causes action failure.

The method throwException does not exist on object<Vectorface\Auth\Auth>? Since you implemented __call, maybe consider adding a @method annotation.

        $this->assertNull($this->auth->notDefined()); // Method not implemented

The method notDefined does not exist on object<Vectorface\Auth\Auth>? Since you implemented __call, maybe consider adding a @method annotation.

    }

    public function testAddPlugin()
    {
        $this->assertTrue($this->auth->addPlugin(new TestPlugin()));
        $this->assertFalse($this->auth->addPlugin(new SplFixedArray()), 'Not an Auth plugin');
        $this->assertFalse($this->auth->addPlugin('SplFixedArray'), 'Not an Auth plugin');
        $this->assertFalse($this->auth->addPlugin(1.2), 'Not an Auth plugin');
    }

    /**
     * @throws AuthException
     */
    public function testEdgeCases()
    {
        $test = new TestPlugin();
        $this->auth->addPlugin($test);
        $test->setResult(new SplFixedArray()); // This isn't a valid result.

        try {
            $this->auth->login('u', 'p');
            $this->fail("An invalid result should have triggered an AuthException");
        } catch (AuthException $e) {
            // Expected
        }

        $this->setUp();
        $this->assertTrue($this->auth->addPlugin('Vectorface\\Auth\\Plugin\\SuccessPlugin'));
        $this->auth->addPlugin($test);
        $test->setResult(new Exception("Exception added on purpose by test case.")); // Causes a log entry and failure.
        $this->assertFalse($this->auth->verify());

        $test->setResult(new AuthException());
        try {
            $this->auth->verify();
            $this->fail("Expected AuthException to be passed up.");
        } catch (AuthException $e) {
            // Expected
        }

        /* Loading by class name should work. */
        $this->assertTrue($this->auth->addPlugin('Vectorface\\Auth\\Plugin\\SuccessPlugin'));
        $this->assertFalse($this->auth->addPlugin(new SplFixedArray())); // Fails for obvious reasons.
    }
}