RouterHeaderPlugin::afterHandlerSelected() - Code Metrics - Inspection of "WIP: Add support for an input stream to HttpReques..." - Vectorface/SnappyRouter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — dev (#11)

unknown

created 2016-06-24 18:53 UTC

RouterHeaderPlugin::afterHandlerSelected() A

↳ Parent: RouterHeaderPlugin

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	5
ccs	4
cts	4
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php

namespace Vectorface\SnappyRouter\Plugin\HttpHeader;

use Vectorface\SnappyRouter\Handler\AbstractHandler;
use Vectorface\SnappyRouter\Plugin\AbstractPlugin;

/**
 * A plugin that adds an HTTP header to indicate the route passed through the service router.
 * @copyright Copyright (c) 2014, VectorFace, Inc.
 * @author Dan Bruce <[email protected]>
 */
class RouterHeaderPlugin extends AbstractPlugin
{
    /**
     * Invoked directly after the router decides which handler will be used.
     * @param AbstractHandler $handler The handler selected by the router.
     */
    public function afterHandlerSelected(AbstractHandler $handler)
    {
        parent::afterhandlerSelected($handler);
        @header('X-Router: SnappyRouter');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    }
}


1		<?php
2
3		namespace Vectorface\SnappyRouter\Plugin\HttpHeader;
4
5		use Vectorface\SnappyRouter\Handler\AbstractHandler;
6		use Vectorface\SnappyRouter\Plugin\AbstractPlugin;
7
8		/**
9		* A plugin that adds an HTTP header to indicate the route passed through the service router.
10		* @copyright Copyright (c) 2014, VectorFace, Inc.
11		* @author Dan Bruce <[email protected]>
12		*/
13		class RouterHeaderPlugin extends AbstractPlugin
14		{
15		/**
16		* Invoked directly after the router decides which handler will be used.
17		* @param AbstractHandler $handler The handler selected by the router.
18		*/
19	1	public function afterHandlerSelected(AbstractHandler $handler)
20		{
21	1	parent::afterhandlerSelected($handler);
22	1	@header('X-Router: SnappyRouter');
		0 ignored issues – show Security Best Practice introduced 2016-04-26 14:02 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
23	1	}
24		}
25

Vectorface / SnappyRouter

Pull Request — dev (#11)

RouterHeaderPlugin::afterHandlerSelected() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like