HttpBasicAuthenticationPluginTest - Code Metrics - Inspection of "WIP: Add support for an input stream to HttpReques..." - Vectorface/SnappyRouter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — dev (#11)

unknown

created 2016-06-24 18:53 UTC

HttpBasicAuthenticationPluginTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
wmc	4
c	3
b	0
f	0
lcom	1
cbo	7
dl	0
loc	56
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
B	testBasicHTTPAuth()	0	50	4

<?php

namespace casino\Tests\engine\ServiceRouter\Plugin\Authentication;

use \PHPUnit_Framework_TestCase;
use Vectorface\SnappyRouter\Authentication\CallbackAuthenticator;
use Vectorface\SnappyRouter\Di\Di;
use Vectorface\SnappyRouter\Exception\InternalErrorException;
use Vectorface\SnappyRouter\Exception\UnauthorizedException;
use Vectorface\SnappyRouter\Handler\ControllerHandler;
use Vectorface\SnappyRouter\Plugin\Authentication\HttpBasicAuthenticationPlugin;

/**
 * Test for the HttpBasicAuthenticationPlugin class.
 * @copyright Copyright (c) 2014, VectorFace, Inc.
 * @author J. Anderson <[email protected]>
 * @author Dan Bruce   <[email protected]>
 */
class HttpBasicAuthenticationPluginTest extends PHPUnit_Framework_TestCase
{
    /**
     * Test the HTTPBasicAuthenticationPlugin; All in one test!
     */
    public function testBasicHTTPAuth()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $ignored = new ControllerHandler(array());

        /* Configure DI */
        $di = new Di(array('MyCustomAuth' => false));
        Di::setDefault($di);

        /* Direct testing. */
        $plugin = new HttpBasicAuthenticationPlugin(array(
            'AuthMechanism' => 'MyCustomAuth',
            'realm' => 'Authentication Test'
        ));

        try {
            $plugin->afterHandlerSelected($ignored);
            $this->fail("An invalid authenticator should yield an internal error");
        } catch (InternalErrorException $e) {
            $this->assertEquals(500, $e->getAssociatedStatusCode()); /* HTTP 500 ISE */
        }

        /* From here on out, use the "Do whatever I say" authenticator. :) */
        $bool = false;
        $auth = new CallbackAuthenticator(function () use (&$bool) {
            return $bool;
        });
        $di->set('MyCustomAuth', $auth);


        $_SERVER['PHP_AUTH_USER'] = $_SERVER['PHP_AUTH_PW'] = null;
        try {
            $plugin->afterHandlerSelected($ignored);
            $this->fail("No username and password are available. UnauthorizedException expected.");
        } catch (UnauthorizedException $e) {
            $this->assertEquals(401, $e->getAssociatedStatusCode()); /* HTTP 401 Unauthorized */
        }

        $_SERVER['PHP_AUTH_USER'] = $_SERVER['PHP_AUTH_PW'] = 'ignored';
        try {
            $plugin->afterHandlerSelected($ignored);
            $this->fail("Callback expected to return false auth result. UnauthorizedException expected.");
        } catch (UnauthorizedException $e) {
            // we expect the exception to be thrown
        }

        /* With a true result, preInvoke should pass through. */
        $bool = true;
        $this->assertTrue($bool);
        $plugin->afterHandlerSelected($ignored);
    }
}


1			<?php
2
3			namespace casino\Tests\engine\ServiceRouter\Plugin\Authentication;
4
5			use \PHPUnit_Framework_TestCase;
6			use Vectorface\SnappyRouter\Authentication\CallbackAuthenticator;
7			use Vectorface\SnappyRouter\Di\Di;
8			use Vectorface\SnappyRouter\Exception\InternalErrorException;
9			use Vectorface\SnappyRouter\Exception\UnauthorizedException;
10			use Vectorface\SnappyRouter\Handler\ControllerHandler;
11			use Vectorface\SnappyRouter\Plugin\Authentication\HttpBasicAuthenticationPlugin;
12
13			/**
14			* Test for the HttpBasicAuthenticationPlugin class.
15			* @copyright Copyright (c) 2014, VectorFace, Inc.
16			* @author J. Anderson <[email protected]>
17			* @author Dan Bruce <[email protected]>
18			*/
19			class HttpBasicAuthenticationPluginTest extends PHPUnit_Framework_TestCase
20			{
21			/**
22			* Test the HTTPBasicAuthenticationPlugin; All in one test!
23			*/
24			public function testBasicHTTPAuth()
			0 ignored issues – show Coding Style introduced 2016-04-26 14:02 UTC by Report Bug Copy Issue Report `testBasicHTTPAuth` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
25			{
26			$ignored = new ControllerHandler(array());
27
28			/* Configure DI */
29			$di = new Di(array('MyCustomAuth' => false));
30			Di::setDefault($di);
31
32			/* Direct testing. */
33			$plugin = new HttpBasicAuthenticationPlugin(array(
34			'AuthMechanism' => 'MyCustomAuth',
35			'realm' => 'Authentication Test'
36			));
37
38			try {
39			$plugin->afterHandlerSelected($ignored);
40			$this->fail("An invalid authenticator should yield an internal error");
41			} catch (InternalErrorException $e) {
42			$this->assertEquals(500, $e->getAssociatedStatusCode()); /* HTTP 500 ISE */
43			}
44
45			/* From here on out, use the "Do whatever I say" authenticator. :) */
46			$bool = false;
47			$auth = new CallbackAuthenticator(function () use (&$bool) {
48			return $bool;
49			});
50			$di->set('MyCustomAuth', $auth);
51
52
53			$_SERVER['PHP_AUTH_USER'] = $_SERVER['PHP_AUTH_PW'] = null;
54			try {
55			$plugin->afterHandlerSelected($ignored);
56			$this->fail("No username and password are available. UnauthorizedException expected.");
57			} catch (UnauthorizedException $e) {
58			$this->assertEquals(401, $e->getAssociatedStatusCode()); /* HTTP 401 Unauthorized */
59			}
60
61			$_SERVER['PHP_AUTH_USER'] = $_SERVER['PHP_AUTH_PW'] = 'ignored';
62			try {
63			$plugin->afterHandlerSelected($ignored);
64			$this->fail("Callback expected to return false auth result. UnauthorizedException expected.");
65			} catch (UnauthorizedException $e) {
66			// we expect the exception to be thrown
67			}
68
69			/* With a true result, preInvoke should pass through. */
70			$bool = true;
71			$this->assertTrue($bool);
72			$plugin->afterHandlerSelected($ignored);
73			}
74			}
75

Vectorface / SnappyRouter

Pull Request — dev (#11)

HttpBasicAuthenticationPluginTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like