VectorNetworkProject\TheMix\provider\JSON

Complexity

Total Complexity

14

Size/Duplication

Total Lines	131
Duplicated Lines	6.11 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	init()	0	6	2
A	createTable()	0	7	1
A	hasTable()	0	6	2
A	deleteTable()	0	4	1
A	set()	0	6	1
A	get()	0	6	1
A	getAll()	0	6	1
A	getKeys()	0	6	1
A	exists()	8	8	2
A	remove()	0	5	1

<?php
/**
 * Copyright (c) 2018 VectorNetworkProject. All rights reserved. MIT license.
 *
 * GitHub: https://github.com/VectorNetworkProject/TheMix
 * Website: https://www.vector-network.tk
 */

namespace VectorNetworkProject\TheMix\provider;

use pocketmine\utils\Config;
use pocketmine\utils\MainLogger;
use VectorNetworkProject\TheMix\lib\database\Provider;

class JSON extends Provider
{
    /* @var string $path */
    private $path;

    /* @var string $file */
    private $file;

    /**
     * JSON constructor.
     *
     * @param string $xuid
     * @param string $file
     */
    public function __construct(string $xuid, string $file)
    {
        $this->path = self::getPath('datas', 'json').$xuid.'/';
        $this->file = $file.'.json';
    }

    /**
     * @param array $data
     */
    public function init(array $data = []): void
    {
        if (!$this->hasTable()) {
            $this->createTable($data);
        }
    }

    /**
     * @param array $table
     *
     * @return void
     */
    public function createTable(array $table = []): void
    {
        @mkdir($this->path, 0755, true);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $config = new Config($this->path.$this->file, Config::JSON, $table);
        $config->save();
        MainLogger::getLogger()->debug('[PROVIDER] Create '.$this->file);
    }

    /**
     * @return bool
     */
    public function hasTable(): bool
    {
        return file_exists($this->path.$this->file)
            ? true
            : false;
    }

    /**
     * @return void
     */
    public function deleteTable(): void
    {
        unlink($this->path.$this->file);
    }

    /**
     * @param string     $key
     * @param bool|mixed $data
     *
     * @return void
     */
    public function set(string $key, $data): void
    {
        $config = new Config($this->path.$this->file, Config::JSON);
        $config->set($key, $data);
        $config->save();
    }

    /**
     * @param string $key
     *
     * @return bool|mixed
     */
    public function get(string $key)
    {
        $config = new Config($this->path.$this->file, Config::JSON);

        return $config->get($key);
    }

    /**
     * @return array
     */
    public function getAll(): array
    {
        $config = new Config($this->path.$this->file, Config::JSON);

        return $config->getAll();
    }

    /**
     * @return array
     */
    public function getKeys(): array
    {
        $config = new Config($this->path.$this->file, Config::JSON);

        return $config->getAll(true);
    }

    /**
     * @param string $key
     *
     * @return bool
     */
    public function exists(string $key): bool

This method seems to be duplicated in your project.

function exists() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

    {
        $config = new Config($this->path.$this->file, Config::JSON);

        return $config->exists($key)
            ? true
            : false;
    }

    /**
     * @param string $key
     *
     * @return void
     */
    public function remove(string $key): void
    {
        $config = new Config($this->path.$this->file, Config::JSON);
        $config->remove($key);
    }
}