UserController::save() - Code Metrics - Inspection of "VSVGVQ-10 Merge branch 'master' into feature/VSVGV..." - VSVverkeerskunde/gvq-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/VSVGVQ-10 ( 87eafe...479e8b )

by Luc

created 2018-05-29 20:32 UTC

UserController::save() A

↳ Parent: UserController

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	1

<?php declare(strict_types=1);

namespace VSV\GVQ_API\User\Controllers;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Serializer\SerializerInterface;
use VSV\GVQ_API\User\Models\User;
use VSV\GVQ_API\User\Repositories\UserRepository;

class UserController
{
    /**
     * @var UserRepository
     */
    private $userRepository;

    /**
     * @var SerializerInterface
     */
    private $userSerializer;

    /**
     * @param UserRepository $userRepository
     * @param SerializerInterface $userSerializer
     */
    public function __construct(
        UserRepository $userRepository,
        SerializerInterface $userSerializer
    ) {
        $this->userRepository = $userRepository;
        $this->userSerializer = $userSerializer;
    }

    // TODO: This method is not needed, can be refactored to update which is needed.
    /**
     * @param Request $request
     * @return Response
     */
    public function save(Request $request): Response
    {
        $json = $request->getContent();
        /** @var User $user */
        $user = $this->userSerializer->deserialize($json, User::class, 'json');
        $this->userRepository->save($user);

        $response = new Response('{"id":"'.$user->getId()->toString().'"}');
        $response->headers->set('Content-Type', 'application/json');

        return $response;
    }
}


1			<?php declare(strict_types=1);
2
3			namespace VSV\GVQ_API\User\Controllers;
4
5			use Symfony\Component\HttpFoundation\Request;
6			use Symfony\Component\HttpFoundation\Response;
7			use Symfony\Component\Serializer\SerializerInterface;
8			use VSV\GVQ_API\User\Models\User;
9			use VSV\GVQ_API\User\Repositories\UserRepository;
10
11			class UserController
12			{
13			/**
14			* @var UserRepository
15			*/
16			private $userRepository;
17
18			/**
19			* @var SerializerInterface
20			*/
21			private $userSerializer;
22
23			/**
24			* @param UserRepository $userRepository
25			* @param SerializerInterface $userSerializer
26			*/
27			public function __construct(
28			UserRepository $userRepository,
29			SerializerInterface $userSerializer
30			) {
31			$this->userRepository = $userRepository;
32			$this->userSerializer = $userSerializer;
33			}
34
35			// TODO: This method is not needed, can be refactored to update which is needed.
36			/**
37			* @param Request $request
38			* @return Response
39			*/
40			public function save(Request $request): Response
41			{
42			$json = $request->getContent();
43			/** @var User $user */
44			$user = $this->userSerializer->deserialize($json, User::class, 'json');
45			$this->userRepository->save($user);
46
47			$response = new Response('{"id":"'.$user->getId()->toString().'"}');
48			$response->headers->set('Content-Type', 'application/json');
49
50			return $response;
51			}
52			}
53

VSVverkeerskunde / gvq-api

Push — feature/VSVGVQ-10 ( 87eafe...479e8b )

UserController::save() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like