QuestionJsonEnricher::enrich() - Code Metrics - Inspection of "VSVGVQ-38 Cleanup QuestionController." - VSVverkeerskunde/gvq-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Luc

created 2018-05-30 11:45 UTC

QuestionJsonEnricher::enrich() A

↳ Parent: QuestionJsonEnricher

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1

<?php declare(strict_types=1);

namespace VSV\GVQ_API\Question\Serializers;

use Ramsey\Uuid\UuidFactoryInterface;
use VSV\GVQ_API\Common\Serializers\JsonEnricher;

class QuestionJsonEnricher implements JsonEnricher
{
    /**
     * @var UuidFactoryInterface
     */
    private $uuidFactory;

    /**
     * @param UuidFactoryInterface $uuidFactory
     */
    public function __construct(UuidFactoryInterface $uuidFactory)
    {
        $this->uuidFactory = $uuidFactory;
    }

    /**
     * @param string $json
     * @return string
     */
    public function enrich(string $json): string
    {
        $questionAsArray = json_decode($json, true);

        $questionAsArray['id'] = $this->uuidFactory->uuid4()->toString();

        for ($index = 0; $index < count($questionAsArray['answers']); $index++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $questionAsArray['answers'][$index]['id'] = $this->uuidFactory->uuid4()->toString();
        }

        return json_encode($questionAsArray);
    }
}


1			<?php declare(strict_types=1);
2
3			namespace VSV\GVQ_API\Question\Serializers;
4
5			use Ramsey\Uuid\UuidFactoryInterface;
6			use VSV\GVQ_API\Common\Serializers\JsonEnricher;
7
8			class QuestionJsonEnricher implements JsonEnricher
9			{
10			/**
11			* @var UuidFactoryInterface
12			*/
13			private $uuidFactory;
14
15			/**
16			* @param UuidFactoryInterface $uuidFactory
17			*/
18			public function __construct(UuidFactoryInterface $uuidFactory)
19			{
20			$this->uuidFactory = $uuidFactory;
21			}
22
23			/**
24			* @param string $json
25			* @return string
26			*/
27			public function enrich(string $json): string
28			{
29			$questionAsArray = json_decode($json, true);
30
31			$questionAsArray['id'] = $this->uuidFactory->uuid4()->toString();
32
33			for ($index = 0; $index < count($questionAsArray['answers']); $index++) {
			0 ignored issues – show Performance Best Practice introduced 2018-05-30 07:15 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
34			$questionAsArray['answers'][$index]['id'] = $this->uuidFactory->uuid4()->toString();
35			}
36
37			return json_encode($questionAsArray);
38			}
39			}
40

VSVverkeerskunde / gvq-api

Pull Request — master (#14)

QuestionJsonEnricher::enrich() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like