QuestionController::save() - Code Metrics - Inspection of "VSVGVQ-7: add POST endpoint for questions" - VSVverkeerskunde/gvq-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/VSVGVQ-7 ( 2c37c2...dd7336 )

by steven

created 2018-05-15 15:28 UTC

QuestionController::save() A

↳ Parent: QuestionController

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	1
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace VSV\GVQ_API\Question\Controllers;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use VSV\GVQ_API\Question\Models\Question;
use VSV\GVQ_API\Question\Repositories\QuestionRepository;
use VSV\GVQ_API\Question\Serializers\QuestionSerializer;

class QuestionController
{
    /**
     * @var QuestionRepository
     */
    private $questionRepository;

    /**
     * @var QuestionSerializer
     */
    private $questionSerializer;

    /**
     * @param QuestionRepository $questionRepository
     * @param QuestionSerializer $questionSerializer
     */
    public function __construct(
        QuestionRepository $questionRepository,
        QuestionSerializer $questionSerializer
    ) {
        $this->questionRepository = $questionRepository;
        $this->questionSerializer = $questionSerializer;
    }

    /**
     * @param Request $request
     * @return Response
     */
    public function save(Request $request): Response
    {
        $json = $request->getContent();
        /** @var Question $question */
        $question = $this->questionSerializer->deserialize($json, Question::class, 'json');
        $this->questionRepository->save($question);

        return new Response('Succeeded');
    }
}


1			<?php declare(strict_types=1);
2
3			namespace VSV\GVQ_API\Question\Controllers;
4
5			use Symfony\Component\HttpFoundation\Request;
6			use Symfony\Component\HttpFoundation\Response;
7			use VSV\GVQ_API\Question\Models\Question;
8			use VSV\GVQ_API\Question\Repositories\QuestionRepository;
9			use VSV\GVQ_API\Question\Serializers\QuestionSerializer;
10
11			class QuestionController
12			{
13			/**
14			* @var QuestionRepository
15			*/
16			private $questionRepository;
17
18			/**
19			* @var QuestionSerializer
20			*/
21			private $questionSerializer;
22
23			/**
24			* @param QuestionRepository $questionRepository
25			* @param QuestionSerializer $questionSerializer
26			*/
27			public function __construct(
28			QuestionRepository $questionRepository,
29			QuestionSerializer $questionSerializer
30			) {
31			$this->questionRepository = $questionRepository;
32			$this->questionSerializer = $questionSerializer;
33			}
34
35			/**
36			* @param Request $request
37			* @return Response
38			*/
39			public function save(Request $request): Response
40			{
41			$json = $request->getContent();
42			/** @var Question $question */
43			$question = $this->questionSerializer->deserialize($json, Question::class, 'json');
44			$this->questionRepository->save($question);
45
46			return new Response('Succeeded');
47			}
48			}
49

VSVverkeerskunde / gvq-api

Push — feature/VSVGVQ-7 ( 2c37c2...dd7336 )

QuestionController::save() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like