VIPnytt /
UserAgentParser
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class ExportTest extends \PHPUnit_Framework_TestCase |
||
| 12 | { |
||
| 13 | /** |
||
| 14 | * @dataProvider generateDataForTest |
||
| 15 | * @param string $userAgent |
||
| 16 | * @param array $result |
||
| 17 | */ |
||
| 18 | public function testExport($userAgent, $result) |
||
| 19 | { |
||
| 20 | $parser = new UserAgentParser($userAgent); |
||
| 21 | $this->assertInstanceOf('vipnytt\UserAgentParser', $parser); |
||
| 22 | $this->assertTrue($parser->export() == $result); |
||
| 23 | } |
||
| 24 | |||
| 25 | /** |
||
| 26 | * Generate test data |
||
| 27 | * @return array |
||
| 28 | */ |
||
| 29 | public |
||
| 30 | function generateDataForTest() |
||
| 31 | { |
||
| 32 | return [ |
||
| 33 | [ |
||
| 34 | 'googlebot-news/2.1', |
||
| 35 | [ |
||
| 36 | 'googlebot-news/2.1', |
||
| 37 | 'googlebot-news', |
||
| 38 | 'googlebot', |
||
| 39 | ] |
||
| 40 | ] |
||
| 41 | ]; |
||
| 42 | } |
||
| 43 | } |
||
| 44 |
