CleanParamClient::isListed() - Code Metrics - Inspection of "Refactoring" - VIPnytt/RobotsTxtParser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0-dev ( 2c252e...97b412 )

by Jan-Petter

created 2016-06-05 10:14 UTC

CleanParamClient::isListed() B

↳ Parent: CleanParamClient

Complexity

Conditions	5
Paths	3

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	15
rs	8.8571
cc	5
eloc	9
nc	3
nop	1

<?php
namespace vipnytt\RobotsTxtParser\Client\Directives;

use vipnytt\RobotsTxtParser\Parser\Directives\DirectiveParserCommons;

/**
 * Class CleanParamClient
 *
 * @package vipnytt\RobotsTxtParser\Client\Directives
 */
class CleanParamClient implements ClientInterface
{
    use DirectiveParserCommons;

    /**
     * Clean-param
     * @var string[][]
     */
    private $cleanParam = [];

    /**
     * CleanParamClient constructor.
     *
     * @param string[] $cleanParam
     */
    public function __construct(array $cleanParam)
    {
        $this->cleanParam = $cleanParam;

    }

    /**
     * Check
     *
     * @param  string $url
     * @return bool
     */
    public function isListed($url)
    {
        foreach ($this->cleanParam as $param => $paths) {
            if (
                (
                    mb_stripos($url, "?$param=") ||
                    mb_stripos($url, "&$param=")
                ) &&
                $this->checkPath($url, $paths)
            ) {
                return true;
            }
        }
        return false;
    }

    /**
     * Export
     *
     * @return string[][]
     */
    public function export()
    {
        return $this->cleanParam;
    }
}


1			<?php
2			namespace vipnytt\RobotsTxtParser\Client\Directives;
3
4			use vipnytt\RobotsTxtParser\Parser\Directives\DirectiveParserCommons;
5
6			/**
7			* Class CleanParamClient
8			*
9			* @package vipnytt\RobotsTxtParser\Client\Directives
10			*/
11			class CleanParamClient implements ClientInterface
12			{
13			use DirectiveParserCommons;
14
15			/**
16			* Clean-param
17			* @var string[][]
18			*/
19			private $cleanParam = [];
20
21			/**
22			* CleanParamClient constructor.
23			*
24			* @param string[] $cleanParam
25			*/
26			public function __construct(array $cleanParam)
27			{
28			$this->cleanParam = $cleanParam;
			0 ignored issues – show Documentation Bug introduced 2016-06-05 10:16 UTC by Report Bug Copy Issue Report It seems like `$cleanParam` of type `array<integer,string>` is incompatible with the declared type `array<integer,array<integer,string>>` of property `$cleanParam`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
29			}
30
31			/**
32			* Check
33			*
34			* @param string $url
35			* @return bool
36			*/
37			public function isListed($url)
38			{
39			foreach ($this->cleanParam as $param => $paths) {
40			if (
41			(
42			mb_stripos($url, "?$param=") \|\|
43			mb_stripos($url, "&$param=")
44			) &&
45			$this->checkPath($url, $paths)
46			) {
47			return true;
48			}
49			}
50			return false;
51			}
52
53			/**
54			* Export
55			*
56			* @return string[][]
57			*/
58			public function export()
59			{
60			return $this->cleanParam;
61			}
62			}
63

VIPnytt / RobotsTxtParser

Push — 2.0-dev ( 2c252e...97b412 )

CleanParamClient::isListed() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like