vipnytt\RobotsTxtParser\Client\Directives\HostClient

Complexity

Total Complexity

12

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	5
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	isListed()	0	21	4
A	export()	0	7	3
A	isPreferred()	0	4	2
A	get()	0	4	2

<?php
namespace vipnytt\RobotsTxtParser\Client\Directives;

use vipnytt\RobotsTxtParser\Parser\UrlParser;

/**
 * Class HostClient
 *
 * @package vipnytt\RobotsTxtParser\Client\Directives
 */
class HostClient implements ClientInterface
{
    use UrlParser;

    /**
     * Base Uri
     * @var string
     */
    private $base;

    /**
     * Host
     * @var string[]
     */
    private $host;

    /**
     * Parent directive
     * @var string|null
     */
    private $parent;

    /**
     * HostClient constructor.
     *
     * @param string $base
     * @param array $host
     * @param string|null $parentDirective
     */
    public function __construct($base, array $host, $parentDirective = null)
    {
        $this->base = $base;
        $this->host = $host;
        $this->parent = $parentDirective;
    }

    /**
     * Check
     *
     * @param string $url
     * @return bool
     */
    public function isListed($url)
    {
        $url = mb_strtolower($this->urlEncode($url));
        $parts = [
            'scheme' => parse_url($url, PHP_URL_SCHEME),
            'host' => parse_url($url, PHP_URL_HOST),
        ];
        $parts['port'] = is_int($port = parse_url($url, PHP_URL_PORT)) ? $port : getservbyname($parts['scheme'], 'tcp');
        $cases = [
            $parts['host'],
            $parts['host'] . ':' . $parts['port'],
            $parts['scheme'] . '://' . $parts['host'],
            $parts['scheme'] . '://' . $parts['host'] . ':' . $parts['port']
        ];
        foreach ($this->export() as $host) {

The expression $this->export() of type string|null|array<integer,string> is not guaranteed to be traversable. How about adding an additional type check?

            if (in_array($host, $cases)) {
                return true;
            }
        }
        return false;
    }

    /**
     * Export
     *
     * @return string[]|string|null
     */
    public function export()
    {
        if ($this->parent === null) {
            return isset($this->host[0]) ? $this->host[0] : null;

The expression isset($this->host[0]) ? $this->host[0] : null; of type string|null adds the type string to the return on line 83 which is incompatible with the return type declared by the interface vipnytt\RobotsTxtParser\Client\Directives\ClientInterface::export of type array.

        }
        return $this->host;
    }

    /**
     * Preferred host
     *
     * @return bool
     */
    public function isPreferred()
    {
        return empty($this->host) ? true : mb_stripos($this->urlBase($this->urlEncode($this->base)), $this->get()) !== false;
    }

    /**
     * Get
     *
     * @return string|null
     */
    public function get()
    {
        return isset($this->host[0]) ? $this->host[0] : null;
    }
}