vipnytt\RobotsTxtParser\Directives\Disallow

Complexity

Total Complexity

13

Size/Duplication

Total Lines	80
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	6	1
A	add()	11	11	3
A	addPath()	9	9	3
A	check()	9	9	4
A	export()	7	7	2

<?php
namespace vipnytt\RobotsTxtParser\Directives;

use vipnytt\RobotsTxtParser\ObjectTools;
use vipnytt\RobotsTxtParser\RobotsTxtInterface;
use vipnytt\RobotsTxtParser\UrlToolbox;

/**
 * Class Disallow
 *
 * @package vipnytt\RobotsTxtParser\Directives
 */
class Disallow implements DirectiveInterface, RobotsTxtInterface

This class seems to be duplicated in your project.

{
    use UrlToolbox;
    use ObjectTools;

    const SUB_DIRECTIVES = [
        self::DIRECTIVE_CLEAN_PARAM,
        self::DIRECTIVE_HOST,
    ];

    /**
     * Directive
     */
    const DIRECTIVE = 'Disallow';

    protected $array = [];
    protected $parent;

    protected $cleanParam;
    protected $host;

    public function __construct($array, $parent = null)
    {
        $this->array = $array;

It seems like $array of type string is incompatible with the declared type array of property $array.

        $this->cleanParam = new CleanParam([], self::DIRECTIVE);
        $this->host = new Host([], self::DIRECTIVE);
    }

    /**
     * Add
     *
     * @param string $line
     * @return bool
     */
    public function add($line)
    {
        $pair = $this->generateRulePair($line, self::SUB_DIRECTIVES);
        switch ($pair['directive']) {
            case self::DIRECTIVE_CLEAN_PARAM:
                return $this->cleanParam->add($pair['value']);
            case self::DIRECTIVE_HOST:
                return $this->host->add($pair['value']);
        }
        return $this->addPath($line);
    }

    protected function addPath($rule)
    {
        // Return an array of paths
        if (isset($this->array['path']) && in_array($rule, $this->array['path'])) {
            return false;
        }
        $this->array['path'][] = $rule;
        return true;
    }

    /**
     * Check
     *
     * @param  string $url
     * @return bool
     */
    public function check($url)
    {
        $path = $this->getPath($url);
        return (
            $this->checkPath($path, isset($this->array['path']) ? $this->array['path'] : []) ||
            $this->cleanParam->check($path) ||
            $this->host->check($url)
        );
    }

    public function export()
    {
        $result = $this->array
            + $this->cleanParam->export()
            + $this->host->export();
        return empty($result) ? [] : [self::DIRECTIVE => $result];
    }
}