vipnytt\RobotsTxtParser\SQL\SQLTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	pdoInitialize()	0	7	1
A	createTable()	0	12	3
A	tableExists()	0	9	2

<?php
namespace vipnytt\RobotsTxtParser\SQL;

use PDO;
use PDOException;

/**
 * Class SQLTrait
 *
 * @package vipnytt\RobotsTxtParser\SQL
 */
trait SQLTrait
{
    /**
     * Initialize PDO connection
     *
     * @param PDO $pdo |null
     * @return PDO
     */
    private function pdoInitialize(PDO $pdo = null)
    {
        $pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_WARNING);

It seems like $pdo is not always an object, but can also be of type null. Maybe add an additional type check?

        $pdo->setAttribute(PDO::ATTR_CASE, PDO::CASE_NATURAL);
        $pdo->setAttribute(PDO::ATTR_ORACLE_NULLS, PDO::NULL_NATURAL);
        return $pdo;
    }

    /**
     * Create table
     *
     * @param PDO $pdo
     * @param string $table
     * @param string $query
     * @return bool
     */
    private function createTable(PDO $pdo, $table, $query)
    {
        if ($this->tableExists($pdo, $table)) {
            return true;
        }
        try {
            $pdo->query($query);
        } catch (PDOException $e) {
            return FALSE;
        }
        return $this->tableExists($pdo, $table);
    }

    /**
     * Check if the table exists
     *
     * @param PDO $pdo
     * @param string $table
     * @return bool
     */
    private function tableExists(PDO $pdo, $table)
    {
        try {
            $result = $pdo->query("SELECT 1 FROM $table LIMIT 1;");
        } catch (\Exception $e) {
            return FALSE;
        }
        return $result !== FALSE;
    }
}