Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
19 | class Manage extends ManageCore |
||
20 | { |
||
21 | /** |
||
22 | * Clean the delay table |
||
23 | * |
||
24 | * @return bool |
||
25 | */ |
||
26 | View Code Duplication | public function clean() |
|
37 | |||
38 | /** |
||
39 | * Top X wait time |
||
40 | * |
||
41 | * @param int $limit |
||
42 | * @param int $minDelay |
||
43 | * @return array |
||
44 | */ |
||
45 | public function getTopWaitTimes($limit = self::TOP_X_LIMIT, $minDelay = self::TOP_X_MIN_DELAY) |
||
64 | |||
65 | /** |
||
66 | * Base class |
||
67 | * |
||
68 | * @param string $baseUri |
||
69 | * @param string $userAgent |
||
70 | * @param float|int $delay |
||
71 | * @return Base |
||
72 | */ |
||
73 | public function base($baseUri, $userAgent, $delay) |
||
77 | } |
||
78 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.