vipnytt\XRobotsTagParser\directives\UnavailableAfter

Complexity

Total Complexity

8

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	3
A	getDirective()	0	4	1
A	getValue()	0	13	4

<?php
namespace vipnytt\XRobotsTagParser\directives;

final class UnavailableAfter implements directiveInterface
{
    const DIRECTIVE = 'unavailable_after';

    const DATE_GOOGLE = 'd M Y H:i:s T';

    private $supportedDateFormats = [
        DATE_RFC850,
        self::DATE_GOOGLE
    ];

    private $value;

    /**
     * Constructor
     *
     * @param string $rule
     * @param array $options
     */
    public function __construct($rule, $options = [])
    {
        foreach ($options as $key => $value) {
            if (isset($this->$key)) {
                $this->$key = $value;
            }
        }
        $this->value = $rule;
    }

    /**
     * Get directive name
     *
     * @return string
     */
    public function getDirective()
    {
        return self::DIRECTIVE;
    }

    /**
     * Get value
     *
     * @return string|null
     */
    public function getValue()
    {
        $parts = explode(',', trim(substr($this->value, mb_stripos($this->value, self::DIRECTIVE) + mb_strlen(self::DIRECTIVE) + 1)));
        for ($i = 1; $i <= count($parts); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            foreach ($this->supportedDateFormats as $format) {
                $dateTime = date_create_from_format($format, trim(implode(',', array_slice($parts, 0, $i))));
                if ($dateTime !== false) {
                    return $dateTime->format(DATE_RFC850);
                }
            }
        }
        return null;
    }
}