VGirol / JsonApi

src/Resources/HasIdentification.php

<?php

namespace VGirol\JsonApi\Resources;

use Illuminate\Http\Request;
use VGirol\JsonApiConstant\Members;

trait HasIdentification
{
    public function getId()
    {
        return is_null($this->resource) ? null : $this->resource->getKey();
    }

    /**
     * Undocumented function
     *
     * @param Request $request
     *
     * @return void
     */
    protected function setIdentification($request)

The parameter $request is not used and could be removed.

    {
        $this->setResourceIdentification([

It seems like setResourceIdentification() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            Members::TYPE => $this->aliases->getResourceType(get_class($this->resource)),
            Members::ID => (string) $this->getId()
        ]);
    }
}