VGirol / JsonApi

src/Resources/CanCreateLink.php

<?php

namespace VGirol\JsonApi\Resources;

use Illuminate\Support\Facades\Request;
use Illuminate\Support\Facades\Route;

trait CanCreateLink
{
    /**
     * Undocumented function
     *
     * @param Request $request
     *
     * @return string
     */
    public function getDocumentSelfLink($request): string
    {
        // $url = rawurldecode($request->fullUrl());
        // $elements = explode('?', $url);
        // if (count($elements) > 1) {
        //     $elements[1] = collect(explode('&', $elements[1]))
        //         ->map(function ($item) {
        //             return collect(explode('=', $item))->map(function ($item) {
        //                 return rawurlencode($item);
        //             })->join('=');
        //         })->join('&');
        //     $url = implode('?', $elements);
        // }

        // return $url;
        return $request->fullUrl();
    }

    /**
     * Undocumented function
     *
     * @param Request $request
     * @param bool    $withQuery
     *
     * @return string|null
     */
    public function getCollectionSelfLink($request, $withQuery = false): ?string
    {
        return $this->getUrl(
            "{$this->aliases->getResourceRoute($request)}.index",
            $withQuery ? $request->query() : []

It seems like $withQuery ? $request->query() : array() can also be of type null and string; however, parameter $params of VGirol\JsonApi\Resources\CanCreateLink::getUrl() does only seem to accept array, maybe add an additional type check?

        );
    }

    /**
     * Undocumented function
     *
     * @param Request $request
     * @return string|null
     */
    public function getDocumentRelatedLink($request): ?string
    {
        return $this->getUrl(
            "{$this->aliases->getParentRoute($request)}.related.index",
            [
                'parentId' => $request->route('parentId'),
                'relationship' => $request->route('relationship')
            ]
        );
    }

    /**
     * Undocumented function
     *
     * @param string $model
     *
     * @return string
     */
    public function getResourceSelfLink($model): ?string
    {
        return $this->getUrl(
            "{$this->aliases->getResourceRoute($model)}.show",
            [
                'id' => $this->getId()

It seems like getId() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            ]
        );
    }

    /**
     * Undocumented function
     *
     * @param Model $model Parent model

The type VGirol\JsonApi\Resources\Model was not found. Maybe you did not declare it correctly or list all dependencies?

     * @param string $relationshipName
     *
     * @return string|null
     */
    public function getRelationshipSelfLink($model, string $relationshipName): ?string
    {
        return $this->getUrl(
            "{$this->aliases->getPArentRoute($model)}.relationship.index",
            [
                'parentId' => $model->getKey(),
                'relationship' => $relationshipName
            ]
        );
    }

    /**
     * Undocumented function
     *
     * @param Model $model Parent model
     * @param string $relationshipName
     *
     * @return string|null
     */
    public function getRelationshipRelatedLink($model, string $relationshipName): ?string
    {
        return $this->getUrl(
            "{$this->aliases->getParentRoute($model)}.related.index",
            [
                'parentId' => $model->getKey(),
                'relationship' => $relationshipName
            ]
        );
    }

    /**
     * Undocumented function
     *
     * @param string $routeName
     * @param array  $params
     *
     * @return string|null
     */
    private function getUrl(string $routeName, array $params = []): ?string
    {
        return Route::has($routeName) ? route($routeName, $params) : null;

The method has() does not exist on Illuminate\Support\Facades\Route.

    }
}