VGirol\JsonApiFaker\Testing\CheckMethods::checkAddSingle()

Complexity

Conditions	3
Paths	4

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	3

Importance

Changes

0

<?php
    public function checkAddSingle($factory, string $fnName, string $attrName, array $data1, array $data2)
    {
        PHPUnit::assertEmpty($factory->{$attrName});

        foreach ($data1 as $key => $value) {
            $obj = $factory->{$fnName}($key, $value);
        }

        PHPUnit::assertObjectHasAttribute($attrName, $factory);
        PHPUnit::assertEquals($data1, $factory->{$attrName});
        PHPUnit::assertSame($obj, $factory);

The variable $obj seems to be defined by a foreach iteration on line 28. Are you sure the iterator is never empty, otherwise this variable is not defined?

        foreach ($data2 as $key => $value) {
            $obj = $factory->{$fnName}($key, $value);

The assignment to $obj is dead and can be removed.

        }

        PHPUnit::assertEquals(
            array_merge($data1, $data2),
            $factory->{$attrName}
        );