Completed
Push — master ( 55a48a...8f2a9b )
by Vincent
13:15
created

TestResponse::assertStatus()   A

Complexity

Conditions 5
Paths 5

Size

Total Lines 25
Code Lines 15

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
eloc 15
c 1
b 0
f 0
dl 0
loc 25
rs 9.4555
cc 5
nc 5
nop 1
1
<?php
2
3
namespace VGirol\JsonApiAssert\Laravel;
4
5
use Illuminate\Support\Arr;
6
use Illuminate\Testing\Assert;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, VGirol\JsonApiAssert\Laravel\Assert. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
7
use Illuminate\Testing\TestResponse as IlluminateTestResponse;
8
9
class TestResponse extends IlluminateTestResponse
10
{
11
    public const ERROR_STATUS = 'Expected status code %d but received %d.';
12
13
    public function assertStatus($status)
14
    {
15
        $actual = $this->getStatusCode();
0 ignored issues
show
Bug introduced by
The method getStatusCode() does not exist on VGirol\JsonApiAssert\Laravel\TestResponse. Since you implemented __call, consider adding a @method annotation. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

15
        /** @scrutinizer ignore-call */ 
16
        $actual = $this->getStatusCode();
Loading history...
16
17
        $message = sprintf(self::ERROR_STATUS, $status, $actual);
18
        if ($actual >= 300) {
19
            $data = $this->baseResponse->getData(true);
20
            if (Arr::exists($data, 'errors')) {
21
                $errors = Arr::get($data, 'errors');
22
                if (count($errors)) {
23
                    $error = Arr::first($errors);
24
                    if (Arr::exists($error, 'details')) {
25
                        $message .= "\n" . Arr::get($error, 'details');
26
                    }
27
                }
28
            }
29
        }
30
31
        Assert::assertSame(
32
            $actual,
33
            $status,
34
            $message
35
        );
36
37
        return $this;
38
    }
39
}
40