User::getName() - Code Metrics - Inspection of "UserService refactored and tested" - VAPC/RockParade-API - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f137da...c4f5b9 )

by Petr

created 2016-09-04 19:27 UTC

User::getName() A

↳ Parent: User

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

namespace AppBundle\Entity;

use AppBundle\Entity\Infrasctucture\FormattedRegistrationDateTrait;
use AppBundle\Service\HashGenerator;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ORM\Mapping as ORM;
use JMS\Serializer\Annotation as Serializer;
use JMS\Serializer\Annotation\Accessor;
use JMS\Serializer\Annotation\SerializedName;
use JMS\Serializer\Annotation\Type as SerializerType;
use Symfony\Component\Security\Core\User\UserInterface;

/**
 * User
 * @ORM\Table(name="users")
 * @ORM\Entity(repositoryClass="AppBundle\Entity\Repository\UserRepository")
 */
class User implements UserInterface
{

    use FormattedRegistrationDateTrait;

    const TOKEN_LENGTH = 32;

    /**
     * @var string
     * @ORM\Id
     * @ORM\Column(name="login", type="string", length=255, nullable=false)
     */
    private $login;

    /**
     * @var string
     * @ORM\Column(name="name", type="string", length=255, nullable=false, unique=true)
     */
    private $name;

    /**
     * @var string
     * @ORM\Column(name="email", type="string", length=255, nullable=true, unique=true)
     * @Serializer\Exclude()
     */
    private $email;

    /**
     * @var string
     * @ORM\Column(name="description", type="text", nullable=true)
     */
    private $description;

    /**
     * @var string
     * @ORM\Column(name="vkontakte_id", type="string", length=50, nullable=false, unique=true)
     * @Serializer\Exclude()
     */
    private $vkontakteId;

    /**
     * @var string
     * @ORM\Column(name="vk_token", type="string", length=85, nullable=false)
     * @Serializer\Exclude()
     */
    private $vkToken;

    /**
     * @var string
     * @ORM\Column(name="token", type="string", length=32, nullable=false, unique=true)
     * @Serializer\Exclude()
     */
    private $token;

    /**
     * @var \DateTime
     * @ORM\Column(name="registration_date", type="datetime", nullable=false)
     * @SerializedName("registration_date")
     * @Accessor(getter="getRegistrationDate")
     * @SerializerType("string")
     */
    private $registrationDate;

    /**
     * @var array
     * @ORM\Column(name="roles", type="simple_array", nullable=true)
     * @Serializer\Exclude()
     */
    private $roles;

    /**
     * @var Event[]|ArrayCollection
     * @ORM\OneToMany(targetEntity="AppBundle\Entity\Event", mappedBy="creator")
     * @SerializerType("array")
     */
    private $events;

    /**
     * @var Band[]|ArrayCollection
     * @ORM\OneToMany(targetEntity="AppBundle\Entity\Band", mappedBy="creator")
     * @SerializerType("array")
     */
    private $createdBands;

    public function __construct(
        string $login,
        string $name,
        int $vkontakteId,
        string $vkToken,
        string $email = null,
        string $description = null,
        string $token = null
    ) {
        $this->login = $login;
        $this->name = $name;
        $this->vkontakteId = $vkontakteId;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->vkToken = $vkToken;
        $this->token = $token ?: HashGenerator::generate(self::TOKEN_LENGTH);
        $this->email = $email ?: null;
        $this->description = $description;
        $this->registrationDate = new \DateTime();
        $this->events = new ArrayCollection();
        $this->createdBands = new ArrayCollection();
    }

    /**
     * @return string
     */
    public function getLogin(): string
    {
        return $this->login;
    }

    /** {@inheritDoc} */
    public function getRoles(): array
    {
        return array_merge(
            $this->roles,
            [
                'ROLE_USER',
            ]
        );
    }

    public function setVkToken(string $vkToken)
    {
        $this->vkToken = $vkToken;
    }

    public function updateToken()
    {
        $this->token = HashGenerator::generate(self::TOKEN_LENGTH);
    }

    public function getToken(): string
    {
        return $this->token;
    }

    /** {@inheritDoc} */
    public function getPassword() {}

    /** {@inheritDoc} */
    public function getSalt() {}

    /** {@inheritDoc} */
    public function eraseCredentials() {}

    /** {@inheritDoc} */
    public function getUsername(): string
    {
        return $this->getLogin();
    }

    public function getName(): string
    {
        return $this->name;
    }
}


1		<?php
2
3		namespace AppBundle\Entity;
4
5		use AppBundle\Entity\Infrasctucture\FormattedRegistrationDateTrait;
6		use AppBundle\Service\HashGenerator;
7		use Doctrine\Common\Collections\ArrayCollection;
8		use Doctrine\ORM\Mapping as ORM;
9		use JMS\Serializer\Annotation as Serializer;
10		use JMS\Serializer\Annotation\Accessor;
11		use JMS\Serializer\Annotation\SerializedName;
12		use JMS\Serializer\Annotation\Type as SerializerType;
13		use Symfony\Component\Security\Core\User\UserInterface;
14
15		/**
16		* User
17		* @ORM\Table(name="users")
18		* @ORM\Entity(repositoryClass="AppBundle\Entity\Repository\UserRepository")
19		*/
20		class User implements UserInterface
21		{
22
23		use FormattedRegistrationDateTrait;
24
25		const TOKEN_LENGTH = 32;
26
27		/**
28		* @var string
29		* @ORM\Id
30		* @ORM\Column(name="login", type="string", length=255, nullable=false)
31		*/
32		private $login;
33
34		/**
35		* @var string
36		* @ORM\Column(name="name", type="string", length=255, nullable=false, unique=true)
37		*/
38		private $name;
39
40		/**
41		* @var string
42		* @ORM\Column(name="email", type="string", length=255, nullable=true, unique=true)
43		* @Serializer\Exclude()
44		*/
45		private $email;
46
47		/**
48		* @var string
49		* @ORM\Column(name="description", type="text", nullable=true)
50		*/
51		private $description;
52
53		/**
54		* @var string
55		* @ORM\Column(name="vkontakte_id", type="string", length=50, nullable=false, unique=true)
56		* @Serializer\Exclude()
57		*/
58		private $vkontakteId;
59
60		/**
61		* @var string
62		* @ORM\Column(name="vk_token", type="string", length=85, nullable=false)
63		* @Serializer\Exclude()
64		*/
65		private $vkToken;
66
67		/**
68		* @var string
69		* @ORM\Column(name="token", type="string", length=32, nullable=false, unique=true)
70		* @Serializer\Exclude()
71		*/
72		private $token;
73
74		/**
75		* @var \DateTime
76		* @ORM\Column(name="registration_date", type="datetime", nullable=false)
77		* @SerializedName("registration_date")
78		* @Accessor(getter="getRegistrationDate")
79		* @SerializerType("string")
80		*/
81		private $registrationDate;
82
83		/**
84		* @var array
85		* @ORM\Column(name="roles", type="simple_array", nullable=true)
86		* @Serializer\Exclude()
87		*/
88		private $roles;
89
90		/**
91		* @var Event[]\|ArrayCollection
92		* @ORM\OneToMany(targetEntity="AppBundle\Entity\Event", mappedBy="creator")
93		* @SerializerType("array")
94		*/
95		private $events;
96
97		/**
98		* @var Band[]\|ArrayCollection
99		* @ORM\OneToMany(targetEntity="AppBundle\Entity\Band", mappedBy="creator")
100		* @SerializerType("array")
101		*/
102		private $createdBands;
103
104	4	public function __construct(
105		string $login,
106		string $name,
107		int $vkontakteId,
108		string $vkToken,
109		string $email = null,
110		string $description = null,
111		string $token = null
112		) {
113	4	$this->login = $login;
114	4	$this->name = $name;
115	4	$this->vkontakteId = $vkontakteId;
		0 ignored issues – show Documentation Bug introduced 2016-09-04 12:04 UTC by Report Bug Copy Issue Report The property `$vkontakteId` was declared of type `string`, but `$vkontakteId` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
116	4	$this->vkToken = $vkToken;
117	4	$this->token = $token ?: HashGenerator::generate(self::TOKEN_LENGTH);
118	4	$this->email = $email ?: null;
119	4	$this->description = $description;
120	4	$this->registrationDate = new \DateTime();
121	4	$this->events = new ArrayCollection();
122	4	$this->createdBands = new ArrayCollection();
123	4	}
124
125		/**
126		* @return string
127		*/
128	25	public function getLogin(): string
129		{
130	25	return $this->login;
131		}
132
133		/** {@inheritDoc} */
134	24	public function getRoles(): array
135		{
136	24	return array_merge(
137	24	$this->roles,
138		[
139	24	'ROLE_USER',
140		]
141		);
142		}
143
144		public function setVkToken(string $vkToken)
145		{
146		$this->vkToken = $vkToken;
147		}
148
149		public function updateToken()
150		{
151		$this->token = HashGenerator::generate(self::TOKEN_LENGTH);
152		}
153
154	1	public function getToken(): string
155		{
156	1	return $this->token;
157		}
158
159		/** {@inheritDoc} */
160		public function getPassword() {}
161
162		/** {@inheritDoc} */
163		public function getSalt() {}
164
165		/** {@inheritDoc} */
166		public function eraseCredentials() {}
167
168		/** {@inheritDoc} */
169	25	public function getUsername(): string
170		{
171	25	return $this->getLogin();
172		}
173
174	1	public function getName(): string
175		{
176	1	return $this->name;
177		}
178		}
179

VAPC / RockParade-API

Push — master ( f137da...c4f5b9 )

User::getName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like