Link::__construct() - Code Metrics - Inspection of "Event::getLinks() extraction" - VAPC/RockParade-API - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( eb296b...63b45b )

by Petr

created 2016-09-07 23:45 UTC

Link::__construct() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
c	2
b	1
f	1
dl	0
loc	7
ccs	6
cts	6
cp	1
rs	9.4285
cc	2
eloc	5
nc	2
nop	3
crap	2

<?php

namespace AppBundle\Entity;

use AppBundle\Service\HashGenerator;
use Doctrine\ORM\Mapping as ORM;

/**
 * URL Link
 * @ORM\Table(name="links")
 * @ORM\Entity(repositoryClass="AppBundle\Entity\Repository\LinkRepository")
 */
class Link
{

    const ID_HASH_LENGTH = 32;

    /**
     * @var string
     * @ORM\Column(name="url", type="string", length=255)
     * @ORM\Id
     */
    private $url;

    /**
     * @var string
     * @ORM\Column(name="description", type="text", nullable=true)
     */
    private $description;

    /**
     * @param string $url
     * @param string $description
     */
    public function __construct(string $url, string $description = null, HashGenerator $hashGenerator = null)
    {
        $hashGenerator = $hashGenerator ?: new HashGenerator();
        $this->id = $hashGenerator::generate(self::ID_HASH_LENGTH);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->url = $url;
        $this->description = $description;
    }

    public function getId(): string
    {
        return $this->id;
    }

    public function getUrl(): string
    {
        return $this->url;
    }

    /**
     * @return string|null
     */
    public function getDescription()
    {
        return $this->description;
    }
}


1		<?php
2
3		namespace AppBundle\Entity;
4
5		use AppBundle\Service\HashGenerator;
6		use Doctrine\ORM\Mapping as ORM;
7
8		/**
9		* URL Link
10		* @ORM\Table(name="links")
11		* @ORM\Entity(repositoryClass="AppBundle\Entity\Repository\LinkRepository")
12		*/
13		class Link
14		{
15
16		const ID_HASH_LENGTH = 32;
17
18		/**
19		* @var string
20		* @ORM\Column(name="url", type="string", length=255)
21		* @ORM\Id
22		*/
23		private $url;
24
25		/**
26		* @var string
27		* @ORM\Column(name="description", type="text", nullable=true)
28		*/
29		private $description;
30
31		/**
32		* @param string $url
33		* @param string $description
34		*/
35	1	public function __construct(string $url, string $description = null, HashGenerator $hashGenerator = null)
36		{
37	1	$hashGenerator = $hashGenerator ?: new HashGenerator();
38	1	$this->id = $hashGenerator::generate(self::ID_HASH_LENGTH);
		0 ignored issues – show Bug introduced 2016-09-07 23:49 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
39	1	$this->url = $url;
40	1	$this->description = $description;
41	1	}
42
43		public function getId(): string
44		{
45		return $this->id;
46		}
47
48	5	public function getUrl(): string
49		{
50	5	return $this->url;
51		}
52
53		/**
54		* @return string\|null
55		*/
56	5	public function getDescription()
57		{
58	5	return $this->description;
59		}
60		}
61

VAPC / RockParade-API

Push — master ( eb296b...63b45b )

Link::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like