AmbassadorRepository::findOneByFormData() - Code Metrics - Inspection of "AmbassadorRepository added" - VAPC/RockParade-API - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ccd743...0e7290 )

by Petr

created 2016-09-14 13:29 UTC

AmbassadorRepository::findOneByFormData() A

↳ Parent: AmbassadorRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1

<?php

namespace AppBundle\Entity\Infrasctucture;

use AppBundle\Entity\User;
use AppBundle\Form\AbstractFormType;
use AppBundle\Form\Ambassador\AmbassadorFormType;

/**
 * @author Vehsamrak
 */
class AmbassadorRepository extends AbstractRepository
{

    /**
     * @return Ambassador|object|null
     */
    public function findOneByName(string $name)
    {
        return $this->findOneBy(
            [
                'name' => $name,
            ]
        );
    }

    /**
     * @param AmbassadorFormType $formType
     * @param User $creator
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return Ambassador|null|object
     */
    public function findOneByFormData(AbstractFormType $formType)
    {
        $ambassadorName = $formType->name;

        $ambassador = $this->findOneByName($ambassadorName);

        return $ambassador;
    }
}


1			<?php
2
3			namespace AppBundle\Entity\Infrasctucture;
4
5			use AppBundle\Entity\User;
6			use AppBundle\Form\AbstractFormType;
7			use AppBundle\Form\Ambassador\AmbassadorFormType;
8
9			/**
10			* @author Vehsamrak
11			*/
12			class AmbassadorRepository extends AbstractRepository
13			{
14
15			/**
16			* @return Ambassador\|object\|null
17			*/
18			public function findOneByName(string $name)
19			{
20			return $this->findOneBy(
21			[
22			'name' => $name,
23			]
24			);
25			}
26
27			/**
28			* @param AmbassadorFormType $formType
29			* @param User $creator
			0 ignored issues – show Bug introduced 2016-09-14 13:40 UTC by Report Bug Copy Issue Report There is no parameter named `$creator`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
30			* @return Ambassador\|null\|object
31			*/
32			public function findOneByFormData(AbstractFormType $formType)
33			{
34			$ambassadorName = $formType->name;
			0 ignored issues – show Bug introduced 2016-09-14 13:40 UTC by Report Bug Copy Issue Report The property `name` does not seem to exist in `AppBundle\Form\AbstractFormType`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
35			$ambassador = $this->findOneByName($ambassadorName);
36
37			return $ambassador;
38			}
39			}
40

VAPC / RockParade-API

Push — master ( ccd743...0e7290 )

AmbassadorRepository::findOneByFormData() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like