AmbassadorMemberRepository::getOrCreateByAmbassadorAndUser() - Code Metrics - Inspection of "BandController refactoring with ambassador members..." - VAPC/RockParade-API - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 21a45d...334091 )

by Petr

created 2016-09-19 01:27 UTC

getOrCreateByAmbassadorAndUser() A

↳ Parent: AmbassadorMemberRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	12
nc	2
nop	4
crap	2

<?php

namespace AppBundle\Entity\Infrasctucture;

use AppBundle\Entity\Band;
use AppBundle\Entity\BandMember;
use AppBundle\Entity\User;

/**
 * @author Vehsamrak
 */
class AmbassadorMemberRepository extends AbstractRepository
{

    /**
     * @param Ambassador $ambassador
     * @param User $user
     * @return AmbassadorMember|object|null
     */
    public function findByAmbassadorAndUser(Ambassador $ambassador, User $user)
    {
        return $this->findOneBy(
            [
                'ambassador' => $ambassador,
                'user'       => $user,
            ]
        );
    }

    public function getOrCreateByAmbassadorAndUser(
        Ambassador $ambassador,
        User $user,
        string $shortDescription = '',
        string $description = null
    ): AmbassadorMember
    {
        $ambassadorMember = $this->findByAmbassadorAndUser($ambassador, $user);

        if (!$ambassadorMember) {
            $ambassadorClass = $ambassador->getMemberClass();
            $ambassadorMember = new $ambassadorClass($ambassador, $user, $shortDescription, $description);
            $this->persist($ambassadorMember);
        }

        return $ambassadorMember;
    }
}


1		<?php
2
3		namespace AppBundle\Entity\Infrasctucture;
4
5		use AppBundle\Entity\Band;
6		use AppBundle\Entity\BandMember;
7		use AppBundle\Entity\User;
8
9		/**
10		* @author Vehsamrak
11		*/
12		class AmbassadorMemberRepository extends AbstractRepository
13		{
14
15		/**
16		* @param Ambassador $ambassador
17		* @param User $user
18		* @return AmbassadorMember\|object\|null
19		*/
20	6	public function findByAmbassadorAndUser(Ambassador $ambassador, User $user)
21		{
22	6	return $this->findOneBy(
23		[
24	6	'ambassador' => $ambassador,
25	6	'user' => $user,
26		]
27		);
28		}
29
30	4	public function getOrCreateByAmbassadorAndUser(
31		Ambassador $ambassador,
32		User $user,
33		string $shortDescription = '',
34		string $description = null
35		): AmbassadorMember
36		{
37	4	$ambassadorMember = $this->findByAmbassadorAndUser($ambassador, $user);
38
39	4	if (!$ambassadorMember) {
40	4	$ambassadorClass = $ambassador->getMemberClass();
41	4	$ambassadorMember = new $ambassadorClass($ambassador, $user, $shortDescription, $description);
42	4	$this->persist($ambassadorMember);
43		}
44
45	4	return $ambassadorMember;
46		}
47		}
48

VAPC / RockParade-API

Push — master ( 21a45d...334091 )

getOrCreateByAmbassadorAndUser() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like