AmbassadorService::createAmbassador() - Code Metrics - VAPC/RockParade-API - Measure and Improve Code Quality continuously with Scrutinizer

AmbassadorService::createAmbassador() B
last analyzed 2016-09-23 11:46 UTC

↳ Parent: AmbassadorService

Complexity

Conditions	2
Paths	2

Size

Total Lines	34
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	34
ccs	17
cts	17
cp	1
rs	8.8571
cc	2
eloc	21
nc	2
nop	2
crap	2

<?php

namespace AppBundle\Service\Ambassador;

use AppBundle\Entity\BandMember;
use AppBundle\Entity\Infrasctucture\Ambassador;
use AppBundle\Entity\Infrasctucture\AmbassadorMemberRepository;
use AppBundle\Entity\Infrasctucture\AmbassadorRepository;
use AppBundle\Entity\User;
use AppBundle\Exception\FormTypeNotSupported;
use AppBundle\Form\AbstractFormType;
use AppBundle\Form\Ambassador\AmbassadorFormType;
use AppBundle\Form\Ambassador\AmbassadorMemberFormType;
use AppBundle\Service\Entity\BandService;
use AppBundle\Service\Entity\Infrastructure\EntityCreatorInterface;
use Doctrine\ORM\EntityManager;

/**
 * @author Vehsamrak
 */
class AmbassadorService implements EntityCreatorInterface
{

    /** @var EntityManager */
    private $entityManager;

    /** @var BandService */
    private $bandService;

    public function __construct(EntityManager $entityManager, BandService $bandService)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $entityManager;
        $this->bandService = $bandService;
    }

    public function createEntityByFormData(AbstractFormType $formType, User $creator)
    {
        if ($formType instanceof AmbassadorFormType) {
            $entity = $this->createAmbassador($formType, $creator);
        } elseif ($formType instanceof AmbassadorMemberFormType) {
            $entity = $this->createAmbassadorMember($formType);
        } else {
            throw new FormTypeNotSupported(get_class($formType));
        }

        $this->entityManager->flush($entity);

        return $entity;
    }

    private function getOrCreateMemberByAmbassadorAndUserLogin(
        Ambassador $ambassador,
        $memberLogin,
        $memberShortDescription = '',
        $memberDescription = ''
    ) {
        $user = $this->entityManager->getRepository(User::class)->findOneByLogin($memberLogin);
        /** @var AmbassadorMemberRepository $repository */
        $repository = $this->entityManager->getRepository($ambassador->getMemberClass());

        return $repository->getOrCreateByAmbassadorAndUser(
            $ambassador,
            $user,
            $memberShortDescription,
            $memberDescription
        );

    }

    private function createAmbassador(AmbassadorFormType $formType, User $creator)
    {
        $ambassadorName = $formType->name;
        $ambassadorDescription = $formType->description;
        $ambassadorMemberLogins = (array) $formType->members;

        $entityClass = $formType->getEntityClassName();
        /** @var Ambassador $ambassador */
        $ambassador = new $entityClass($ambassadorName, $creator, $ambassadorDescription);
        /** @var AmbassadorRepository $repository */
        $repository = $this->entityManager->getRepository($entityClass);
        $repository->persist($ambassador);

        $creatorMember = $this->bandService->createAmbassadorMemberFromCreator($ambassador, $creator);
        $ambassador->addMember($creatorMember);

        foreach ($ambassadorMemberLogins as $memberData) {
            $memberLogin = $memberData['login'];
            $memberShortDescription = $memberData['short_description'];
            $memberDescription = $memberData['description'] ?? '';

            /** @var BandMember $member */
            $member = $this->getOrCreateMemberByAmbassadorAndUserLogin(
                $ambassador,
                $memberLogin,
                $memberShortDescription,
                $memberDescription
            );

            $ambassador->addMember($member);
        }

        return $ambassador;
    }

    private function createAmbassadorMember(AmbassadorMemberFormType $formType)
    {
        $ambassadorId = $formType->ambassador;
        /** @var AmbassadorRepository $ambassadorRepository */
        $ambassadorRepository = $this->entityManager->getRepository($formType->getEntityClassName());
        $ambassador = $ambassadorRepository->findOneById($ambassadorId);

        return $this->getOrCreateMemberByAmbassadorAndUserLogin(
            $ambassador,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $formType->login,
            $formType->shortDescription,
            $formType->description
        );
    }
}


1		<?php
2
3		namespace AppBundle\Service\Ambassador;
4
5		use AppBundle\Entity\BandMember;
6		use AppBundle\Entity\Infrasctucture\Ambassador;
7		use AppBundle\Entity\Infrasctucture\AmbassadorMemberRepository;
8		use AppBundle\Entity\Infrasctucture\AmbassadorRepository;
9		use AppBundle\Entity\User;
10		use AppBundle\Exception\FormTypeNotSupported;
11		use AppBundle\Form\AbstractFormType;
12		use AppBundle\Form\Ambassador\AmbassadorFormType;
13		use AppBundle\Form\Ambassador\AmbassadorMemberFormType;
14		use AppBundle\Service\Entity\BandService;
15		use AppBundle\Service\Entity\Infrastructure\EntityCreatorInterface;
16		use Doctrine\ORM\EntityManager;
17
18		/**
19		* @author Vehsamrak
20		*/
21		class AmbassadorService implements EntityCreatorInterface
22		{
23
24		/** @var EntityManager */
25		private $entityManager;
26
27		/** @var BandService */
28		private $bandService;
29
30	16	public function __construct(EntityManager $entityManager, BandService $bandService)
		0 ignored issues – show Bug introduced 2016-09-15 23:08 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
31		{
32	16	$this->entityManager = $entityManager;
33	16	$this->bandService = $bandService;
34	16	}
35
36	5	public function createEntityByFormData(AbstractFormType $formType, User $creator)
37		{
38	5	if ($formType instanceof AmbassadorFormType) {
39	3	$entity = $this->createAmbassador($formType, $creator);
40		} elseif ($formType instanceof AmbassadorMemberFormType) {
41	2	$entity = $this->createAmbassadorMember($formType);
42		} else {
43		throw new FormTypeNotSupported(get_class($formType));
44		}
45
46	5	$this->entityManager->flush($entity);
47
48	5	return $entity;
49		}
50
51	4	private function getOrCreateMemberByAmbassadorAndUserLogin(
52		Ambassador $ambassador,
53		$memberLogin,
54		$memberShortDescription = '',
55		$memberDescription = ''
56		) {
57	4	$user = $this->entityManager->getRepository(User::class)->findOneByLogin($memberLogin);
58		/** @var AmbassadorMemberRepository $repository */
59	4	$repository = $this->entityManager->getRepository($ambassador->getMemberClass());
60
61	4	return $repository->getOrCreateByAmbassadorAndUser(
62		$ambassador,
63		$user,
64		$memberShortDescription,
65		$memberDescription
66		);
67
68		}
69
70	3	private function createAmbassador(AmbassadorFormType $formType, User $creator)
71		{
72	3	$ambassadorName = $formType->name;
73	3	$ambassadorDescription = $formType->description;
74	3	$ambassadorMemberLogins = (array) $formType->members;
75
76	3	$entityClass = $formType->getEntityClassName();
77		/** @var Ambassador $ambassador */
78	3	$ambassador = new $entityClass($ambassadorName, $creator, $ambassadorDescription);
79		/** @var AmbassadorRepository $repository */
80	3	$repository = $this->entityManager->getRepository($entityClass);
81	3	$repository->persist($ambassador);
82
83	3	$creatorMember = $this->bandService->createAmbassadorMemberFromCreator($ambassador, $creator);
84	3	$ambassador->addMember($creatorMember);
85
86	3	foreach ($ambassadorMemberLogins as $memberData) {
87	2	$memberLogin = $memberData['login'];
88	2	$memberShortDescription = $memberData['short_description'];
89	2	$memberDescription = $memberData['description'] ?? '';
90
91		/** @var BandMember $member */
92	2	$member = $this->getOrCreateMemberByAmbassadorAndUserLogin(
93		$ambassador,
94		$memberLogin,
95		$memberShortDescription,
96		$memberDescription
97		);
98
99	2	$ambassador->addMember($member);
100		}
101
102	3	return $ambassador;
103		}
104
105	2	private function createAmbassadorMember(AmbassadorMemberFormType $formType)
106		{
107	2	$ambassadorId = $formType->ambassador;
108		/** @var AmbassadorRepository $ambassadorRepository */
109	2	$ambassadorRepository = $this->entityManager->getRepository($formType->getEntityClassName());
110	2	$ambassador = $ambassadorRepository->findOneById($ambassadorId);
111
112	2	return $this->getOrCreateMemberByAmbassadorAndUserLogin(
113		$ambassador,
		0 ignored issues – show Documentation introduced 2016-09-19 01:30 UTC by Report Bug Copy Issue Report `$ambassador` is of type `object\|null`, but the function expects a `object<AppBundle\Entity\...rasctucture\Ambassador>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
114	2	$formType->login,
115	2	$formType->shortDescription,
116	2	$formType->description
117		);
118		}
119		}
120

VAPC / RockParade-API

AmbassadorService::createAmbassador() B last analyzed 2016-09-23 11:46 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

AmbassadorService::createAmbassador() B
last analyzed 2016-09-23 11:46 UTC