awips.dataaccess.ThriftClientRouter

Complexity

Total Complexity

47

Size/Duplication

Total Lines	259
Duplicated Lines	79.92 %

Importance

Changes

0

16 Methods

Rating	Name	Duplication	Size	Complexity
A	ThriftClientRouter.getAvailableTimes()	6	6	1
A	ThriftClientRouter.__init__()	3	3	1
A	ThriftClientRouter.getSupportedDatatypes()	7	7	3
A	ThriftClientRouter.getRequiredIdentifiers()	12	12	4
A	ThriftClientRouter.getIdentifierValues()	10	10	3
B	ThriftClientRouter.newDataRequest()	16	16	7
A	ThriftClientRouter.getOptionalIdentifiers()	12	12	4
A	ThriftClientRouter.getAvailableLocationNames()	9	9	3
B	ThriftClientRouter.getGridData()	49	49	8
A	ThriftClientRouter.setLazyLoadGridLatLon()	2	2	1
A	LazyGridLatLon.__init__()	8	8	1
A	ThriftClientRouter.getNotificationFilter()	5	5	1
A	ThriftClientRouter.getGeometryData()	24	24	4
A	ThriftClientRouter.getAvailableParameters()	9	9	3
A	ThriftClientRouter.getAvailableLevels()	5	5	1
A	LazyGridLatLon.__call__()	12	12	2

#
# Routes requests to the Data Access Framework through Python Thrift.
#
#
#
#    SOFTWARE HISTORY
#
#    Date            Ticket#       Engineer       Description
#    ------------    ----------    -----------    --------------------------
#    05/21/13        2023          dgilling       Initial Creation.
#    01/06/14        2537          bsteffen       Share geometry WKT.
#    03/03/14        2673          bsteffen       Add ability to query only ref times.
#    07/22/14        3185          njensen        Added optional/default args to newDataRequest
#    07/23/14        3185          njensen        Added new methods
#    07/30/14        3185          njensen        Renamed valid identifiers to optional
#    06/30/15        4569          nabowle        Use hex WKB for geometries.
#    04/13/15        5379          tgurney        Add getIdentifierValues()
#    06/01/16        5587          tgurney        Add new signatures for
#                                                 getRequiredIdentifiers() and
#                                                 getOptionalIdentifiers()
#    08/01/16        2416          tgurney        Add getNotificationFilter()
#    10/13/16        5916          bsteffen       Correct grid shape, allow lazy grid lat/lon
#    10/26/16        5919          njensen        Speed up geometry creation in getGeometryData()
#


import numpy
import six
import shapely.wkb

from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.impl import DefaultDataRequest
from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetAvailableLocationNamesRequest

This line is too long as per the coding-style (111/100).

from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetAvailableTimesRequest

This line is too long as per the coding-style (103/100).

from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetGeometryDataRequest

This line is too long as per the coding-style (101/100).

from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetGridDataRequest
from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetGridLatLonRequest
from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetAvailableParametersRequest

This line is too long as per the coding-style (108/100).

from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetAvailableLevelsRequest

This line is too long as per the coding-style (104/100).

from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetRequiredIdentifiersRequest

This line is too long as per the coding-style (108/100).

from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetOptionalIdentifiersRequest

This line is too long as per the coding-style (108/100).

from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetIdentifierValuesRequest

This line is too long as per the coding-style (105/100).

from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetSupportedDatatypesRequest

This line is too long as per the coding-style (107/100).

from dynamicserialize.dstypes.com.raytheon.uf.common.dataaccess.request import GetNotificationFilterRequest

This line is too long as per the coding-style (107/100).

from awips import ThriftClient
from awips.dataaccess import PyGeometryData
from awips.dataaccess import PyGridData


class LazyGridLatLon(object):

This code seems to be duplicated in your project.

The variable __class__ seems to be unused.

    def __init__(self, client, nx, ny, envelope, crsWkt):

Too many arguments (6/5)

        self._latLonGrid = None
        self._client = client
        self._request = GetGridLatLonRequest()
        self._request.setNx(nx)
        self._request.setNy(ny)
        self._request.setEnvelope(envelope)
        self._request.setCrsWkt(crsWkt)

    def __call__(self):
        # Its important that the data is cached internally so that if multiple
        # GridData are sharing the same delegate then they can also share a
        # single request for the LatLon information.
        if self._latLonGrid is None:
            response = self._client.sendRequest(self._request)
            nx = response.getNx()
            ny = response.getNy()
            latData = numpy.reshape(numpy.array(response.getLats()), (ny, nx))
            lonData = numpy.reshape(numpy.array(response.getLons()), (ny, nx))
            self._latLonGrid = (lonData, latData)
        return self._latLonGrid


class ThriftClientRouter(object):

This code seems to be duplicated in your project.

The variable __class__ seems to be unused.

    def __init__(self, host='localhost'):
        self._client = ThriftClient.ThriftClient(host)
        self._lazyLoadGridLatLon = False

    def setLazyLoadGridLatLon(self, lazyLoadGridLatLon):
        self._lazyLoadGridLatLon = lazyLoadGridLatLon

    def getAvailableTimes(self, request, refTimeOnly):
        timesRequest = GetAvailableTimesRequest()
        timesRequest.setRequestParameters(request)
        timesRequest.setRefTimeOnly(refTimeOnly)
        response = self._client.sendRequest(timesRequest)
        return response

    def getGridData(self, request, times):

This function exceeds the maximum number of variables (20/15).

        gridDataRequest = GetGridDataRequest()
        gridDataRequest.setIncludeLatLonData(not self._lazyLoadGridLatLon)
        gridDataRequest.setRequestParameters(request)
        # if we have an iterable times instance, then the user must have asked
        # for grid data with the List of DataTime objects
        # else, we assume it was a single TimeRange that was meant for the
        # request
        try:
            iter(times)
            gridDataRequest.setRequestedTimes(times)
        except TypeError:
            gridDataRequest.setRequestedPeriod(times)
        response = self._client.sendRequest(gridDataRequest)

        locSpecificData = {}
        locNames = list(response.getSiteNxValues().keys())
        for location in locNames:
            nx = response.getSiteNxValues()[location]
            ny = response.getSiteNyValues()[location]
            if self._lazyLoadGridLatLon:
                envelope = response.getSiteEnvelopes()[location]
                crsWkt = response.getSiteCrsWkt()[location]
                delegate = LazyGridLatLon(
                    self._client, nx, ny, envelope, crsWkt)
                locSpecificData[location] = (nx, ny, delegate)
            else:
                latData = numpy.reshape(numpy.array(
                    response.getSiteLatGrids()[location]), (ny, nx))
                lonData = numpy.reshape(numpy.array(
                    response.getSiteLonGrids()[location]), (ny, nx))
                locSpecificData[location] = (nx, ny, (lonData, latData))
        retVal = []
        for gridDataRecord in response.getGridData():
            locationName = gridDataRecord.getLocationName()
            if locationName is not None:
                if six.PY2:
                    locData = locSpecificData[locationName]
                else:
                    locData = locSpecificData[locationName.encode('utf-8')]
            else:
                locData = locSpecificData[locationName]
            if self._lazyLoadGridLatLon:
                retVal.append(PyGridData.PyGridData(gridDataRecord, locData[
                              0], locData[1], latLonDelegate=locData[2]))
            else:
                retVal.append(PyGridData.PyGridData(
                    gridDataRecord, locData[0], locData[1], locData[2]))
        return retVal

    def getGeometryData(self, request, times):
        geoDataRequest = GetGeometryDataRequest()
        geoDataRequest.setRequestParameters(request)
        # if we have an iterable times instance, then the user must have asked
        # for geometry data with the List of DataTime objects
        # else, we assume it was a single TimeRange that was meant for the
        # request
        try:
            iter(times)
            geoDataRequest.setRequestedTimes(times)
        except TypeError:
            geoDataRequest.setRequestedPeriod(times)
        response = self._client.sendRequest(geoDataRequest)
        geometries = []
        for wkb in response.getGeometryWKBs():
            # the wkb is a numpy.ndarray of dtype int8
            # convert the bytearray to a byte string and load it
            geometries.append(shapely.wkb.loads(wkb.tostring()))

        retVal = []
        for geoDataRecord in response.getGeoData():
            geom = geometries[geoDataRecord.getGeometryWKBindex()]
            retVal.append(PyGeometryData.PyGeometryData(geoDataRecord, geom))
        return retVal

    def getAvailableLocationNames(self, request):
        locNamesRequest = GetAvailableLocationNamesRequest()
        locNamesRequest.setRequestParameters(request)
        response = self._client.sendRequest(locNamesRequest)
        if six.PY2:
            return response
        if response is not None:
            return [x.decode('utf-8') for x in response]
        return response

    def getAvailableParameters(self, request):
        paramReq = GetAvailableParametersRequest()
        paramReq.setRequestParameters(request)
        response = self._client.sendRequest(paramReq)
        if six.PY2:
            return response
        if response is not None:
            return [x.decode('utf-8') for x in response]
        return response

    def getAvailableLevels(self, request):
        levelReq = GetAvailableLevelsRequest()
        levelReq.setRequestParameters(request)
        response = self._client.sendRequest(levelReq)
        return response

    def getRequiredIdentifiers(self, request):
        if str(request) == request:
            # Handle old version getRequiredIdentifiers(str)
            request = self.newDataRequest(request)
        idReq = GetRequiredIdentifiersRequest()
        idReq.setRequest(request)
        response = self._client.sendRequest(idReq)
        if six.PY2:
            return response
        if response is not None:
            return [x.decode('utf-8') for x in response]
        return response

    def getOptionalIdentifiers(self, request):
        if str(request) == request:
            # Handle old version getOptionalIdentifiers(str)
            request = self.newDataRequest(request)
        idReq = GetOptionalIdentifiersRequest()
        idReq.setRequest(request)
        response = self._client.sendRequest(idReq)
        if six.PY2:
            return response
        if response is not None:
            return [x.decode('utf-8') for x in response]
        return response

    def getIdentifierValues(self, request, identifierKey):
        idValReq = GetIdentifierValuesRequest()
        idValReq.setIdentifierKey(identifierKey)
        idValReq.setRequestParameters(request)
        response = self._client.sendRequest(idValReq)
        if six.PY2:
            return response
        if response is not None:
            return [x.decode('utf-8') for x in response]
        return response

    def newDataRequest(self, datatype, parameters=[], levels=[], locationNames=[], envelope=None, **kwargs):

This line is too long as per the coding-style (108/100).

The default value [] might cause unintended side-effects.

Too many arguments (6/5)

This method could be written as a function/class method.

        req = DefaultDataRequest()
        if datatype:
            req.setDatatype(datatype)
        if parameters:
            req.setParameters(*parameters)
        if levels:
            req.setLevels(*levels)
        if locationNames:
            req.setLocationNames(*locationNames)
        if envelope:
            req.setEnvelope(envelope)
        if kwargs:
            # any args leftover are assumed to be identifiers
            req.identifiers = kwargs
        return req

    def getSupportedDatatypes(self):
        response = self._client.sendRequest(GetSupportedDatatypesRequest())
        if six.PY2:
            return response
        if response is not None:
            return [x.decode('utf-8') for x in response]
        return response

    def getNotificationFilter(self, request):
        notifReq = GetNotificationFilterRequest()
        notifReq.setRequestParameters(request)
        response = self._client.sendRequest(notifReq)
        return response