Issues (339)

src/Image.php (26 issues)

1
<?php
0 ignored issues
show
This file is missing a doc comment.
Loading history...
The PHP open tag does not have a corresponding PHP close tag
Loading history...
Filename "Image.php" doesn't match the expected filename "image.php"
Loading history...
2
0 ignored issues
show
Missing file doc comment
Loading history...
3
namespace UniSharp\Uploadable;
4
5
use Illuminate\Support\Facades\URL;
6
7
class Image extends File
0 ignored issues
show
Coding Style Documentation introduced by
Missing class doc comment
Loading history...
8
{
0 ignored issues
show
Opening brace should be on the same line as the declaration for class Image
Loading history...
9
    protected $table = 'files';
0 ignored issues
show
Protected member variable "table" must contain a leading underscore
Loading history...
Expected 1 blank line before member var; 0 found
Loading history...
Coding Style Documentation introduced by
Missing member variable doc comment
Loading history...
10
11
    protected $appends = ['thumb'];
0 ignored issues
show
Protected member variable "appends" must contain a leading underscore
Loading history...
Coding Style Documentation introduced by
Missing member variable doc comment
Loading history...
Short array syntax is not allowed
Loading history...
12
13
    public function getThumbAttribute(): array
0 ignored issues
show
Expected 2 blank lines before function; 1 found
Loading history...
Missing function doc comment
Loading history...
14
    {
0 ignored issues
show
Opening brace should be on the same line as the declaration
Loading history...
15 2
        return collect(['s', 'm', 'l'])->flip()->map(function ($_, $size) {
0 ignored issues
show
Short array syntax is not allowed
Loading history...
The opening parenthesis of a multi-line function call should be the last content on the line.
Loading history...
The method parameter $_ is never used
Loading history...
Variable "_" is not in valid camel caps format
Loading history...
16 2
            return URL::to(preg_replace('/^(images\/)/', "\$1{$size}/", $this->attributes['path']));
0 ignored issues
show
Coding Style Best Practice introduced by
As per coding-style, please use concatenation or sprintf for the variable $size instead of interpolation.

It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings.

// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
Loading history...
17 2
        })->toArray();
0 ignored issues
show
For multi-line function calls, the closing parenthesis should be on a new line.

If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line:

someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
Loading history...
18
    }
0 ignored issues
show
Expected 2 blank lines after function; 0 found
Loading history...
Expected 1 blank line before closing function brace; 0 found
Loading history...
Expected //end getThumbAttribute()
Loading history...
19
}
0 ignored issues
show
Expected //end class
Loading history...
As per coding style, files should not end with a newline character.

This check marks files that end in a newline character, i.e. an empy line.

Loading history...
20